Module Alloc Monitor diff table page update by gartung · Pull Request #2727 · cms-sw/cms-bot

gartung · 2026-04-20T17:56:20Z

Use web page with javascript and json diff data to display diff table in a sortable table that is performant.
Web page template created with CoPilot in VSCode.

…play ModuleAllocMonitor diff json file.

…s, and update sorting functionality

…table-redo

…ansitions and update quantity selection functionality

… and variables for improved clarity

cmsbuild · 2026-04-20T17:56:47Z

A new Pull Request was created by @gartung for branch master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2026-04-20T17:56:48Z

cms-bot internal usage

cmsbuild · 2026-04-20T17:57:32Z

Pull request #2727 was updated.

…t, update rows per page input, and enhance data validation logic

cmsbuild · 2026-04-20T20:04:28Z

Pull request #2727 was updated.

…dule allocation viewer

cmsbuild · 2026-04-22T16:03:47Z

Pull request #2727 was updated.

cmsbuild · 2026-04-22T18:03:57Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ac3f7/52827/summary.html
COMMIT: 7a18f9e
CMSSW: CMSSW_17_0_X_2026-04-22-1100/el8_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2727/52827/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4186853
DQMHistoTests: Total failures: 81
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4186752
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

makortel

The result looks good! I have one comment on the implementation.

…proved performance and consistency Co-authored-by: Copilot <copilot@github.com>

cmsbuild · 2026-04-22T18:59:30Z

Pull request #2727 was updated.

gartung · 2026-04-22T19:00:48Z

test parameters:

workflows_profiling = 18634.21
enable = profiling

gartung · 2026-04-22T19:14:38Z

please test

cmsbuild · 2026-04-22T21:03:59Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ac3f7/52829/summary.html
COMMIT: a1bdede
CMSSW: CMSSW_17_0_X_2026-04-22-1100/el8_amd64_gcc13
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2727/52829/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4186853
DQMHistoTests: Total failures: 125
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4186708
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

makortel · 2026-04-22T21:24:44Z

Looks good to me

gartung · 2026-04-22T21:50:45Z

@smuzaffar @akritkbehera please merge

smuzaffar · 2026-04-22T21:53:06Z

+externals

cmsbuild · 2026-04-22T21:53:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

gartung added 10 commits April 17, 2026 13:32

Try using DataTables javascript

09abd80

Remove DataTables javascript which make the page hang

a7b3633

Add module_alloc_monitor_view.html cooked up by VSCode Copilot to dis…

dba2585

…play ModuleAllocMonitor diff json file.

Enhance module allocation viewer: improve layout, add sortable column…

edcf053

…s, and update sorting functionality

Merge branch 'gartung-module-alloc-monitor-viewer' into gartung-sort-…

cef1382

…table-redo

Add HTML viewer generation for module allocation comparison results

e55a276

Add row-break and update dropzone styles for improved layout

b7d785f

Update datamapres with totals after processing modules

6ee07b4

Enhance module allocation viewer: add expandable rows for detailed tr…

26dc07d

…ansitions and update quantity selection functionality

Refactor module allocation comparison script: remove unused functions…

853af1d

… and variables for improved clarity

cmsbuild added orp-pending pending-signatures externals-pending tests-pending labels Apr 20, 2026

Black formatting

7e5c24e

cmsbuild added tests-started and removed tests-pending labels Apr 20, 2026

gartung linked an issue Apr 20, 2026 that may be closed by this pull request

Make columns in ModuleAllocMonitor diff table sortable cms-sw/framework-team#2103

Closed

Refactor module allocation viewer: adjust max-height for better layou…

43b4b4a

…t, update rows per page input, and enhance data validation logic

cmsbuild added tests-pending and removed tests-started labels Apr 20, 2026

cmsbuild added tests-started and removed tests-pending labels Apr 20, 2026

Add transition order sorting and update detail table structure for mo…

fbf2ca7

…dule allocation viewer

cmsbuild added tests-pending and removed tests-started labels Apr 20, 2026

cmsbuild added tests-pending and removed tests-approved labels Apr 22, 2026

cmsbuild added tests-started and removed tests-pending labels Apr 22, 2026

cmsbuild added tests-approved and removed tests-started labels Apr 22, 2026

makortel reviewed Apr 22, 2026

View reviewed changes

Comment thread comparisons/module_alloc_monitor_viewer.html Outdated

Remove custom font families and revert to system default fonts for im…

a1bdede

…proved performance and consistency Co-authored-by: Copilot <copilot@github.com>

cmsbuild added tests-pending and removed tests-approved labels Apr 22, 2026

cmsbuild added tests-started and removed tests-pending labels Apr 22, 2026

cmsbuild added tests-approved and removed tests-started labels Apr 22, 2026

smuzaffar merged commit 09c48b4 into cms-sw:master Apr 22, 2026
12 checks passed

cmsbuild added fully-signed externals-approved and removed pending-signatures externals-pending labels Apr 22, 2026

gartung deleted the gartung-sort-table-redo branch April 23, 2026 01:32

Conversation

gartung commented Apr 20, 2026

Uh oh!

cmsbuild commented Apr 20, 2026

Uh oh!

cmsbuild commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Apr 20, 2026

Uh oh!

cmsbuild commented Apr 20, 2026

Uh oh!

cmsbuild commented Apr 22, 2026

Uh oh!

cmsbuild commented Apr 22, 2026

Comparison Summary

Uh oh!

makortel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cmsbuild commented Apr 22, 2026

Uh oh!

gartung commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gartung commented Apr 22, 2026

Uh oh!

cmsbuild commented Apr 22, 2026

Comparison Summary

Uh oh!

makortel commented Apr 22, 2026

Uh oh!

gartung commented Apr 22, 2026

Uh oh!

smuzaffar commented Apr 22, 2026

Uh oh!

Uh oh!

cmsbuild commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmsbuild commented Apr 20, 2026 •

edited

Loading

gartung commented Apr 22, 2026 •

edited

Loading