expose additional libraries needed for celeritas geant4 interface compilation by kpedro88 · Pull Request #10069 · cms-sw/cmsdist

kpedro88 · 2025-09-11T20:12:31Z

This resolves linking errors observed when compiling a private CMSSW branch that integrates Celeritas.

…pilation

cmsbuild · 2025-09-11T20:12:58Z

A new Pull Request was created by @kpedro88 for branch IB/CMSSW_16_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2025-09-11T20:12:59Z

cms-bot internal usage

kpedro88 · 2025-09-11T20:13:27Z

@smuzaffar @iarspider will this change automatically propagate to the branch IB/CMSSW_16_0_X/g4adept, or should I make a separate PR to that branch?

kpedro88 · 2025-09-11T20:13:33Z

please test

cmsbuild · 2025-09-12T00:30:20Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-476cab/48072/summary.html
COMMIT: 9756fc1
CMSSW: CMSSW_16_0_X_2025-09-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10069/48072/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-476cab/48072/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-476cab/48072/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
24834.911 step 2
29634.0 step 2
29634.75 step 2
29634.911 step 2
29696.0 step 2
29700.0 step 2
29834.999 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially added 193 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3274061
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3274041
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
Checked 197 log files, 165 edm output root files, 43 DQM output files
TriggerResults: no differences found

iarspider · 2025-09-12T07:38:11Z

@smuzaffar @iarspider will this change automatically propagate to the branch IB/CMSSW_16_0_X/g4adept, or should I make a separate PR to that branch?

Yes, it will automatically propagate.

smuzaffar · 2025-09-12T07:40:13Z

@kpedro88 , yes these changes will be forward ported to adept branch.
Can you please update/increment the revision number of the changed scram tool files ? e.g. revision="3" -> revision="4"

cmsbuild · 2025-09-12T10:20:57Z

Pull request #10069 was updated.

smuzaffar · 2025-09-12T10:21:03Z

please test

@kpedro88 , I have updated the revisions of changed tools

kpedro88 · 2025-09-12T12:19:43Z

please test

cmsbuild · 2025-09-12T22:03:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-476cab/48085/summary.html
COMMIT: 9d73fe4
CMSSW: CMSSW_16_0_X_2025-09-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10069/48085/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-sw openmpi: Set needed env to avoid openmpi calling setenv at runtime #10058

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-476cab/48085/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-476cab/48085/git-merge-result

Comparison Summary

Summary:

You potentially added 10 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4113751
DQMHistoTests: Total failures: 22
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4113709
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

mandrenguyen · 2025-09-13T14:43:18Z

+1

smuzaffar · 2025-09-14T18:55:56Z

+externals

cmsbuild · 2025-09-14T18:56:22Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/master IBs (tests are also fine). This pull request will be automatically merged.

sethrj · 2025-10-15T14:49:08Z

  <lib name="G4tracking"/>
  <lib name="G4track"/>
  <lib name="G4analysis"/>
+  <lib name="G4ptl"/>


This is a little odd, why would CMSSW need PTL now and not before? Celeritas doesn't link against it or the catch-all ${Geant4_LIBRARIES} (aside from our tests/examples which shouldn't affect CMSSW). @sanmayphy

@sethrj somehow this was needed after adding geocel. My observations were described in a slack thread; I'll tag you

For future reference:

sed -i '/<lib name="celeritas"\/>/a \ \ <lib name="geocel"\/>' $CMSSW_BASE/config/toolbox/el8_amd64_gcc12/tools/selected/celeritas.xml scram setup celeritas scram b clean scram b

resulted in an error:

>> Building shared library tmp/el8_amd64_gcc12/src/SimG4Core/Application/src/SimG4CoreApplication/libSimG4CoreApplication.so lto-wrapper: warning: Extra option to '-Xassembler': --compress-debug-sections, dropping all '-Xassembler' and '-Wa' options. /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: tmp/el8_amd64_gcc12/src/SimG4Core/Application/src/SimG4CoreApplication/ccYmfNUF.ltrans19.ltrans.o: in function `PTL::TaskManager::~TaskManager()': <artificial>:(.text+0x356): undefined reference to `PTL::ThreadPool::destroy_threadpool()' /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: tmp/el8_amd64_gcc12/src/SimG4Core/Application/src/SimG4CoreApplication/ccYmfNUF.ltrans19.ltrans.o: in function `PTL::TaskManager::~TaskManager()': <artificial>:(.text+0x3bb): undefined reference to `PTL::ThreadPool::destroy_threadpool()' /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/../lib/gcc/x86_64-redhat-linux-gnu/12.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: tmp/el8_amd64_gcc12/src/SimG4Core/Application/src/SimG4CoreApplication/ccYmfNUF.ltrans34.ltrans.o: in function `celeritas::VecgeomParams::build_volumes_geant4(G4VPhysicalVolume const*)': <artificial>:(.text+0x79c6): undefined reference to `g4vg::convert(G4VPhysicalVolume const*, g4vg::Options const&)' collect2: error: ld returned 1 exit status gmake: *** [config/SCRAM/GMake/Makefile.rules:1920: tmp/el8_amd64_gcc12/src/SimG4Core/Application/src/SimG4CoreApplication/libSimG4CoreApplication.so] Error 1 gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

expose additional libraries needed for celeritas geant4 interface com…

9756fc1

…pilation

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Sep 11, 2025

cmsbuild added tests-started and removed tests-pending labels Sep 11, 2025

cmsbuild added tests-approved and removed tests-started labels Sep 12, 2025

update scram tools celeritas/g4core revision

9d73fe4

cmsbuild added tests-pending and removed tests-approved labels Sep 12, 2025

cmsbuild added tests-started and removed tests-pending labels Sep 12, 2025

cmsbuild added tests-approved and removed tests-started labels Sep 12, 2025

cmsbuild added orp-approved and removed orp-pending labels Sep 13, 2025

smuzaffar merged commit efbc3af into cms-sw:IB/CMSSW_16_0_X/master Sep 14, 2025
8 checks passed

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Sep 14, 2025

This was referenced Sep 15, 2025

Fail the run-pr-external_checks if it can not find cmssw-tool-conf cms-sw/cms-bot#2567

Merged

[ROOT636] Root update v6 36 00 patches 20250915 #10078

Merged

sethrj reviewed Oct 15, 2025

View reviewed changes

Conversation

kpedro88 commented Sep 11, 2025

Uh oh!

cmsbuild commented Sep 11, 2025

Uh oh!

cmsbuild commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kpedro88 commented Sep 11, 2025

Uh oh!

kpedro88 commented Sep 11, 2025

Uh oh!

cmsbuild commented Sep 12, 2025

Comparison Summary

Uh oh!

iarspider commented Sep 12, 2025

Uh oh!

smuzaffar commented Sep 12, 2025

Uh oh!

cmsbuild commented Sep 12, 2025

Uh oh!

smuzaffar commented Sep 12, 2025

Uh oh!

kpedro88 commented Sep 12, 2025

Uh oh!

cmsbuild commented Sep 12, 2025

Comparison Summary

Uh oh!

mandrenguyen commented Sep 13, 2025

Uh oh!

smuzaffar commented Sep 14, 2025

Uh oh!

Uh oh!

cmsbuild commented Sep 14, 2025

Uh oh!

sethrj Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

kpedro88 Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

sethrj Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cmsbuild commented Sep 11, 2025 •

edited

Loading