[ROOT6] Root update master 20250915#10077
Merged
smuzaffar merged 2 commits intocms-sw:IB/CMSSW_16_0_X/rootmasterfrom Sep 17, 2025
Merged
[ROOT6] Root update master 20250915#10077smuzaffar merged 2 commits intocms-sw:IB/CMSSW_16_0_X/rootmasterfrom
smuzaffar merged 2 commits intocms-sw:IB/CMSSW_16_0_X/rootmasterfrom
Conversation
Contributor
|
A new Pull Request was created by @akritkbehera for branch IB/CMSSW_16_0_X/rootmaster. @akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
Contributor
|
cms-bot internal usage |
Contributor
Author
|
Please test |
Contributor
|
-1 Failed Tests: RelVals AddOn RelValsExpand to see more relval errors ...AddOn Tests |
Contributor
|
please test |
Contributor
|
-1 Failed Tests: RelVals AddOn RelValsExpand to see more relval errors ...AddOn Tests |
Contributor
|
please test with #10079 lets try a debug build of root |
Contributor
|
testing a possible fix for this failure via cms-sw/root#226 . If successful then we can move to latest root master with which includes root-project/root#19893 |
Contributor
|
please test with #10079 |
Contributor
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff4129/48143/summary.html Comparison SummarySummary:
|
Contributor
|
please test with cms-externals/HLS_arbitrary_Precision_Types#1 for CMSSW_16_0_ROOT6_X |
Would it be okay to change this data member in mutable internal_transient_map_type transientMap_;to a This will probably also speed up the compilation time of CMSSW, because the |
Contributor
Theoretically maybe. But
template <typename Key, typename T, typename Hash = std::hash<Key>, typename KeyEqual = std::equal_to<Key>,
typename Allocator = tbb::tbb_allocator<std::pair<const Key, T>> >
class concurrent_unordered_mapand they don't provide forward declarations, so forward declaration by us feels brittle (even if the class has an "open specification"). Written that, I wonder if some other way of avoiding TBB header in a header that gets passed to But before doing much I'd like to understand better why we'd have to go though those changes. I have the impression the context is about changing @Dr15Jones Any thoughts? |
It was more by accident. We have avoided including See also: |
Contributor
|
Pull request #10077 was updated. |
Contributor
|
please test with #10083 |
Contributor
|
@guitargeek Thanks for the pointes. I'm still puzzled why (or how) root-project/root#19872 leads to code that uses |
Contributor
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff4129/48184/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
Contributor
|
looks like removing the |
Contributor
|
I can merge this and trigger ROOT6 IB to see how it behaves with full relvals |
Contributor
|
+externals |
cmsbuild
added
externals-approved
fully-signed
and removed
externals-pending
pending-signatures
labels
Contributor
|
This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/rootmaster IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
Contributor
|
I have started an IB for ROOT6 with this change. If we do not see any issues then I guess we do not need root-project/root#19893 |
Contributor
|
ROOT6 IBs look good, all relvals passed (except the know failures). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.