Remove error/warning flag for missing braces by smuzaffar · Pull Request #10141 · cms-sw/cmsdist

smuzaffar · 2025-10-21T10:04:54Z

cmsbuild · 2025-10-21T10:05:17Z

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_16_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2025-10-21T10:05:19Z

cms-bot internal usage

smuzaffar · 2025-10-21T10:08:15Z

please test using full cmssw

cmsbuild · 2025-10-21T14:20:30Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/48751/summary.html
COMMIT: e7ddc0e
CMSSW: CMSSW_16_0_X_2025-10-20-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10141/48751/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/48751/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/48751/git-merge-result

Comparison Summary

Summary:

You potentially removed 158 lines from the logs
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3911203
DQMHistoTests: Total failures: 1371
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3909812
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -280.76 KiB( 50 files compared)
DQMHistoSizes: changed ( 29634.0,... ): -56.152 KiB HGCAL/HGCalValidator
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

smuzaffar · 2025-10-21T15:30:21Z

please test for CMSSW_16_0_ROOT636_X/el8_amd64_gcc14

smuzaffar · 2025-10-21T19:55:17Z

please test for CMSSW_16_0_ROOT6_X/el8_amd64_gcc13 using full cmssw

cmsbuild · 2025-10-22T00:57:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/48757/summary.html
COMMIT: e7ddc0e
CMSSW: CMSSW_16_0_ROOT636_X_2025-10-21-1100/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10141/48757/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 159 lines to the logs
Reco comparison results: 83330 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3939953
DQMHistoTests: Total failures: 495594
DQMHistoTests: Total nulls: 326
DQMHistoTests: Total successes: 3444013
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1.2409999999999997 KiB( 50 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.192 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): -0.685 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 17034.0 ): 4.320 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.176 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.127 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -4.381 KiB SiStrip/MechanicalView
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: found differences in 16 / 49 workflows

cmsbuild · 2025-10-22T02:05:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/48759/summary.html
COMMIT: e7ddc0e
CMSSW: CMSSW_16_0_ROOT6_X_2025-10-20-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10141/48759/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/48759/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/48759/git-merge-result

Comparison Summary

Summary:

You potentially added 112 lines to the logs
Reco comparison results: 54 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3911203
DQMHistoTests: Total failures: 4184
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3906999
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -280.76 KiB( 50 files compared)
DQMHistoSizes: changed ( 29634.0,... ): -56.152 KiB HGCAL/HGCalValidator
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

smuzaffar · 2025-10-22T09:06:26Z

please test for el8_aarch64_gcc13 using full cmssw

cmsbuild · 2025-10-22T13:04:46Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/48763/summary.html
COMMIT: e7ddc0e
CMSSW: CMSSW_16_0_X_2025-10-21-2300/el8_aarch64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10141/48763/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/48763/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/48763/git-merge-result

mandrenguyen · 2025-10-27T12:19:46Z

+1

smuzaffar · 2025-10-27T12:32:08Z

hold

See cms-sw/cmssw#49133 (comment)

cmsbuild · 2025-10-27T12:32:33Z

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

smuzaffar · 2025-11-05T22:53:17Z

please test using full cmssw

smuzaffar · 2025-11-05T22:54:25Z

please test for CMSSW_16_0_ROOT636_X/el8_amd64_gcc14 using full CMSSW

cmsbuild · 2025-11-05T23:05:22Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/49276/summary.html
COMMIT: e7ddc0e
CMSSW: CMSSW_16_0_ROOT636_X_2025-11-04-1100/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10141/49276/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed External Build

I found compilation error when building:

./opt/rocm-7.0.2/share/doc/rocshmem
./opt/rocm-7.0.2/share/doc/rocshmem/LICENSE.md
46528 blocks
+ cp /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/SOURCES/external/rocm/7.0.2-26322fe51db58a9b402f3fa158a6bc12/c++config.h opt/rocm-7.0.2/llvm/lib/clang/19/include/cuda_wrappers/bits
cp: cannot create regular file 'opt/rocm-7.0.2/llvm/lib/clang/19/include/cuda_wrappers/bits': No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.J8AIJI (%build)

RPM build warnings:
Macro expanded in comment on line 408: %{pkginstroot}

fwyzard · 2025-11-06T07:12:12Z

Should be fixed by #10178 .

cmsbuild · 2025-11-06T08:06:37Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/49275/summary.html
COMMIT: e7ddc0e
CMSSW: CMSSW_16_0_X_2025-11-05-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10141/49275/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/49275/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/49275/git-merge-result

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test CondToolsLHCInfoNewPopConTest had ERRORS

Comparison Summary

Summary:

You potentially removed 78043 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 2 differences found in the comparisons
Reco comparison had 2 failed jobs
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3939949
DQMHistoTests: Total failures: 20
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3939909
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

fwyzard · 2025-11-06T08:09:56Z

OK, this

Failure LHCInfoPerFillPopConAnalyzer in EndFill mode written wrong number of payloads (expected 7, got 1): status 1

cannot possibly be caused by disabling a warning in the compilation flags ...

smuzaffar · 2025-11-06T08:14:03Z

please test with #10178 for CMSSW_16_0_ROOT636_X/el8_amd64_gcc14 using full cmssw

cmsbuild · 2025-11-06T08:47:55Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/49284/summary.html
COMMIT: e7ddc0e
CMSSW: CMSSW_16_0_ROOT636_X_2025-11-04-1100/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10141/49284/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed External Build

I found compilation error when building:

make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc14/external/openmpi/5.0.8-d2a41fa6d4b7b584cac0aa686275d1da/openmpi-5.0.8/opal/mca/accelerator/rocm'
make[1]: *** [Makefile:1972: all-recursive] Error 1
make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc14/external/openmpi/5.0.8-d2a41fa6d4b7b584cac0aa686275d1da/openmpi-5.0.8/opal'
make: *** [Makefile:1541: all-recursive] Error 1
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.3vGQrb (%build)

RPM build warnings:
Macro expanded in comment on line 406: %{pkginstroot}

Macro expanded in comment on line 407: %{pkginstroot}

smuzaffar · 2025-11-06T22:06:06Z

please test for CMSSW_16_0_ROOT636_X/el8_amd64_gcc14 using full cmssw

smuzaffar · 2025-11-07T16:35:27Z

please test for el9_amd64_gcc13 using full cmssw

cmsbuild · 2025-11-07T22:41:32Z

-1

Failed Tests: AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/49328/summary.html
COMMIT: e7ddc0e
CMSSW: CMSSW_16_0_ROOT636_X_2025-11-06-1100/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10141/49328/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/49328/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/49328/git-merge-result

Failed AddOn Tests

hlt_mc_GRun

A fatal system signal has occurred: segmentation violation

hlt_mc_PIon

A fatal system signal has occurred: segmentation violation

hlt_mc_PRef

A fatal system signal has occurred: segmentation violation

Expand to see more addon errors ...

Comparison Summary

Summary:

You potentially added 179 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 83479 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3939953
DQMHistoTests: Total failures: 494207
DQMHistoTests: Total nulls: 318
DQMHistoTests: Total successes: 3445408
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1.2409999999999997 KiB( 50 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.192 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): -0.685 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 17034.0 ): 4.320 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): -0.176 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): -0.127 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -4.381 KiB SiStrip/MechanicalView
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: found differences in 16 / 49 workflows

cmsbuild · 2025-11-08T06:53:23Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/49343/summary.html
COMMIT: e7ddc0e
CMSSW: CMSSW_16_0_X_2025-11-06-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10141/49343/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/49343/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e8815/49343/git-merge-result

Comparison Summary

Summary:

You potentially added 16 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 68308 differences found in the comparisons
Reco comparison had 2 failed jobs
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3939953
DQMHistoTests: Total failures: 367692
DQMHistoTests: Total nulls: 330
DQMHistoTests: Total successes: 3571911
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -10.084 KiB( 50 files compared)
DQMHistoSizes: changed ( 10224.0 ): -0.544 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13034.0 ): -7.492 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 17034.0 ): 3.184 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 2024.0040001 ): 0.012 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 250202.181 ): 0.293 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.063 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): -5.600 KiB SiStrip/MechanicalView
Checked 218 log files, 188 edm output root files, 51 DQM output files

smuzaffar · 2025-11-08T15:08:37Z

+externals

looks good and as agreed (cms-sw/cmssw#49133 ), we proceed with removing this flags

Remove redundant warning flag (missing-braces) for missing braces

e7ddc0e

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Oct 21, 2025

cmsbuild added tests-started and removed tests-pending labels Oct 21, 2025

smuzaffar changed the title ~~Remove redundant warning flag (missing-braces) for missing braces~~ Remove redundant warning flag for missing braces Oct 21, 2025

cmsbuild added tests-approved and removed tests-started labels Oct 21, 2025

smuzaffar mentioned this pull request Oct 21, 2025

Remove -Werror=missing-braces cms-sw/cmssw#49133

Open

smuzaffar changed the title ~~Remove redundant warning flag for missing braces~~ Remove error/warning flag for missing braces Oct 22, 2025

cmsbuild added orp-approved and removed orp-pending labels Oct 27, 2025

cmsbuild added the hold label Oct 27, 2025

cmsbuild removed the tests-approved label Nov 5, 2025

cmsbuild added the tests-started label Nov 5, 2025

cmsbuild added tests-rejected and removed tests-started labels Nov 6, 2025

cmsbuild added the requires-external label Nov 6, 2025

cmsbuild removed the requires-external label Nov 6, 2025

smuzaffar merged commit 1285395 into IB/CMSSW_16_0_X/master Nov 8, 2025
31 of 33 checks passed

cmsbuild added externals-approved and removed externals-pending labels Nov 8, 2025

This was referenced Nov 9, 2025

[Geant4] Update to version 11.4.cand00 #10185

Merged

[ROOT636] Updated root to tip of branch v6-36-00-patches #10188

Merged

smuzaffar deleted the smuzaffar-patch-7 branch November 17, 2025 10:30

Conversation

smuzaffar commented Oct 21, 2025

Uh oh!

cmsbuild commented Oct 21, 2025

Uh oh!

cmsbuild commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented Oct 21, 2025

Uh oh!

cmsbuild commented Oct 21, 2025

Comparison Summary

Uh oh!

smuzaffar commented Oct 21, 2025

Uh oh!

smuzaffar commented Oct 21, 2025

Uh oh!

cmsbuild commented Oct 22, 2025

Comparison Summary

Uh oh!

cmsbuild commented Oct 22, 2025

Comparison Summary

Uh oh!

smuzaffar commented Oct 22, 2025

Uh oh!

cmsbuild commented Oct 22, 2025

Uh oh!

mandrenguyen commented Oct 27, 2025

Uh oh!

smuzaffar commented Oct 27, 2025

Uh oh!

cmsbuild commented Oct 27, 2025

Uh oh!

smuzaffar commented Nov 5, 2025

Uh oh!

smuzaffar commented Nov 5, 2025

Uh oh!

cmsbuild commented Nov 5, 2025

Failed External Build

Uh oh!

fwyzard commented Nov 6, 2025

Uh oh!

cmsbuild commented Nov 6, 2025

Failed Unit Tests

Comparison Summary

Uh oh!

fwyzard commented Nov 6, 2025

Uh oh!

smuzaffar commented Nov 6, 2025

Uh oh!

cmsbuild commented Nov 6, 2025

Failed External Build

Uh oh!

smuzaffar commented Nov 6, 2025

Uh oh!

smuzaffar commented Nov 7, 2025

Uh oh!

cmsbuild commented Nov 7, 2025

Failed AddOn Tests

Comparison Summary

Uh oh!

cmsbuild commented Nov 8, 2025

Comparison Summary

Uh oh!

smuzaffar commented Nov 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmsbuild commented Oct 21, 2025 •

edited

Loading