Skip to content

[PY312][Eigen] Disable eigen debug for CUDA compilers#10329

Merged
smuzaffar merged 2 commits intoIB/CMSSW_16_1_X/py312from
smuzaffar-patch-14
Feb 11, 2026
Merged

[PY312][Eigen] Disable eigen debug for CUDA compilers#10329
smuzaffar merged 2 commits intoIB/CMSSW_16_1_X/py312from
smuzaffar-patch-14

Conversation

@smuzaffar
Copy link
Copy Markdown
Contributor

@smuzaffar smuzaffar commented Feb 7, 2026

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 7, 2026

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_16_1_X/py312.

@akritkbehera, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 7, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 8, 2026

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb61c5/51176/summary.html
COMMIT: ae13f8c
CMSSW: CMSSW_16_1_PY312_X_2026-02-06-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10329/51176/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Build

I found compilation error when building:

  __attribute__((host)) __attribute__((device))
                 ^

Remark: The warnings can be suppressed with "-diag-suppress "

src/HeterogeneousCore/CUDAUtilities/test/eigenSoA_t.h(19): error: identifier "assert" is undefined
    assert(!isPowerOf2(0));
    ^

1 error detected in the compilation of "src/HeterogeneousCore/CUDAUtilities/test/eigenSoA_t.cu".
gmake: *** [tmp/el8_amd64_gcc13/src/HeterogeneousCore/CUDAUtilities/test/gpuEigenSoA_debug/eigenSoA_t.cu.o] Error 1


@smuzaffar
Copy link
Copy Markdown
Contributor Author

enable gpu

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test with cms-sw/cmssw#49997 for CMSSW_16_1_PY312_X

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 9, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb61c5/51192/summary.html
COMMIT: ae13f8c
CMSSW: CMSSW_16_1_PY312_X_2026-02-08-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10329/51192/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 219 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2053 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4031484
  • DQMHistoTests: Total failures: 5572
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4025892
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 222 log files, 193 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Copy Markdown
Contributor

fwyzard commented Feb 10, 2026

@smuzaffar could you check if cms-externals/eigen-git-mirror#11 also fixes the problem ?

It would keep Eigen debugging enabled in host code compiled by nvcc.

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #10329 was updated.

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test for CMSSW_16_1_PY312_X

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb61c5/51251/summary.html
COMMIT: 598e8ca
CMSSW: CMSSW_16_1_PY312_X_2026-02-10-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10329/51251/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Copy Markdown
Contributor Author

+externals

thanks @fwyzard , cms-externals/eigen-git-mirror#11 hqas fixed the issue.
lets get this in PY312 IBs

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_1_X/py312 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar merged commit 3f845d7 into IB/CMSSW_16_1_X/py312 Feb 11, 2026
12 checks passed
@smuzaffar smuzaffar deleted the smuzaffar-patch-14 branch February 17, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants