Add CXXFLAGS for unused result warning by akritkbehera · Pull Request #10492 · cms-sw/cmsdist

akritkbehera · 2026-04-17T13:27:59Z

No description provided.

cmsbuild · 2026-04-17T13:28:26Z

A new Pull Request was created by @akritkbehera for branch IB/CMSSW_17_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

akritkbehera · 2026-04-17T13:32:51Z

test_parametes:

full_cmssw = true

akritkbehera · 2026-04-17T13:33:09Z

please test

cmsbuild · 2026-04-17T13:41:47Z

cms-bot internal usage

cmsbuild · 2026-04-17T15:46:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97beb/52720/summary.html
COMMIT: b1680e4
CMSSW: CMSSW_17_0_X_2026-04-17-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10492/52720/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 15 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4186437
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4186417
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

akritkbehera · 2026-04-17T15:52:13Z

test parameters:

full_cmssw = true

akritkbehera · 2026-04-17T15:52:27Z

please test

cmsbuild · 2026-04-17T18:09:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97beb/52727/summary.html
COMMIT: b1680e4
CMSSW: CMSSW_17_0_X_2026-04-17-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10492/52727/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 15 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4186437
DQMHistoTests: Total failures: 83
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4186334
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

makortel · 2026-04-17T18:14:36Z

I'm (positively) surprised we didn't have any cases in the code that would have been flagged!

smuzaffar · 2026-04-18T09:21:39Z

Please test

There was a typo in the full test parameter comment so previous tests did not build full cmssw

cmsbuild · 2026-04-18T14:06:11Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97beb/52732/summary.html
COMMIT: b1680e4
CMSSW: CMSSW_17_0_X_2026-04-17-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10492/52732/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@makortel Account for possible io_vN namespace in dictionary package checks. cmssw#50732
@Parsifal-2045 Improve handling of missing/invalid inputs in TrackingAssocValueMapsProducer cmssw#50730
@saumyaphor4252 Fix for Phase2 HLT Egamma trigger inefficiency dip cmssw#50714
@sakura-ngt HLT Scouting DQM: add monitoring of scouting track properties and other optimizations cmssw#50715
@bfonta TICL-barrel validation @ HLT cmssw#50588
@hjbossi Enable RPD reconstruction for 2025 and 2026 heavy-ion data cmssw#50063
@cerminar Phase-2 L1T: Update correlator emulator chain cmssw#50174
@sakura-ngt DQM/Integration: Make HLT PB and NGT client tag configurable via command line options cmssw#50643

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97beb/52732/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97beb/52732/git-merge-result

Comparison Summary

Summary:

You potentially removed 160 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4186421
DQMHistoTests: Total failures: 792
DQMHistoTests: Total nulls: 76
DQMHistoTests: Total successes: 4185533
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1411.375 KiB( 52 files compared)
DQMHistoSizes: changed ( 18434.0,... ): 352.790 KiB HLT/ScoutingOffline
DQMHistoSizes: changed ( 34434.0,... ): 0.020 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 34434.0,... ): 0.020 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 34496.0 ): 0.027 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 34634.999 ): 0.031 KiB MessageLogger/Warnings
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: found differences in 6 / 51 workflows

smuzaffar · 2026-04-18T23:22:58Z

please build for el10_amd64_gcc15

smuzaffar · 2026-04-18T23:23:39Z

please build for CMSSW_17_0_CLANG_X

cmsbuild · 2026-04-19T01:30:45Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97beb/52739/summary.html
COMMIT: b1680e4
CMSSW: CMSSW_17_0_X_2026-04-16-2300/el10_amd64_gcc15
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10492/52739/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@hjbossi Enable RPD reconstruction for 2025 and 2026 heavy-ion data cmssw#50063
@cerminar Phase-2 L1T: Update correlator emulator chain cmssw#50174
@bfonta TICL-barrel validation @ HLT cmssw#50588
@sakura-ngt DQM/Integration: Make HLT PB and NGT client tag configurable via command line options cmssw#50643
@tcuisset Fix clang build errors due to #define accidentally removed cmssw#50701
@saumyaphor4252 Fix for Phase2 HLT Egamma trigger inefficiency dip cmssw#50714
@sakura-ngt HLT Scouting DQM: add monitoring of scouting track properties and other optimizations cmssw#50715
@arizzi Add NANOGENMinimal, i.e. NANOGEN as in "same GEN content of NANOAOD" cmssw#50720
@Parsifal-2045 Improve handling of missing/invalid inputs in TrackingAssocValueMapsProducer cmssw#50730
@makortel Account for possible io_vN namespace in dictionary package checks. cmssw#50732
@makortel Add missing dictionary to RecoEgamma/EgammaTools/src/classes_def.xml cmssw#50739

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97beb/52739/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97beb/52739/git-merge-result

cmsbuild · 2026-04-19T01:57:00Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97beb/52740/summary.html
COMMIT: b1680e4
CMSSW: CMSSW_17_0_CLANG_X_2026-04-17-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10492/52740/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@makortel Account for possible io_vN namespace in dictionary package checks. cmssw#50732
@Parsifal-2045 Improve handling of missing/invalid inputs in TrackingAssocValueMapsProducer cmssw#50730
@saumyaphor4252 Fix for Phase2 HLT Egamma trigger inefficiency dip cmssw#50714
@sakura-ngt HLT Scouting DQM: add monitoring of scouting track properties and other optimizations cmssw#50715
@bfonta TICL-barrel validation @ HLT cmssw#50588
@hjbossi Enable RPD reconstruction for 2025 and 2026 heavy-ion data cmssw#50063
@cerminar Phase-2 L1T: Update correlator emulator chain cmssw#50174
@sakura-ngt DQM/Integration: Make HLT PB and NGT client tag configurable via command line options cmssw#50643

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97beb/52740/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f97beb/52740/git-merge-result

smuzaffar · 2026-04-20T07:06:23Z

+externals

cmsbuild · 2026-04-20T07:06:48Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_17_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Add CXXFLAGS for unused result warning

b1680e4

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Apr 17, 2026

cmsbuild added tests-started and removed tests-pending labels Apr 17, 2026

cms-sw deleted a comment from cmsbuild Apr 17, 2026

cmsbuild added tests-approved and removed tests-started labels Apr 17, 2026

cmsbuild added tests-started and removed tests-approved labels Apr 17, 2026

cmsbuild added tests-approved and removed tests-started labels Apr 17, 2026

cmsbuild added tests-started and removed tests-approved labels Apr 18, 2026

cmsbuild added tests-approved and removed tests-started labels Apr 18, 2026

smuzaffar merged commit 95c8d56 into cms-sw:IB/CMSSW_17_0_X/master Apr 20, 2026
14 checks passed

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Apr 20, 2026

smuzaffar mentioned this pull request Apr 20, 2026

[RFC] Make violations of [[nodiscard]] an error when building CMSSW cms-sw/cmssw#50740

Closed

Conversation

akritkbehera commented Apr 17, 2026

Uh oh!

cmsbuild commented Apr 17, 2026

Uh oh!

akritkbehera commented Apr 17, 2026

Uh oh!

akritkbehera commented Apr 17, 2026

Uh oh!

cmsbuild commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Apr 17, 2026

Comparison Summary

Uh oh!

akritkbehera commented Apr 17, 2026 • edited by smuzaffar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akritkbehera commented Apr 17, 2026

Uh oh!

cmsbuild commented Apr 17, 2026

Comparison Summary

Uh oh!

makortel commented Apr 17, 2026

Uh oh!

smuzaffar commented Apr 18, 2026

Uh oh!

cmsbuild commented Apr 18, 2026

Comparison Summary

Uh oh!

smuzaffar commented Apr 18, 2026

Uh oh!

smuzaffar commented Apr 18, 2026

Uh oh!

cmsbuild commented Apr 19, 2026

Uh oh!

cmsbuild commented Apr 19, 2026

Uh oh!

smuzaffar commented Apr 20, 2026

Uh oh!

Uh oh!

cmsbuild commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmsbuild commented Apr 17, 2026 •

edited

Loading

akritkbehera commented Apr 17, 2026 •

edited by smuzaffar

Loading