Skip to content

Test linking ROCM in scram.xml files #10513

Merged
smuzaffar merged 19 commits intocms-sw:IB/CMSSW_17_0_X/rocmfrom
akritkbehera:link_rocm_using_xml
May 7, 2026
Merged

Test linking ROCM in scram.xml files #10513
smuzaffar merged 19 commits intocms-sw:IB/CMSSW_17_0_X/rocmfrom
akritkbehera:link_rocm_using_xml

Conversation

@akritkbehera
Copy link
Copy Markdown
Contributor

No description provided.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 28, 2026

cms-bot internal usage

@akritkbehera
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0615e/52917/summary.html
COMMIT: e14e17c
CMSSW: CMSSW_17_0_ROCM_X_2026-04-27-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10513/52917/install.sh to create a dev area with all the needed externals and cmssw changes.

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #10513 was updated.

1 similar comment
@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #10513 was updated.

@akritkbehera
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0615e/52927/summary.html
COMMIT: 8a0e196
CMSSW: CMSSW_17_0_ROCM_X_2026-04-28-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10513/52927/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0615e/52927/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0615e/52927/git-merge-result

Failed Build

I found compilation error when building:

>> Package Utilities/RelMon built
>> Subsystem Utilities built
Copying tmp/el8_amd64_gcc13/src/HeterogeneousCore/ROCmUtilities/bin/rocmComputeCapabilities/librocmComputeCapabilities_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc13/src/HeterogeneousCore/ROCmUtilities/bin/rocmComputeCapabilities/librocmComputeCapabilities_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc13/src/HeterogeneousCore/ROCmUtilities/bin/rocmComputeCapabilities/librocmComputeCapabilities_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1920: tmp/el8_amd64_gcc13/src/HeterogeneousCore/ROCmUtilities/bin/rocmComputeCapabilities/librocmComputeCapabilities_rocm.a] Error 1
Copying tmp/el8_amd64_gcc13/src/PhysicsTools/PyTorchAlpakaTest/plugins/PhysicsToolsPyTorchAlpakaTestPluginsPortableROCmAsync/libPhysicsToolsPyTorchAlpakaTestPluginsPortableROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc13/src/PhysicsTools/PyTorchAlpakaTest/plugins/PhysicsToolsPyTorchAlpakaTestPluginsPortableROCmAsync/libPhysicsToolsPyTorchAlpakaTestPluginsPortableROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc13/src/PhysicsTools/PyTorchAlpakaTest/plugins/PhysicsToolsPyTorchAlpakaTestPluginsPortableROCmAsync/libPhysicsToolsPyTorchAlpakaTestPluginsPortableROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1920: tmp/el8_amd64_gcc13/src/PhysicsTools/PyTorchAlpakaTest/plugins/PhysicsToolsPyTorchAlpakaTestPluginsPortableROCmAsync/libPhysicsToolsPyTorchAlpakaTestPluginsPortableROCmAsync_rocm.a] Error 1
Copying tmp/el8_amd64_gcc13/src/DataFormats/SoATemplate/test/testRocmSoALayoutAndView_t/libtestRocmSoALayoutAndView_t_rocm.a to productstore area:


@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

Pull request #10513 was updated.

1 similar comment
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

Pull request #10513 was updated.

@akritkbehera
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 4, 2026

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0615e/53046/summary.html
COMMIT: b569327
CMSSW: CMSSW_17_0_ROCM_X_2026-04-29-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10513/53046/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed External Build

I found compilation error when building:

cmake/Packages.cmake:222 (find_package)
CMakeLists.txt:321 (include)


-- Configuring incomplete, errors occurred!
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Z5rsyN (%build)

RPM build errors:
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.Z5rsyN (%build)

* The action "build-install-external+rocm-rocprofiler-systems+7.2.2-688c858b03507e007e6445a73745da35" was not completed successfully because The following dependencies could not complete:


Updated environment variables and added HIP_PATH to runtime.
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 6, 2026

Pull request #10513 was updated.

@akritkbehera
Copy link
Copy Markdown
Contributor Author

please test

@smuzaffar
Copy link
Copy Markdown
Contributor

@akritkbehera , looks like you need to add toolfile for rocprofiler-register. The libamdhip64.so and libhsa-runtime64.so libs re linked against rocprofiler-register and due to missing toolfile this lib is not linked under cmssw/externals

@smuzaffar
Copy link
Copy Markdown
Contributor

ah ok, I see you already have added this tool

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 6, 2026

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0615e/53099/summary.html
COMMIT: 972b7a1
CMSSW: CMSSW_17_0_ROCM_X_2026-04-29-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10513/53099/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0615e/53099/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0615e/53099/git-merge-result

Failed Build

I found compilation error when building:

>> Leaving Package PhysicsTools/NanoAODTools
>> Package PhysicsTools/NanoAODTools built
Copying tmp/el8_amd64_gcc13/src/PhysicsTools/PyTorchAlpaka/test/testSoAToTorchROCmAsync/libtestSoAToTorchROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc13/src/PhysicsTools/PyTorchAlpaka/test/testSoAToTorchROCmAsync/libtestSoAToTorchROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc13/src/PhysicsTools/PyTorchAlpaka/test/testSoAToTorchROCmAsync/libtestSoAToTorchROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1920: tmp/el8_amd64_gcc13/src/PhysicsTools/PyTorchAlpaka/test/testSoAToTorchROCmAsync/libtestSoAToTorchROCmAsync_rocm.a] Error 1
>> Entering Package PhysicsTools/PythonAnalysis
>> Leaving Package PhysicsTools/PythonAnalysis
>> Package PhysicsTools/PythonAnalysis built
------- copying files from src/PhysicsTools/PythonAnalysis/scripts -------
>> copied edmMakePhDThesis


@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 6, 2026

Pull request #10513 was updated.

@akritkbehera
Copy link
Copy Markdown
Contributor Author

please test

@akritkbehera
Copy link
Copy Markdown
Contributor Author

build is done!

@smuzaffar
Copy link
Copy Markdown
Contributor

build is done!

great

No idea why bot thumbs down your comment :-)

@smuzaffar
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 6, 2026

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0615e/53104/summary.html
COMMIT: 1363a8b
CMSSW: CMSSW_17_0_ROCM_X_2026-04-29-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10513/53104/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0615e/53104/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0615e/53104/git-merge-result

Comparison Summary

Summary:

  • You potentially added 136 lines to the logs
  • Reco comparison results: 66885 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4180973
  • DQMHistoTests: Total failures: 534133
  • DQMHistoTests: Total nulls: 278
  • DQMHistoTests: Total successes: 3646542
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -165.41200000000003 KiB( 52 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): -1.172 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 17034.0 ): 1.669 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 18434.0,... ): -0.020 KiB HLT/Filters
  • DQMHistoSizes: changed ( 18634.0 ): -3.428 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.293 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.308 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 34434.0,... ): -35.918 KiB TrackerPhase2OTStubV/Residual
  • DQMHistoSizes: changed ( 34434.0,... ): 3.336 KiB TrackerPhase2OTL1TrackV/Extended_L1TF
  • DQMHistoSizes: changed ( 34434.0,... ): 0.524 KiB TrackerPhase2OTL1TrackV/Nominal_L1TF
  • DQMHistoSizes: changed ( 34434.0 ): ...
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 19 / 51 workflows

@smuzaffar smuzaffar marked this pull request as ready for review May 7, 2026 07:33
@smuzaffar
Copy link
Copy Markdown
Contributor

+externals

lets get this in ROCM IB

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 7, 2026

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_17_0_X/rocm IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 7, 2026

A new Pull Request was created by @akritkbehera for branch IB/CMSSW_17_0_X/rocm.

can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants