Skip to content

Pythia 8.313#9612

Closed
mseidel42 wants to merge 2 commits intocms-sw:IB/CMSSW_15_1_X/masterfrom
mseidel42:pythia8313
Closed

Pythia 8.313#9612
mseidel42 wants to merge 2 commits intocms-sw:IB/CMSSW_15_1_X/masterfrom
mseidel42:pythia8313

Conversation

@mseidel42
Copy link
Copy Markdown
Contributor

@mseidel42 mseidel42 commented Jan 13, 2025

Update to Pythia 8.313, contains

Full changelog here: https://pythia.org/latest-manual/UpdateHistory.html#section0

Needs cms-sw/cmssw#47092

@mseidel42 mseidel42 mentioned this pull request Jan 13, 2025
Closed
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 13, 2025

A new Pull Request was created by @mseidel42 for branch IB/CMSSW_15_0_X/master.

@cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 13, 2025 •
edited
Loading

cms-bot internal usage

@smuzaffar
Copy link
Copy Markdown
Contributor

smuzaffar commented Jan 13, 2025

please test with cms-sw/cmssw#47092

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 14, 2025

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5f427/43744/summary.html
COMMIT: 4af6344
CMSSW: CMSSW_15_0_X_2025-01-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9612/43744/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5f427/43744/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5f427/43744/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

RelVals

----- Begin Fatal Exception 14-Jan-2025 02:37:25 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module Pythia8ConcurrentGeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 14-Jan-2025 02:30:20 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module Pythia8ConcurrentGeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 14-Jan-2025 02:30:34 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module Pythia8ConcurrentGeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

AddOn Tests

----- Begin Fatal Exception 14-Jan-2025 02:31:12 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module Pythia8ConcurrentGeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 14-Jan-2025 02:31:11 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module Pythia8ConcurrentGeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 14-Jan-2025 02:31:12 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing global begin LuminosityBlock run: 1 luminosityBlock: 1
   [1] Calling method for module Pythia8ConcurrentGeneratorFilter/'generator'
Exception Message:
Failed to initialize hadronizer Pythia8Hadronizer for internal parton generation
----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@mseidel42
Copy link
Copy Markdown
Contributor Author

mseidel42 commented Jan 14, 2025

Ok, I think there is a bug in the Pythia 8.313 PDF setup, trying to patch it

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 14, 2025

Pull request #9612 was updated.

@smuzaffar
Copy link
Copy Markdown
Contributor

smuzaffar commented Jan 16, 2025

test parameters:

@smuzaffar
Copy link
Copy Markdown
Contributor

smuzaffar commented Jan 16, 2025

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 16, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5f427/43787/summary.html
COMMIT: d3cb978
CMSSW: CMSSW_15_0_X_2025-01-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9612/43787/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5f427/43787/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5f427/43787/git-merge-result

Comparison Summary

Summary:

  • You potentially added 70 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 72764 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3817749
  • DQMHistoTests: Total failures: 467359
  • DQMHistoTests: Total nulls: 328
  • DQMHistoTests: Total successes: 3350042
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -677.2280000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.234 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 0.629 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 16834.0 ): -677.346 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 250202.181 ): -0.404 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.127 KiB SiStrip/MechanicalView
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 15 / 47 workflows

@smuzaffar
Copy link
Copy Markdown
Contributor

smuzaffar commented Jan 17, 2025

assign generators

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 17, 2025

New categories assigned: generators

@bbilin,@lviliani,@menglu21,@mkirsano you have been requested to review this Pull request/Issue and eventually sign? Thanks

@smuzaffar
Copy link
Copy Markdown
Contributor

smuzaffar commented Jan 17, 2025

@cms-sw/generators-l2 , can you please review this change?

@mseidel42
Copy link
Copy Markdown
Contributor Author

mseidel42 commented Jan 20, 2025

Hi Shahzad, GEN L2s want to discuss at an upcoming meeting whether we should keep the Pythia 8 version frozen for Run 3 or update it, so I think this is on hold for now.

Btw, Pythia bug report filed here: https://gitlab.com/Pythia8/releases/-/issues/543

@smuzaffar
Copy link
Copy Markdown
Contributor

smuzaffar commented Feb 1, 2025

hold

see #9612 (comment)

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 1, 2025

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Feb 1, 2025
@smuzaffar smuzaffar changed the base branch from IB/CMSSW_15_0_X/master to IB/CMSSW_15_1_X/master February 7, 2025 08:45
@mseidel42
Copy link
Copy Markdown
Contributor Author

mseidel42 commented Jun 5, 2025

Should move to 8.315 by now (skip 8.314 due to hadronization bug), see https://pythia.org/latest-manual/UpdateHistory.html

@smuzaffar
Copy link
Copy Markdown
Contributor

smuzaffar commented Jun 24, 2025

@mseidel42 , will you open a PR (or update this one) to move to 8.315 or I do it?

@mseidel42
Copy link
Copy Markdown
Contributor Author

mseidel42 commented Jun 24, 2025

Hi, I can update this one but we might wait for the tau decays to get fixed (8.316 hopefully)

@lviliani
Copy link
Copy Markdown

lviliani commented Jun 25, 2025

Hi, our current understanding is that the tau decay issue is not in Pythia actually, so I don't think we should expect any fix.

@mseidel42
Copy link
Copy Markdown
Contributor Author

mseidel42 commented Jun 25, 2025

Ok, will prepare the update then 👍

@mseidel42 mseidel42 mentioned this pull request Jun 26, 2025
Merged
@mseidel42
Copy link
Copy Markdown
Contributor Author

mseidel42 commented Jun 26, 2025

Replaced by #9943

@mseidel42 mseidel42 closed this Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

externals-pending generators-pending hold orp-pending pending-signatures requires-external tests-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mseidel42 @cmsbuild @smuzaffar @lviliani