[Do not merge]Build root/llvm with std=cpp17 by smuzaffar · Pull Request #9910 · cms-sw/cmsdist

smuzaffar · 2025-06-03T17:41:09Z

Testing ROOT 6.32 build patched to build internal llvm with c++17

smuzaffar · 2025-06-03T17:41:21Z

test parameters:

full_cmssw = true

smuzaffar · 2025-06-03T17:41:27Z

please test

cmsbuild · 2025-06-03T17:41:35Z

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_15_1_X/master.

@iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2025-06-03T17:41:37Z

cms-bot internal usage

smuzaffar · 2025-06-03T21:06:15Z

please test for el8_aarch64_gcc12

cmsbuild · 2025-06-04T01:58:35Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46527/summary.html
COMMIT: d4f8f27
CMSSW: CMSSW_15_1_X_2025-06-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9910/46527/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@bsunanda Phase2-hgx364G Make coherent definitions of Wafer Size and Nominal Wafer Size for several scenarios using HGCal cmssw#48222

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46527/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46527/git-merge-result

Comparison Summary

Summary:

You potentially removed 158 lines from the logs
Reco comparison results: 8914 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4041180
DQMHistoTests: Total failures: 71998
DQMHistoTests: Total nulls: 110
DQMHistoTests: Total successes: 3969052
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: found differences in 2 / 48 workflows

cmsbuild · 2025-06-04T02:46:11Z

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46530/summary.html
COMMIT: d4f8f27
CMSSW: CMSSW_15_1_X_2025-06-02-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9910/46530/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@bsunanda Phase2-hgx364G Make coherent definitions of Wafer Size and Nominal Wafer Size for several scenarios using HGCal cmssw#48222

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46530/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46530/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testPhase2PixelNtuple had ERRORS

RelVals

29634.75

----- Begin Fatal Exception 04-Jun-2025 04:17:17 CEST-----------------------
An exception of category 'RunTimeError.' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling method for module trackerDTC::ProducerDTC/'ProducerDTC'
   [3] TTBV::checkU
Exception Message:
Value 1 does not fit into a -3b binary.
----- End Fatal Exception -------------------------------------------------

29834.999

----- Begin Fatal Exception 04-Jun-2025 04:22:04 CEST-----------------------
An exception of category 'RunTimeError.' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling method for module trackerDTC::ProducerDTC/'ProducerDTC'
   [3] TTBV::checkU
Exception Message:
Value 1 does not fit into a -3b binary.
----- End Fatal Exception -------------------------------------------------

24834.911

----- Begin Fatal Exception 04-Jun-2025 04:27:28 CEST-----------------------
An exception of category 'RunTimeError.' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling method for module trackerDTC::ProducerDTC/'ProducerDTC'
   [3] TTBV::checkU
Exception Message:
Value 1 does not fit into a -3b binary.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

smuzaffar · 2025-06-04T03:37:27Z

Please test

cmsbuild · 2025-06-04T08:26:09Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-441c44/46532/summary.html
COMMIT: d4f8f27
CMSSW: CMSSW_15_1_X_2025-06-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9910/46532/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 157 lines from the logs
Reco comparison results: 14 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4041180
DQMHistoTests: Total failures: 70
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4041090
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

smuzaffar · 2025-06-04T08:41:56Z

@makortel , this PR applies part of #9910 (only interpreter/CMakeLists.txt change to force build llvm with c++17) to existing ROOT 6.32. DQM Comparison differences in #9910 (comment) are our usual differences. Should we try to integrate it in DEVEL IBs to see how this change behaves when relvals are run in threaded mode?

makortel · 2025-06-04T17:34:29Z

Should we try to integrate it in DEVEL IBs to see how this change behaves when relvals are run in threaded mode?

Sure, testing in DEVEL sounds good. (sigh, but it is what it is)

smuzaffar · 2025-06-05T12:16:21Z

@makortel , looks like latest GCC 13.3 changes allow us to build ROOT 6.32 without force building llvm with c++17. PR tests #9914 (which is using the tip of gcc 13 branch) ran successfully.

makortel · 2025-06-05T13:45:59Z

looks like latest GCC 13.3 changes allow us to build ROOT 6.32 without force building llvm with c++17. PR tests #9914 (which is using the tip of gcc 13 branch) ran successfully.

Nice

Build root/llvm with std=cpp17

d4f8f27

cmsbuild added externals-pending pending-signatures tests-started orp-pending labels Jun 3, 2025

cmsbuild added tests-approved and removed tests-started labels Jun 4, 2025

cmsbuild added tests-started and removed tests-approved labels Jun 4, 2025

cmsbuild added tests-approved and removed tests-started labels Jun 4, 2025

smuzaffar closed this Jun 5, 2025

smuzaffar deleted the root632-llvm-cpp17 branch June 5, 2025 14:11

Conversation

smuzaffar commented Jun 3, 2025

Uh oh!

smuzaffar commented Jun 3, 2025

Uh oh!

smuzaffar commented Jun 3, 2025

Uh oh!

cmsbuild commented Jun 3, 2025

Uh oh!

cmsbuild commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented Jun 3, 2025

Uh oh!

cmsbuild commented Jun 4, 2025

Comparison Summary

Uh oh!

cmsbuild commented Jun 4, 2025

Unit Tests

RelVals

Uh oh!

smuzaffar commented Jun 4, 2025

Uh oh!

cmsbuild commented Jun 4, 2025

Comparison Summary

Uh oh!

smuzaffar commented Jun 4, 2025

Uh oh!

makortel commented Jun 4, 2025

Uh oh!

smuzaffar commented Jun 5, 2025

Uh oh!

makortel commented Jun 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmsbuild commented Jun 3, 2025 •

edited

Loading