Allow Runtime Number of Hits for Alpaka Pixel Reconstruction by AdrianoDee · Pull Request #44773 · cms-sw/cmssw

AdrianoDee · 2024-04-18T14:56:18Z

This PR proposes a solution for #44769. The culprit there is

cmssw/RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/SiPixelRawToClusterKernel.dev.cc

Lines 509 to 513 in 6e82cc8

    
           constexpr auto MAX_HITS = TrackerTraits::maxNumberOfHits; 
        
           for (uint32_t i : cms::alpakatools::independent_group_elements(acc, numberOfModules + 1)) { 
        
             if (clus_view[i].clusModuleStart() > MAX_HITS) 
        
               clus_view[i].clusModuleStart() = MAX_HITS; 
        
           }

where we cut the number of hits to "only":

cmssw/Geometry/CommonTopologies/interface/SimplePixelTopology.h

Line 420 in 6e82cc8

static constexpr uint32_t maxNumberOfHits = 48 * 1024;

And the event of the crash has:

SiPixelClusterizerAlpaka results:
 > no. of digis: 301020
 > no. of active modules: 1794
 > no. of clusters: 50684
 > bpix2 offset: 19595

The poor man solution would be to rise the max to something safer such asstatic constexpr uint32_t maxNumberOfHits = 96 * 1024;. But seems to me a waste also because this procedure is anyway a remnant of that intermediate phase of the Alpaka port when we had no runtime sized histograms (before #43064).

So this PR involves a slightly bigger code refactoring in order to drop the fixed number of hits and use the runtime sized histograms where needed (namely for the hit to tuple map).

PR validation:

The setup in #44769 with this PR (on top of master or 14_0_X) doesn't crash anymore.

Backported to 14_0_X in #44774.

solves #44769.

cmsbuild · 2024-04-18T14:56:41Z

cms-bot internal usage

mmusich · 2024-04-18T14:58:06Z

tagging @malbouis (ORM)

malbouis · 2024-04-18T14:58:06Z

urgent

malbouis · 2024-04-18T14:58:13Z

type hlt-int

AdrianoDee · 2024-04-18T14:58:18Z

enable gpu

rappoccio · 2024-04-18T15:00:32Z

I think as soon as the checks finish we can merge in the interest of time.

AdrianoDee · 2024-04-18T15:02:26Z

test parameters:

enable = gpu
workflows = 12434.402,12434.403,12434.404
workflows_gpu = 12434.402,12434.403,12434.404
workflow_opts = -w upgrade
workflow_opts_gpu = -w upgrade

cmsbuild · 2024-04-18T15:03:33Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44773/40004

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelRecHits/plugins/alpaka/PixelRecHitKernels.dev.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernels.h modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44773/40004/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44773/40004/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

- update for HitToTuple map in CA

cmsbuild · 2024-04-18T15:14:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44773/40005

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelRecHits/plugins/alpaka/PixelRecHitKernels.dev.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
- File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernels.h modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

cmsbuild · 2024-04-18T15:14:36Z

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

Geometry/CommonTopologies (geometry)
RecoLocalTracker/SiPixelClusterizer (reconstruction)
RecoLocalTracker/SiPixelRecHits (reconstruction)
RecoTracker/PixelSeeding (reconstruction)

@civanch, @Dr15Jones, @jfernan2, @makortel, @mdhildreth, @mandrenguyen, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@threus, @mtosi, @dkotlins, @VourMa, @gpetruc, @ferencek, @felicepantaleo, @mmusich, @rovere, @dgulhan, @missirol, @JanFSchulte, @tsusa, @mroguljic, @tvami, @fabiocos, @VinInn, @GiacomoSguazzoni, @bsunanda this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2024-04-18T15:16:04Z

please test

AdrianoDee · 2024-04-18T17:28:11Z

assign heterogeneous

cmsbuild · 2024-04-18T17:28:32Z

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2024-04-18T19:04:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bfffbf/38935/summary.html
COMMIT: 29d1688
CMSSW: CMSSW_14_1_X_2024-04-18-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44773/38935/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 99 lines from the logs
Reco comparison results: 49 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3351672
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3351643
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 213 log files, 177 edm output root files, 50 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 24 differences found in the comparisons
DQMHistoTests: Total files compared: 5
DQMHistoTests: Total histograms compared: 71813
DQMHistoTests: Total failures: 1281
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 70532
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 4 files compared)
Checked 19 log files, 22 edm output root files, 5 DQM output files
TriggerResults: no differences found

antoniovilela · 2024-04-18T19:17:15Z

+1
- Requested by ORM as urgent for data taking.

antoniovilela · 2024-04-18T19:18:00Z

merge
- Requested by ORM as urgent for data taking.

mandrenguyen · 2024-04-19T13:49:00Z

+1

fwyzard · 2024-04-21T00:29:44Z

+heterogeneous

cmsbuild added this to the CMSSW_14_1_X milestone Apr 18, 2024

cmsbuild added reconstruction-pending geometry-pending pending-signatures tests-pending orp-pending code-checks-pending tracking trk labels Apr 18, 2024

AdrianoDee mentioned this pull request Apr 18, 2024

[14_0_X] Allow Runtime Number of Hits for Alpaka Pixel Reconstruction #44774

Merged

cmsbuild added urgent hlt-integration labels Apr 18, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Apr 18, 2024

Allowing runtime number of hits

29d1688

- update for HitToTuple map in CA

AdrianoDee force-pushed the runtime_nhits_141X branch from d1d19b5 to 29d1688 Compare April 18, 2024 15:06

cmsbuild added code-checks-pending and removed code-checks-rejected labels Apr 18, 2024

mmusich mentioned this pull request Apr 18, 2024

HLT farm crash in run 379617 #44769

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 18, 2024

cmsbuild added tests-started and removed tests-pending labels Apr 18, 2024

cmsbuild added the heterogeneous-pending label Apr 18, 2024

cmsbuild added tests-approved and removed tests-started labels Apr 18, 2024

cmsbuild added orp-approved and removed orp-pending labels Apr 18, 2024

cmsbuild merged commit 8642310 into cms-sw:master Apr 18, 2024

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 19, 2024

cmsbuild added heterogeneous-approved and removed heterogeneous-pending labels Apr 21, 2024

AdrianoDee deleted the runtime_nhits_141X branch April 30, 2024 10:35

	constexpr auto MAX_HITS = TrackerTraits::maxNumberOfHits;
	for (uint32_t i : cms::alpakatools::independent_group_elements(acc, numberOfModules + 1)) {
	if (clus_view[i].clusModuleStart() > MAX_HITS)
	clus_view[i].clusModuleStart() = MAX_HITS;
	}

Conversation

AdrianoDee commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR validation:

Uh oh!

cmsbuild commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmusich commented Apr 18, 2024

Uh oh!

malbouis commented Apr 18, 2024

Uh oh!

malbouis commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AdrianoDee commented Apr 18, 2024

Uh oh!

rappoccio commented Apr 18, 2024

Uh oh!

AdrianoDee commented Apr 18, 2024

Uh oh!

cmsbuild commented Apr 18, 2024

Uh oh!

cmsbuild commented Apr 18, 2024

Uh oh!

cmsbuild commented Apr 18, 2024

Uh oh!

AdrianoDee commented Apr 18, 2024

Uh oh!

AdrianoDee commented Apr 18, 2024

Uh oh!

cmsbuild commented Apr 18, 2024

Uh oh!

cmsbuild commented Apr 18, 2024

Comparison Summary

GPU Comparison Summary

Uh oh!

antoniovilela commented Apr 18, 2024

Uh oh!

antoniovilela commented Apr 18, 2024

Uh oh!

mandrenguyen commented Apr 19, 2024

Uh oh!

fwyzard commented Apr 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

AdrianoDee commented Apr 18, 2024 •

edited

Loading

cmsbuild commented Apr 18, 2024 •

edited

Loading

malbouis commented Apr 18, 2024 •

edited

Loading