Migrate assert to to ALPAKA_ASSERT_ACC

[fwyzard]

PR description:

Migrate assert() to ALPAKA_ASSERT_ACC().

PR validation:

None.

To be backported to 14.0.x for data taking.

[cmsbuild]

cms-bot internal usage

[fwyzard]

Fixes #44792.

[fwyzard]

please test

[fwyzard]

urgent

Backport needed for data taking.

[fwyzard]

enable gpu

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44802/40045

• This PR adds an extra 68KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/VertexSoA/test/alpaka/ZVertexSoA_test.dev.cc modified in PR(s): Z vertex multi layout #43952
  • File RecoLocalTracker/SiPixelRecHits/plugins/alpaka/PixelRecHitKernels.dev.cc modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
  • File RecoLocalTracker/SiPixelRecHits/plugins/alpaka/PixelRecHits.h modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964, Irradiation Bias Correction (IBC) of pixel clusters at Alpaka #44569
  • File RecoTracker/PixelSeeding/plugins/alpaka/CACell.h modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964
  • File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtupletGeneratorKernels.h modified in PR(s): Alpaka vs CUDA DQM compare modules for pixel tracks objects #43964

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• CondFormats/SiPixelObjects (db, alca)
• DataFormats/SiPixelClusterSoA (reconstruction, heterogeneous)
• DataFormats/SiPixelDigiSoA (reconstruction, heterogeneous)
• DataFormats/VertexSoA (reconstruction, heterogeneous)
• HeterogeneousCore/AlpakaInterface (heterogeneous)
• RecoLocalCalo/EcalRecProducers (reconstruction)
• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoTracker/PixelSeeding (reconstruction)

@fwyzard, @jfernan2, @francescobrivio, @consuegs, @mandrenguyen, @makortel, @saumyaphor4252, @perrotta can you please review it and eventually sign? Thanks.
@seemasharmafnal, @JanFSchulte, @ReyerBand, @argiro, @missirol, @mmusich, @mtosi, @VinInn, @makortel, @gpetruc, @felicepantaleo, @PonIlya, @yuanchao, @rsreds, @tvami, @wang0jin, @tocheng, @rovere, @dgulhan, @rchatter, @mroguljic, @ferencek, @dkotlins, @thomreis, @youyingli, @GiacomoSguazzoni, @apsallid, @JanChyczynski, @tsusa, @VourMa, @threus this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

+heterogeneous

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09cbfe/39005/summary.html
COMMIT: 821de17
CMSSW: CMSSW_14_1_X_2024-04-22-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44802/39005/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 8 lines to the logs
• Reco comparison results: 39 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319852
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3319829
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 32 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39740
• DQMHistoTests: Total failures: 1562
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 38178
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1