[UBSAN]Properly initialize datamembers for move operator

[smuzaffar]

This reverts the changes integrated by #46907 and properly initialize the data members for move constructor for HepMCProduct

[cmsbuild]

cms-bot internal usage

[smuzaffar]

test parameters:

• relvals = 570.0,571.0,577.0

[smuzaffar]

please test for CMSSW_15_0_UBSAN_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47074/43245

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• SimDataFormats/GeneratorProducts (generators)

@bbilin, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @denizsun, @fabiocos, @martinamalberti, @missirol, @mmusich, @rovere, @salimcerci, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4af489/43707/summary.html
COMMIT: d16cf31
CMSSW: CMSSW_15_0_X_2025-01-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47074/43707/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-trackeralign Introduce a Generic validation tool for dataset validation in the alignment all-in-one tool #47055
• @AdrianoDee Removing CUDA/gpu from Pixel code configs and dropping all CUDA wfs #46853
• @Dr15Jones Improve L1TRawToDigi #46928
• @perrotta Update SiPixelAliHGRcd_prod.json #47059
• @smuzaffar [GENERATORS] Apply code checks/format #46992
• @slava77 speedup SiStripClusterizer(FromRaw) using ThreeThresholdAlgorithm #47061
• @smuzaffar [UBSAN]Fix runtime error for invalid bool value assignment #46907
• @mmusich re-organize RecoMuon/L3TrackFinder such that all plugins are defined in plugins folder #47064
• @Parsifal-2045 Remove all SealModules from the RecoMuon package #47065

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4af489/43707/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4af489/43707/git-merge-result

Comparison Summary

Summary:

• You potentially removed 130 lines from the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 3821397
• DQMHistoTests: Total failures: 64
• DQMHistoTests: Total nulls: 11
• DQMHistoTests: Total successes: 3821302
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.8560000000000004 KiB( 51 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): -0.012 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 1000.0,... ): -0.012 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 24834.911,... ): -0.008 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 24834.911,... ): -0.008 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 4.22,... ): -0.004 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 4.22,... ): -0.004 KiB MessageLogger/Warnings
• Checked 220 log files, 187 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4af489/43706/summary.html
COMMIT: d16cf31
CMSSW: CMSSW_15_0_UBSAN_X_2025-01-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47074/43706/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-trackeralign Introduce a Generic validation tool for dataset validation in the alignment all-in-one tool #47055
• @AdrianoDee Removing CUDA/gpu from Pixel code configs and dropping all CUDA wfs #46853
• @Dr15Jones Removed TFWLiteSelector system #47053
• @Dr15Jones Improve L1TRawToDigi #46928
• @perrotta Update SiPixelAliHGRcd_prod.json #47059
• @makortel Remove redundant data members from InputFileCatalog to reduce memory use #47013
• @smuzaffar [GENERATORS] Apply code checks/format #46992
• @mmusich re-organize RecoMuon/L3TrackFinder such that all plugins are defined in plugins folder #47064
• @patinkaew Add support for adding variable-size attributes (std::vector) within objects for NanoAOD #46702
• @slava77 speedup SiStripClusterizer(FromRaw) using ThreeThresholdAlgorithm #47061
• @smuzaffar [UBSAN]Fix runtime error for invalid bool value assignment #46907
• @felicepantaleo Make HGCAL Validation reproducible #46962
• @Parsifal-2045 Remove all SealModules from the RecoMuon package #47065

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4af489/43706/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4af489/43706/git-merge-result

[smuzaffar]

@cms-sw/generators-l2 , can you please review this PR. It reverts the changes made by #46907 and now properly initialize the data members via move constructor ( see @makortel comment #46907 (review) )

[lviliani]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1