Skip to content

Reduce minYsizeB1 and minYsizeB2 CA cuts for Phase1 #47271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Feb 8, 2025
Merged

Reduce minYsizeB1 and minYsizeB2 CA cuts for Phase1 #47271

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
142684c
Null minYsizeB1 and minYsizeB2 for Phase1
Feb 5, 2025
34fd1de
Make cuts on minYsizeB1 and minYsizeB2 configurable
mmasciov Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Geometry/CommonTopologies/interface/SimplePixelTopology.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,8 +464,8 @@ namespace pixelTopology {

static constexpr float dzdrFact = 8 * 0.0285 / 0.015; // from dz/dr to "DY"

static constexpr int minYsizeB1 = 36;
static constexpr int minYsizeB2 = 28;
static constexpr int minYsizeB1 = 1;
static constexpr int minYsizeB2 = 1;
Copy link
Copy Markdown
Contributor

@mmusich mmusich Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could these parameters be exposed as configurable parameters instead of hardcoded?
I guess this would ease the checks to be asked to various stakeholders.

Copy link
Copy Markdown
Contributor

@mmasciov mmasciov Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be done in ef9d50d

Copy link
Copy Markdown
Contributor

@mmusich mmusich Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!


static constexpr int nPairsForQuadruplets = 13; // quadruplets require hits in all layers
static constexpr int nPairsForTriplets = nPairsForQuadruplets + 2; // include barrel "jumping" layer pairs
Expand Down