Skip to content

[RNTUPLE_X] Add missing include#47615

Merged
cmsbuild merged 1 commit intocms-sw:CMSSW_15_1_RNTUPLE_Xfrom
iarspider:iarspider-patches-2025018-1
Mar 19, 2025
Merged

[RNTUPLE_X] Add missing include#47615
cmsbuild merged 1 commit intocms-sw:CMSSW_15_1_RNTUPLE_Xfrom
iarspider:iarspider-patches-2025018-1

Conversation

@iarspider
Copy link
Copy Markdown
Contributor

PR description:

Fixes compilation failures in IBs: link

PR validation:

Code compiles

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @iarspider for CMSSW_15_1_RNTUPLE_X.

It involves the following packages:

  • FWIO/RNTuple (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 18, 2025

cms-bot internal usage

@iarspider
Copy link
Copy Markdown
Contributor Author

please test for CMSSW_15_1_RNTUPLE_X

@makortel
Copy link
Copy Markdown
Contributor

Probably a knock-on effect of #47561. Thanks @iarspider!

@iarspider
Copy link
Copy Markdown
Contributor Author

Unit test test-das-selected-lumis sometimes fail in IBs, not caused by this PR.

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9c048/45031/summary.html
COMMIT: 053c5c8
CMSSW: CMSSW_15_1_RNTUPLE_X_2025-03-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47615/45031/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9c048/45031/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9c048/45031/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

@makortel
Copy link
Copy Markdown
Contributor

+core

@makortel
Copy link
Copy Markdown
Contributor

ignore tests-rejected with external-failure

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_RNTUPLE_X IBs (test failures were overridden) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 7b5f282 into cms-sw:CMSSW_15_1_RNTUPLE_X Mar 19, 2025
3 checks passed
@iarspider iarspider deleted the iarspider-patches-2025018-1 branch March 24, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants