Skip to content

Remove cms::cuda::ScopedContextTask as unused#48191

Merged
cmsbuild merged 2 commits intocms-sw:masterfrom
makortel:removeScopedContextTask
May 29, 2025
Merged

Remove cms::cuda::ScopedContextTask as unused#48191
cmsbuild merged 2 commits intocms-sw:masterfrom
makortel:removeScopedContextTask

Conversation

@makortel
Copy link
Copy Markdown
Contributor

@makortel makortel commented May 28, 2025

PR description:

Resolves #48186
Resolves cms-sw/framework-team#1409

PR validation:

makortel added 2 commits May 28, 2025 15:29
@makortel
Remove ScopedContextTask as unused
8916135 
The TestCUDATest unit test was failing because of missing
ServiceToken. Given that we are phasing out the CUDA system, removing
the ScopedContextTask (that is not used outside tests) was simpler
than delivering the Services to the TBB task scheduled via
ScopedContextTask.
@makortel
Mark HeterogeneousTest/CUDATest to be run on GPU_X IB
ae04529
@makortel makortel mentioned this pull request May 28, 2025
Closed
@cmsbuild cmsbuild added this to the CMSSW_15_1_X milestone May 28, 2025
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 28, 2025 •
edited
Loading

cms-bot internal usage

@makortel makortel changed the title Remove ScopedContextTask as unused Remove cms::cuda::ScopedContextTask as unused May 28, 2025
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 28, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48191/44967

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 28, 2025

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • HeterogeneousCore/CUDACore (heterogeneous)
  • HeterogeneousCore/CUDATest (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Copy Markdown
Contributor Author

makortel commented May 28, 2025

enable gpu

@makortel
Copy link
Copy Markdown
Contributor Author

makortel commented May 28, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 28, 2025

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-973f5f/46410/summary.html
COMMIT: ae04529
CMSSW: CMSSW_15_1_X_2025-05-28-1100/el8_amd64_gcc12
Additional Tests: CUDA,ROCM
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48191/46410/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4041063
  • DQMHistoTests: Total failures: 22
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4041021
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

CUDA Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 1 DQM output files

ROCM Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 1 DQM output files

@fwyzard
Copy link
Copy Markdown
Contributor

fwyzard commented May 28, 2025

+heterogeneous

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 28, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@makortel
Copy link
Copy Markdown
Contributor Author

makortel commented May 28, 2025

Comparison differences are related to #47071

@mandrenguyen
Copy link
Copy Markdown
Contributor

mandrenguyen commented May 29, 2025

+1

@cmsbuild cmsbuild merged commit c7269b5 into cms-sw:master May 29, 2025
17 checks passed
@makortel makortel deleted the removeScopedContextTask branch May 29, 2025 18:22
@iarspider iarspider mentioned this pull request May 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

code-checks-approved fully-signed heterogeneous-approved orp-approved tests-approved

Projects

None yet

Milestone

CMSSW_15_1_X

Development

Successfully merging this pull request may close these issues.

Remove cms::cuda::ScopedContextTask Failure of HeterogeneousCore/CUDATest/TestCUDATest

4 participants

@makortel @cmsbuild @fwyzard @mandrenguyen