Skip to content

Adding 2025 Data Wfs#48281

Merged
cmsbuild merged 2 commits intocms-sw:masterfrom
AdrianoDee:data_2025_wfs
Jun 19, 2025
Merged

Adding 2025 Data Wfs#48281
cmsbuild merged 2 commits intocms-sw:masterfrom
AdrianoDee:data_2025_wfs

Conversation

@AdrianoDee
Copy link
Copy Markdown
Contributor

@AdrianoDee AdrianoDee commented Jun 10, 2025

This PR proposes to add a few new wfs for 2025 data. At the moment only Run2025B and Run2025C are really functional, being the only eras for which some certification is available in https://cms-service-dqmdc.web.cern.ch/CAF/certification/. Still the workflows are defined up to an hypothetical era 2025I so that they are ready to be used for the RelVals.

Also, for the moment, I'd keep the 2024 wfs running the 2025 HLT key since we use them in release validation and I'd prefer to accumulate some eras before turning them back to the fake menu. The same applies to online/offline conditions: I'd keep around the 2024 data (F,G,H,I) wfs using the online ones.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 10, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48281/45123

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

# the files used as input

###2025
pds_2025 = ['BTagMu', 'DisplacedJet', 'EGamma0', 'HcalNZS', 'JetMET0', 'Muon0', 'MuonEG', 'NoBPTX', 'ParkingDoubleMuonLowMass0', 'ParkingHH', 'ParkingLLP', 'ParkingSingleMuon0', 'ParkingVBF0', 'Tau', 'ZeroBias','JetMET1']
Copy link
Copy Markdown
Contributor

@mmusich mmusich Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add the ScoutingPFMonitor PD here and do in a more rational way #47327 (thus solving #47315)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, do I remember correctly and for 2024 this would not be possible since some inputs are missing? To understand if I have to touch 2024 too.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and for 2024 this would not be possible since some inputs are missing? To understand if I have to touch 2024 too.

that's correct, for 2024 we had to workaround to get an input file done by hand for 145.415.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's included now, for testing it here we'll have to wait the RAW are copied to disk to CERN.

@@ -2306,6 +2321,8 @@ def lhegensim2018ml(fragment,howMuch):

steps['HLTDR3_2024']=merge( [ {'-s':'L1REPACK:Full,HLT:@%s'%hltKey2025,},{'--conditions':'auto:run3_hlt_relval'},{'--era' : 'Run3_2024'},steps['HLTD'] ] )
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we have 2025 data maybe we send back this to use hltKey2024 (though the new 2025 relvals should get into the short matrix).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep it with 2025 for the moment until we accumulate some more eras in 2025 since the bulk of the data validations would still be done with 2024 data. I'd turn it back to 2024 by 15_1_0_pre5 at the latest.

@AdrianoDee
Copy link
Copy Markdown
Contributor Author

test parameters:

  • relval_opts = -w data_highstats
  • workflow = 2025.004005

@AdrianoDee
Copy link
Copy Markdown
Contributor Author

please test

@AdrianoDee
Copy link
Copy Markdown
Contributor Author

please abort

@AdrianoDee
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48281/45126

@AdrianoDee
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48281/45243

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #48281 was updated. @AdrianoDee, @Moanwar, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 72KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e64ec/46815/summary.html
COMMIT: 3c3854f
CMSSW: CMSSW_15_1_X_2025-06-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48281/46815/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4050825
  • DQMHistoTests: Total failures: 33
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4050772
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Copy Markdown
Contributor Author

+pdmv

  • resign (last commit was a trivial fix)

@Moanwar
Copy link
Copy Markdown
Contributor

Moanwar commented Jun 18, 2025

+Upgrade

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 9d214fa into cms-sw:master Jun 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants