Fix crashes in HGCAL HLT/RECO with v19 geometry by waredjeb · Pull Request #48303 · cms-sw/cmssw

waredjeb · 2025-06-12T12:22:18Z

PR description:

This PR should go on top of #48287 fixing the HLT and RECO part for V19 geometry.
Also in this case the PR is not ready but it would benefit from the CI/CD tests to spot additional errors in moving to the new geometry.

####: For testing this PR:

Include Fix crashes in HGCAL DIGI+ with v19 geometry #48287
Include Phase2-hgx364P0 Update the list of Eras in Configuration/StandardSequences #48301
Test on V19 workflow : 34034.0

FYI: @felicepantaleo @pfs @jbsauvan @EmyrClement @indra-ehep @bsunanda

cmsbuild · 2025-06-12T12:22:42Z

cms-bot internal usage

cmsbuild · 2025-06-12T12:23:53Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48303/45166

There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/HLT_75e33/psets/HGCAL_chargeCollectionEfficiencies_cfi.py modified in PR(s): Fix crashes in HGCAL DIGI+ with v19 geometry #48287
- File HLTrigger/Configuration/python/HLT_75e33/psets/HGCAL_noise_fC_cfi.py modified in PR(s): Fix crashes in HGCAL DIGI+ with v19 geometry #48287
- File L1Trigger/L1THGCal/python/l1tHGCalVFEProducer_cfi.py modified in PR(s): Fix crashes in HGCAL DIGI+ with v19 geometry #48287
- File L1Trigger/L1THGCal/src/veryfrontend/HGCalVFESummationImpl.cc modified in PR(s): Fix crashes in HGCAL DIGI+ with v19 geometry #48287
- File SimCalorimetry/HGCalSimProducers/interface/HGCDigitizerBase.h modified in PR(s): Fix crashes in HGCAL DIGI+ with v19 geometry #48287
- File SimCalorimetry/HGCalSimProducers/interface/HGCFEElectronics.h modified in PR(s): Rpc digi dev v9 #47447
- File SimCalorimetry/HGCalSimProducers/plugins/HGCDigitizer.cc modified in PR(s): Rpc digi dev v9 #47447
- File SimCalorimetry/HGCalSimProducers/python/hgcalDigitizer_cfi.py modified in PR(s): Fix crashes in HGCAL DIGI+ with v19 geometry #48287
- File SimCalorimetry/HGCalSimProducers/src/HGCFEElectronics.cc modified in PR(s): Rpc digi dev v9 #47447

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48303/45166/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48303/45166/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

felicepantaleo · 2025-06-12T12:27:21Z

allow @waredjeb test rights

mmusich · 2025-06-12T12:51:44Z

    tdcOnset_fC_ = ps.getParameter<double>("tdcOnset_fC");
  if (ps.exists("tdcForToAOnset_fC")) {
    auto temp = ps.getParameter<std::vector<double> >("tdcForToAOnset_fC");
+    std::cout << "temp " << temp.size() << " tdcForToaOnset " << tdcForToAOnset_fC_.size() << std::endl;


no cout in production code.

mmusich · 2025-06-12T12:52:22Z

+    HGCHEFConfig = _modifiedHGCHEFConfig_v19,
+    HGCHFNoseConfig = _modifiedHGCHFNoseConfig_v19
+)
+


remove additional line.

mmusich · 2025-06-12T12:52:30Z

+    HGCHEFConfig = _modifiedHGCHEFConfig_v19,
+    HGCHFNoseConfig = _modifiedHGCHFNoseConfig_v19
+)
+


remove additional line.

mmusich · 2025-06-12T12:53:02Z

+                         maxNumberOfThickIndices = cms.uint32(8),
+                         thresholdW0 = cms.vdouble(2.9, 2.9, 2.9, 2.9),
+                         )
+


remove additional line.

mmusich · 2025-06-12T12:53:19Z

+# While here there are two different sets for CE-E and CE-H
+# Additionally there are four values for each set, in order to follow the four detid silicon types [HD120um, LD200um, LD300um, HD200um]
+# The thickness correction value for HD200um is copied from LD200um
+>>>>>>> 3135ca68949 (initial fixes with procModifier v19)


cmsbuild · 2025-06-12T13:02:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48303/45167

There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/HLT_75e33/psets/HGCAL_chargeCollectionEfficiencies_cfi.py modified in PR(s): Fix crashes in HGCAL DIGI+ with v19 geometry #48287
- File HLTrigger/Configuration/python/HLT_75e33/psets/HGCAL_noise_fC_cfi.py modified in PR(s): Fix crashes in HGCAL DIGI+ with v19 geometry #48287
- File L1Trigger/L1THGCal/python/l1tHGCalVFEProducer_cfi.py modified in PR(s): Fix crashes in HGCAL DIGI+ with v19 geometry #48287
- File L1Trigger/L1THGCal/src/veryfrontend/HGCalVFESummationImpl.cc modified in PR(s): Fix crashes in HGCAL DIGI+ with v19 geometry #48287
- File SimCalorimetry/HGCalSimProducers/interface/HGCDigitizerBase.h modified in PR(s): Fix crashes in HGCAL DIGI+ with v19 geometry #48287
- File SimCalorimetry/HGCalSimProducers/interface/HGCFEElectronics.h modified in PR(s): Rpc digi dev v9 #47447
- File SimCalorimetry/HGCalSimProducers/plugins/HGCDigitizer.cc modified in PR(s): Rpc digi dev v9 #47447
- File SimCalorimetry/HGCalSimProducers/python/hgcalDigitizer_cfi.py modified in PR(s): Fix crashes in HGCAL DIGI+ with v19 geometry #48287

cmsbuild · 2025-06-12T13:02:31Z

A new Pull Request was created by @waredjeb for master.

It involves the following packages:

HLTrigger/Configuration (hlt)
L1Trigger/L1THGCal (l1, upgrade)
RecoLocalCalo/HGCalRecProducers (upgrade, reconstruction)
SimCalorimetry/HGCalSimProducers (simulation, upgrade)

@BenjaminRS, @Martin-Grunewald, @Moanwar, @civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @mmusich, @quinnanm, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @amarini, @apsallid, @bsunanda, @cseez, @denizsun, @edjtscott, @felicepantaleo, @hatakeyamak, @jbsauvan, @lecriste, @lgray, @missirol, @mmusich, @pfs, @rovere, @salimcerci, @sameasy, @sethzenz, @vandreev11, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2025-06-12T13:49:00Z

test parameters:

pull_request = Fix crashes in HGCAL DIGI+ with v19 geometry #48287, Phase2-hgx364P0 Update the list of Eras in Configuration/StandardSequences #48301
relvals_opt = --what upgrade
workflows = 34034.0

mmusich · 2025-06-12T13:57:41Z

@cmsbuild, please test

cmsbuild · 2025-06-12T14:00:02Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c826bf/46689/summary.html
COMMIT: f450b19
CMSSW: CMSSW_15_1_X_2025-06-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48303/46689/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c826bf/46689/git-merge-result

cmsbuild · 2025-07-31T11:15:46Z

Pull request #48303 was updated. @BenjaminRS, @Martin-Grunewald, @Moanwar, @civanch, @cmsbuild, @cseez, @felicepantaleo, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @mmusich, @pfs, @quinnanm, @rovere, @srimanob, @subirsarkar can you please check and sign again.

waredjeb · 2025-07-31T11:16:10Z

@cmsbuild please test

waredjeb · 2025-07-31T22:23:32Z

Bot stucked?

cmsbuild · 2025-07-31T22:23:50Z

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c826bf/47472/summary.html
COMMIT: 963a4d0
CMSSW: CMSSW_15_1_X_2025-07-31-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48303/47472/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

There are some workflows for which there are errors in the baseline:
34034.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially removed 26 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 61
DQMHistoTests: Total histograms compared: 4381146
DQMHistoTests: Total failures: 24
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4381102
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 60 files compared)
Checked 256 log files, 217 edm output root files, 61 DQM output files
TriggerResults: no differences found

mmusich

congratulations on the fix!
Please drop cms-specific python types whenever possible in clone() and toModify() calls to ensure type correctedness checks at runtime.

mmusich · 2025-08-01T08:03:58Z

+phase2_hgcalV19.toModify(hltHGCalRecHitL1Seeded, 
+                         HGCEE_fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[0:4]),
+                         HGCHEF_fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[4:8]),
+                         HGCHFNose_fCPerMIP = cms.vdouble(1.25, 2.57, 3.88, 2.57),


Suggested change

phase2_hgcalV19.toModify(hltHGCalRecHitL1Seeded,

HGCEE_fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[0:4]),

HGCHEF_fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[4:8]),

HGCHFNose_fCPerMIP = cms.vdouble(1.25, 2.57, 3.88, 2.57),

phase2_hgcalV19.toModify(hltHGCalRecHitL1Seeded,

HGCEE_fCPerMIP = HGCAL_reco_constants.fcPerMip[0:4],

HGCHEF_fCPerMIP = HGCAL_reco_constants.fcPerMip[4:8],

HGCHFNose_fCPerMIP = [1.25, 2.57, 3.88, 2.57],

mmusich · 2025-08-01T08:04:29Z

+phase2_hgcalV19.toModify(hltHGCalRecHit, 
+                         HGCEE_fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[0:4]),
+                         HGCHEF_fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[4:8]),
+                         HGCHFNose_fCPerMIP = cms.vdouble(1.25, 2.57, 3.88, 2.57),


Suggested change

phase2_hgcalV19.toModify(hltHGCalRecHit,

HGCEE_fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[0:4]),

HGCHEF_fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[4:8]),

HGCHFNose_fCPerMIP = cms.vdouble(1.25, 2.57, 3.88, 2.57),

phase2_hgcalV19.toModify(hltHGCalRecHit,

HGCEE_fCPerMIP = HGCAL_reco_constants.fcPerMip[0:4],

HGCHEF_fCPerMIP = HGCAL_reco_constants.fcPerMip[4:8],

HGCHFNose_fCPerMIP = [1.25, 2.57, 3.88, 2.57],

mmusich · 2025-08-01T08:05:04Z

+_modifiedHGCEEConfig_v19 = hltHGCalUncalibRecHitL1Seeded.HGCEEConfig.clone(
+    fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[0:4])
+)
+_modifiedHGCHEFConfig_v19 = hltHGCalUncalibRecHitL1Seeded.HGCHEFConfig.clone(
+    fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[4:8])
+)
+_modifiedHGCHFNoseConfig_v19 = hltHGCalUncalibRecHitL1Seeded.HGCHFNoseConfig.clone(
+    fCPerMIP = cms.vdouble(1.25, 2.57, 3.88, 2.57)
+)


Suggested change

_modifiedHGCEEConfig_v19 = hltHGCalUncalibRecHitL1Seeded.HGCEEConfig.clone(

fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[0:4])

)

_modifiedHGCHEFConfig_v19 = hltHGCalUncalibRecHitL1Seeded.HGCHEFConfig.clone(

fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[4:8])

)

_modifiedHGCHFNoseConfig_v19 = hltHGCalUncalibRecHitL1Seeded.HGCHFNoseConfig.clone(

fCPerMIP = cms.vdouble(1.25, 2.57, 3.88, 2.57)

)

_modifiedHGCEEConfig_v19 = hltHGCalUncalibRecHitL1Seeded.HGCEEConfig.clone(

fCPerMIP = HGCAL_reco_constants.fcPerMip[0:4]

)

_modifiedHGCHEFConfig_v19 = hltHGCalUncalibRecHitL1Seeded.HGCHEFConfig.clone(

fCPerMIP = HGCAL_reco_constants.fcPerMip[4:8]

)

_modifiedHGCHFNoseConfig_v19 = hltHGCalUncalibRecHitL1Seeded.HGCHFNoseConfig.clone(

fCPerMIP = [1.25, 2.57, 3.88, 2.57]

)

mmusich · 2025-08-01T08:05:40Z

+_modifiedHGCEEConfig_v19 = hltHGCalUncalibRecHit.HGCEEConfig.clone(
+    fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[0:4])
+)
+_modifiedHGCHEFConfig_v19 = hltHGCalUncalibRecHit.HGCHEFConfig.clone(
+    fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[4:8])
+)
+_modifiedHGCHFNoseConfig_v19 = hltHGCalUncalibRecHit.HGCHFNoseConfig.clone(
+    fCPerMIP = cms.vdouble(1.25, 2.57, 3.88, 2.57)
+)


Suggested change

_modifiedHGCEEConfig_v19 = hltHGCalUncalibRecHit.HGCEEConfig.clone(

fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[0:4])

)

_modifiedHGCHEFConfig_v19 = hltHGCalUncalibRecHit.HGCHEFConfig.clone(

fCPerMIP = cms.vdouble(HGCAL_reco_constants.fcPerMip[4:8])

)

_modifiedHGCHFNoseConfig_v19 = hltHGCalUncalibRecHit.HGCHFNoseConfig.clone(

fCPerMIP = cms.vdouble(1.25, 2.57, 3.88, 2.57)

)

_modifiedHGCEEConfig_v19 = hltHGCalUncalibRecHit.HGCEEConfig.clone(

fCPerMIP = HGCAL_reco_constants.fcPerMip[0:4]

)

_modifiedHGCHEFConfig_v19 = hltHGCalUncalibRecHit.HGCHEFConfig.clone(

fCPerMIP = HGCAL_reco_constants.fcPerMip[4:8]

)

_modifiedHGCHFNoseConfig_v19 = hltHGCalUncalibRecHit.HGCHFNoseConfig.clone(

fCPerMIP = [1.25, 2.57, 3.88, 2.57]

)

mmusich · 2025-08-01T08:06:16Z

-)
+)
+
+phase2_hgcalV19.toModify(HGCAL_chargeCollectionEfficiencies, values =  cms.vdouble(1.0, 1.0,1.0,1.0))


Suggested change

phase2_hgcalV19.toModify(HGCAL_chargeCollectionEfficiencies, values = cms.vdouble(1.0, 1.0,1.0,1.0))

phase2_hgcalV19.toModify(HGCAL_chargeCollectionEfficiencies, values = [1.0, 1.0,1.0,1.0])

mmusich · 2025-08-01T08:06:37Z

-)
+)
+
+phase2_hgcalV19.toModify(HGCAL_noise_fC , values = cms.vdouble(0.32041011999999996, 0.384492144, 0.32041011999999996, 0.384492144))


Suggested change

phase2_hgcalV19.toModify(HGCAL_noise_fC , values = cms.vdouble(0.32041011999999996, 0.384492144, 0.32041011999999996, 0.384492144))

phase2_hgcalV19.toModify(HGCAL_noise_fC , values = [0.32041011999999996, 0.384492144, 0.32041011999999996, 0.384492144])

mmusich · 2025-08-01T08:07:36Z

+phase2_hgcalV19.toModify(HGCAL_reco_constants, 
+                         thicknessCorrection = cms.vdouble(0.75, 0.76, 0.75, 0.76, 0.85, 0.85, 0.84, 0.85) , #CEE_12_HD, CEE_200_LD, CEE_300_LD, CEE_200_HD,CEH_12_HD, CEH_200_LD, CEH_300_LD, CEH_200_HD,
+                         fcPerMip = cms.vdouble(
+                                 2.06, 3.43, 5.15, 3.43, 2.06, 3.43,
+                                 5.15, 3.43
+                             ),
+                         noises = cms.vdouble(
+                                 2000.0, 2400.0, 2000.0, 2400.0, 2000.0, 2400.0,
+                                 2000.0, 2400.
+                             ),
+                         numberOfThicknesses = cms.uint32(4),
+                         maxNumberOfThickIndices = cms.uint32(8),
+                         thresholdW0 = cms.vdouble(2.9, 2.9, 2.9, 2.9),
+                         )


Suggested change

phase2_hgcalV19.toModify(HGCAL_reco_constants,

thicknessCorrection = cms.vdouble(0.75, 0.76, 0.75, 0.76, 0.85, 0.85, 0.84, 0.85) , #CEE_12_HD, CEE_200_LD, CEE_300_LD, CEE_200_HD,CEH_12_HD, CEH_200_LD, CEH_300_LD, CEH_200_HD,

fcPerMip = cms.vdouble(

2.06, 3.43, 5.15, 3.43, 2.06, 3.43,

5.15, 3.43

),

noises = cms.vdouble(

2000.0, 2400.0, 2000.0, 2400.0, 2000.0, 2400.0,

2000.0, 2400.

),

numberOfThicknesses = cms.uint32(4),

maxNumberOfThickIndices = cms.uint32(8),

thresholdW0 = cms.vdouble(2.9, 2.9, 2.9, 2.9),

)

phase2_hgcalV19.toModify(HGCAL_reco_constants,

thicknessCorrection = [0.75, 0.76, 0.75, 0.76, 0.85, 0.85, 0.84, 0.85] , #CEE_12_HD, CEE_200_LD, CEE_300_LD, CEE_200_HD,CEH_12_HD, CEH_200_LD, CEH_300_LD, CEH_200_HD,

fcPerMip = [

2.06, 3.43, 5.15, 3.43, 2.06, 3.43,

5.15, 3.43

],

noises = [

2000.0, 2400.0, 2000.0, 2400.0, 2000.0, 2400.0,

2000.0, 2400.

],

numberOfThicknesses = 4,

maxNumberOfThickIndices = 8,

thresholdW0 = [2.9, 2.9, 2.9, 2.9],

)

mmusich · 2025-08-01T08:07:57Z

-)
+)
+
+phase2_hgcalV19.toModify(hgceeDigitizer.digiCfg.feCfg, tdcForToAOnset_fC= cms.vdouble(12.,12.,12.,12.))


Suggested change

phase2_hgcalV19.toModify(hgceeDigitizer.digiCfg.feCfg, tdcForToAOnset_fC= cms.vdouble(12.,12.,12.,12.))

phase2_hgcalV19.toModify(hgceeDigitizer.digiCfg.feCfg, tdcForToAOnset_fC= [12.,12.,12.,12.])

mmusich · 2025-08-01T08:08:12Z

-)
+)
+
+phase2_hgcalV19.toModify(hgchebackDigitizer.digiCfg.feCfg, tdcForToAOnset_fC = cms.vdouble(12.,12.,12.,12.)) 


Suggested change

phase2_hgcalV19.toModify(hgchebackDigitizer.digiCfg.feCfg, tdcForToAOnset_fC = cms.vdouble(12.,12.,12.,12.))

phase2_hgcalV19.toModify(hgchebackDigitizer.digiCfg.feCfg, tdcForToAOnset_fC = [12.,12.,12.,12.])

mmusich · 2025-08-01T08:08:29Z

-)
+)
+
+phase2_hgcalV19.toModify(hgchefrontDigitizer.digiCfg.feCfg, tdcForToAOnset_fC = cms.vdouble(12.,12.,12.,12.))


Suggested change

phase2_hgcalV19.toModify(hgchefrontDigitizer.digiCfg.feCfg, tdcForToAOnset_fC = cms.vdouble(12.,12.,12.,12.))

phase2_hgcalV19.toModify(hgchefrontDigitizer.digiCfg.feCfg, tdcForToAOnset_fC = [12.,12.,12.,12.])

felicepantaleo · 2025-08-01T08:38:31Z

type hgcal

felicepantaleo · 2025-08-01T08:38:42Z

type bug-fix

cmsbuild · 2025-08-01T09:15:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48303/45665

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalCalo/HGCalRecAlgos/src/RecHitTools.cc modified in PR(s): Bugfixes to TICL-barrel #48565

cmsbuild · 2025-08-01T09:16:24Z

Pull request #48303 was updated. @BenjaminRS, @Martin-Grunewald, @Moanwar, @civanch, @cmsbuild, @cseez, @felicepantaleo, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @mmusich, @pfs, @quinnanm, @rovere, @srimanob, @subirsarkar can you please check and sign again.

mmusich · 2025-08-01T09:18:34Z

please test

mmusich · 2025-08-01T09:19:10Z

+
+
+phase2_hgcalV19.toModify(HGCAL_reco_constants, 
+                         thicknessCorrection = 0.75, 0.76, 0.75, 0.76, 0.85, 0.85, 0.84, 0.85 , #CEE_12_HD, CEE_200_LD, CEE_300_LD, CEE_200_HD,CEH_12_HD, CEH_200_LD, CEH_300_LD, CEH_200_HD,


Suggested change

thicknessCorrection = 0.75, 0.76, 0.75, 0.76, 0.85, 0.85, 0.84, 0.85 , #CEE_12_HD, CEE_200_LD, CEE_300_LD, CEE_200_HD,CEH_12_HD, CEH_200_LD, CEH_300_LD, CEH_200_HD,

thicknessCorrection = [0.75, 0.76, 0.75, 0.76, 0.85, 0.85, 0.84, 0.85] , #CEE_12_HD, CEE_200_LD, CEE_300_LD, CEE_200_HD,CEH_12_HD, CEH_200_LD, CEH_300_LD, CEH_200_HD,

mmusich · 2025-08-01T09:19:52Z

+phase2_hgcalV19.toModify(hltHGCalRecHitL1Seeded, 
+                         HGCEE_fCPerMIP = HGCAL_reco_constants.fcPerMip[0:4],
+                         HGCHEF_fCPerMIP = HGCAL_reco_constants.fcPerMip[4:8],
+                         HGCHFNose_fCPerMIP = 1.25, 2.57, 3.88, 2.57,


mmmh, here and elsewhere now the square bracket is missing!

mmusich · 2025-08-01T09:20:14Z

@cmsbuild please abort

cmsbuild · 2025-08-01T09:33:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48303/45666

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalCalo/HGCalRecAlgos/src/RecHitTools.cc modified in PR(s): Bugfixes to TICL-barrel #48565

cmsbuild · 2025-08-01T09:33:39Z

Pull request #48303 was updated. @BenjaminRS, @Martin-Grunewald, @Moanwar, @civanch, @cmsbuild, @cseez, @felicepantaleo, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @mmusich, @pfs, @quinnanm, @rovere, @srimanob, @subirsarkar can you please check and sign again.

mmusich · 2025-08-01T09:58:10Z

@cmsbuild, please test

cmsbuild · 2025-08-01T12:23:37Z

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c826bf/47490/summary.html
COMMIT: 26c420c
CMSSW: CMSSW_15_1_X_2025-07-31-2300/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48303/47490/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

There are some workflows for which there are errors in the baseline:
34034.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially removed 24 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 61
DQMHistoTests: Total histograms compared: 4381146
DQMHistoTests: Total failures: 102
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4381024
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 60 files compared)
Checked 256 log files, 217 edm output root files, 61 DQM output files
TriggerResults: no differences found

mmusich · 2025-08-01T12:31:54Z

+hlt

for waredjeb@26c420c
battery of phase-2 HLT tests passes
no visible regression in the comparisons

jfernan2 · 2025-08-01T20:13:49Z

+1

bsunanda · 2025-08-03T09:05:08Z

@civanch, @subirsarkar, @Moanwar Please approve this PR

Moanwar · 2025-08-03T11:06:09Z

+Upgrade

civanch · 2025-08-03T12:54:33Z

+1

bsunanda · 2025-08-03T15:19:17Z

@BenjaminRS, @quinnanm Please approve this PR

BenjaminRS · 2025-08-06T21:24:52Z

+l1

bsunanda · 2025-08-07T03:06:53Z

@cseez, @pfs Please approve this PR

bsunanda · 2025-08-17T12:31:38Z

@antoniovilela, @mandrenguyen, Please merge this PR

pfs · 2025-08-18T12:58:19Z

+1

cmsbuild · 2025-08-18T12:58:45Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-08-18T13:05:48Z

+1

cmsbuild added this to the CMSSW_15_1_X milestone Jun 12, 2025

cmsbuild added reconstruction-pending simulation-pending l1-pending hlt-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Jun 12, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 12, 2025

cmsbuild added the allow-waredjeb label Jun 12, 2025

mmusich reviewed Jun 12, 2025

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 12, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 12, 2025

cmsbuild added the requires-external label Jun 12, 2025

cmsbuild added tests-started and removed tests-pending labels Jun 12, 2025

cmsbuild removed the tests-started label Jun 12, 2025

cmsbuild mentioned this pull request Jul 31, 2025

Bugfixes to TICL-barrel #48565

Merged

mmusich reviewed Aug 1, 2025

View reviewed changes

remove cms specific type definition in python files

26c420c

	phase2_hgcalV19.toModify(HGCAL_chargeCollectionEfficiencies, values = cms.vdouble(1.0, 1.0,1.0,1.0))
	phase2_hgcalV19.toModify(HGCAL_chargeCollectionEfficiencies, values = [1.0, 1.0,1.0,1.0])

	phase2_hgcalV19.toModify(HGCAL_noise_fC , values = cms.vdouble(0.32041011999999996, 0.384492144, 0.32041011999999996, 0.384492144))
	phase2_hgcalV19.toModify(HGCAL_noise_fC , values = [0.32041011999999996, 0.384492144, 0.32041011999999996, 0.384492144])

	phase2_hgcalV19.toModify(hgceeDigitizer.digiCfg.feCfg, tdcForToAOnset_fC= cms.vdouble(12.,12.,12.,12.))
	phase2_hgcalV19.toModify(hgceeDigitizer.digiCfg.feCfg, tdcForToAOnset_fC= [12.,12.,12.,12.])

	phase2_hgcalV19.toModify(hgchebackDigitizer.digiCfg.feCfg, tdcForToAOnset_fC = cms.vdouble(12.,12.,12.,12.))
	phase2_hgcalV19.toModify(hgchebackDigitizer.digiCfg.feCfg, tdcForToAOnset_fC = [12.,12.,12.,12.])

	phase2_hgcalV19.toModify(hgchefrontDigitizer.digiCfg.feCfg, tdcForToAOnset_fC = cms.vdouble(12.,12.,12.,12.))
	phase2_hgcalV19.toModify(hgchefrontDigitizer.digiCfg.feCfg, tdcForToAOnset_fC = [12.,12.,12.,12.])



		phase2_hgcalV19.toModify(HGCAL_reco_constants,
		thicknessCorrection = 0.75, 0.76, 0.75, 0.76, 0.85, 0.85, 0.84, 0.85 , #CEE_12_HD, CEE_200_LD, CEE_300_LD, CEE_200_HD,CEH_12_HD, CEH_200_LD, CEH_300_LD, CEH_200_HD,

	thicknessCorrection = 0.75, 0.76, 0.75, 0.76, 0.85, 0.85, 0.84, 0.85 , #CEE_12_HD, CEE_200_LD, CEE_300_LD, CEE_200_HD,CEH_12_HD, CEH_200_LD, CEH_300_LD, CEH_200_HD,
	thicknessCorrection = [0.75, 0.76, 0.75, 0.76, 0.85, 0.85, 0.84, 0.85] , #CEE_12_HD, CEE_200_LD, CEE_300_LD, CEE_200_HD,CEH_12_HD, CEH_200_LD, CEH_300_LD, CEH_200_HD,

Conversation

waredjeb commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

Uh oh!

cmsbuild commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jun 12, 2025

Uh oh!

felicepantaleo commented Jun 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Jun 12, 2025

Uh oh!

cmsbuild commented Jun 12, 2025

Uh oh!

mmusich commented Jun 12, 2025

Uh oh!

mmusich commented Jun 12, 2025

Uh oh!

cmsbuild commented Jun 12, 2025

Uh oh!

cmsbuild commented Jul 31, 2025

Uh oh!

waredjeb commented Jul 31, 2025

Uh oh!

waredjeb commented Jul 31, 2025

Uh oh!

cmsbuild commented Jul 31, 2025

Comparison Summary

Uh oh!

mmusich left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

felicepantaleo commented Aug 1, 2025

Uh oh!

felicepantaleo commented Aug 1, 2025

Uh oh!

cmsbuild commented Aug 1, 2025

Uh oh!

cmsbuild commented Aug 1, 2025

Uh oh!

mmusich commented Aug 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mmusich commented Aug 1, 2025

Uh oh!

waredjeb commented Jun 12, 2025 •

edited

Loading

cmsbuild commented Jun 12, 2025 •

edited

Loading