Skip to content

[DBG_X] Fix trackerMaterialAnalysisPlots unit test failure#48338

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
iarspider:iarspider-patches-20250617-1
Jun 18, 2025
Merged

[DBG_X] Fix trackerMaterialAnalysisPlots unit test failure#48338
cmsbuild merged 1 commit intocms-sw:masterfrom
iarspider:iarspider-patches-20250617-1

Conversation

@iarspider
Copy link
Copy Markdown
Contributor

PR description:

Unit test log: link

I would also like to suggest removing redirections in

cmsRun ${VGEO_DIR}/test/trackingMaterialProducer10GeVNeutrino_ForPhaseII.py nEvents=1000 >$TEST_DIR/producer.log 2>&1
cmsRun ${VGEO_DIR}/test/trackingMaterialAnalyser_ForPhaseII.py >$TEST_DIR/plotter.log 2>&1
cmsRun ${VGEO_DIR}/test/listIds_PhaseII.py >$TEST_DIR/listIds.log 2>&1
to facilitate future debugging - this will make actual error(s) visible in unit test log.

PR validation:

Ran test locally.

@iarspider
Copy link
Copy Markdown
Contributor Author

please test for CMSSW_15_1_DBG_X

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jun 17, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • SimG4CMS/Calo (simulation)

@civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @bsunanda, @fabiocos, @felicepantaleo, @martinamalberti, @rovere, @slomeo, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e816f/46784/summary.html
COMMIT: 125b700
CMSSW: CMSSW_15_1_DBG_X_2025-06-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48338/46784/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e816f/46784/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e816f/46784/git-merge-result

RelVals

  • 29634.75A fatal system signal has occurred: segmentation violation
  • 29834.999A fatal system signal has occurred: segmentation violation
  • 29634.0A fatal system signal has occurred: segmentation violation

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e816f/46786/summary.html
COMMIT: 125b700
CMSSW: CMSSW_15_1_X_2025-06-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48338/46786/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e816f/46786/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e816f/46786/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4050825
  • DQMHistoTests: Total failures: 68
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4050737
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@iarspider
Copy link
Copy Markdown
Contributor Author

iarspider commented Jun 17, 2025

  • 29634.75A fatal system signal has occurred: segmentation violation

  • 29834.999A fatal system signal has occurred: segmentation violation

  • 29634.0A fatal system signal has occurred: segmentation violation

Unrelated failures that also happen in IBs.

@iarspider
Copy link
Copy Markdown
Contributor Author

To be exact: these three RVs did not fail in latest DBG_X IB, but there were other RVs, e.g. Relval 25234.0 step 1

@iarspider
Copy link
Copy Markdown
Contributor Author

@civanch
Copy link
Copy Markdown
Contributor

civanch commented Jun 17, 2025

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit bf23176 into cms-sw:master Jun 18, 2025
15 of 16 checks passed
@iarspider iarspider deleted the iarspider-patches-20250617-1 branch June 18, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants