Do not access itr->second if itr is invalid

[iarspider]

PR description:

Fixes #48345

PR validation:

RelVal 34034 doesn't fail on that line (but still hits assertion added in #48245)

[iarspider]

please test for CMSSW_15_1_DBG_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48348/45230

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908306/46801/summary.html
COMMIT: 404f5fc
CMSSW: CMSSW_15_1_DBG_X_2025-06-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48348/46801/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @tvami Fix memory leak in GenHFHadronMatcher #48321
• @ftorrresd Fix Zero Division for Nano Size comparison #48336
• @AdrianoDee Fix to T35 Phase2 Tracker Geometry Module Counts in SimplePixelTopology.h #48271
• @bsunanda Phase2-hgx364R Cure the failure of Relval 32034.0 as reported by Ivan in the issue #48331 #48334
• @mmasciov Customization for HLT doublet-recovery tracking iteration with mkFit #48316

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908306/46801/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908306/46801/git-merge-result

RelVals

• 29634.75A fatal system signal has occurred: segmentation violation
• 29834.999A fatal system signal has occurred: segmentation violation
• 29634.0A fatal system signal has occurred: segmentation violation

[iarspider]

RelVal failures in DBG_X are unrelated: #48347

[cmsbuild]

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-908306/46804/summary.html
COMMIT: 404f5fc
CMSSW: CMSSW_15_1_X_2025-06-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48348/46804/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4050825
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4050799
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[civanch]

@subirsarkar, please, consider this PR.

[civanch]

@subirsarkar, @Moanwar Please approve this

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1