Filter infinite loops in muon trajectory reconstruction [15_0_X]#48351
Filter infinite loops in muon trajectory reconstruction [15_0_X]#48351cmsbuild merged 1 commit intocms-sw:CMSSW_15_0_Xfrom
15_0_X]#48351Conversation
|
A new Pull Request was created by @BlancoFS for CMSSW_15_0_X. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
cms-bot internal usage |
|
please test |
|
backport of #48318 |
|
+1 Size: This PR adds an extra 20KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Backport of #48318
This PR is supposed to fix the issue introduced in CMSHLT-3557. After some investigations, it was observed that a determined sequence of measurements led to an infinite loop in the muon OI trajectory reconstruction. In particular, a pair of valid and invalid (with detId=0) hits was continuously added to the trajectory.
To solve that, the toBeContinued function is modified for the BaseCkfTrajectoryBuilder class. There, if the number of measurements is sufficiently large the last hit, the last to last hit, and the last to last to last hit are checked. If the current hit is equal to the last-2, and the last hit is equal to the last-3; then that temporal trajectory is not continued.
PR validation:
First, the PR is confirmed to successfully solve the issue in CMSHLT-3557. Secondly, it was checked that no other seed from that run fired the logic. A third validation is ongoing to confirm that there is no physics difference.