Updated SoA View accessors from raw pointers to span#48377
Updated SoA View accessors from raw pointers to span#48377cmsbuild merged 1 commit intocms-sw:masterfrom
Conversation
|
cms-bot internal usage |
|
A new Pull Request was created by @leobeltra for master. It involves the following packages:
@Martin-Grunewald, @Moanwar, @antoniovagnerini, @atpathak, @civanch, @cmsbuild, @ctarricone, @francescobrivio, @fwyzard, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @perrotta, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
type ngt |
|
enable gpu |
|
@cmsbuild, please test |
|
allow @leobeltra test rights |
leobeltra
changed the title
|
Pull request #48377 was updated. @Dr15Jones, @Martin-Grunewald, @Moanwar, @arunhep, @atpathak, @bsunanda, @civanch, @cmsbuild, @ctarricone, @fwyzard, @gabrielmscampos, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @nothingface0, @perrotta, @rseidita, @srimanob, @subirsarkar can you please check and sign again. |
|
@leobeltra I think you are basing your commit(s) on the wrong branch, you should use |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48377/46219
|
|
Pull request #48377 was updated. @Martin-Grunewald, @Moanwar, @civanch, @cmsbuild, @ctarricone, @fwyzard, @gabrielmscampos, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @nothingface0, @rseidita, @srimanob, @subirsarkar can you please check and sign again. |
|
Pull request #48377 was updated. @Martin-Grunewald, @Moanwar, @civanch, @cmsbuild, @ctarricone, @fwyzard, @gabrielmscampos, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @nothingface0, @rseidita, @srimanob, @subirsarkar can you please check and sign again. |
| auto& error_data() { return (*view().pixelErrors()); } | ||
| auto const& error_data() const { return (*view().pixelErrors()); } | ||
|
|
There was a problem hiding this comment.
For consistency, can you remove error_data() also from DataFormats/SiPixelDigiSoA/interface/SiPixelDigiErrorsDevice.h ?
|
@leobeltra thanks ! |
|
please test |
|
+heterogeneous |
|
Pull request #48377 was updated. @Martin-Grunewald, @Moanwar, @civanch, @ctarricone, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @mmusich, @nothingface0, @rseidita, @srimanob, @subirsarkar can you please check and sign again. |
|
Looks good to me, some improvements can be worked on in separate PRs. @cms-sw/reconstruction-l2 can you confirm that all changes are fine for you and the POGs ? |
|
Reco is fine with the changes, I will propagate the info to the POGs even though most of them are already tagged in this PR |
|
+1 Size: This PR adds an extra 60KB to repository Comparison SummarySummary:
AMD_MI300X Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
|
|
+hlt
|
|
+simulation |
|
+dqm |
|
+1 |
|
@cms-sw/upgrade-l2 may I ask you to (review and) sign ? |
|
+Upgrade |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
16 participants
PR description:
This PR updates the column accessors in the
Viewfrom raw pointers tostd::span<T>, providing automatic range checking. Adjustments have also been made in CMSSW to support this new approach. This PR is dependent on #48216, so it should be merged after that.PR validation:
The unit tests in CMSSW still pass.