[15.0.X] Adapt template pixel cpe algo to better handle shortened or broken clusters

[mroguljic]

Backport

Backport of #48356 to CMSSW 15.0.X to request data rereco for validation

PR description:

While validating #47966, it was found that the proposed changes to generic CPE algorithm are not beneficial. This PR contains only the proposed changes to the template CPE algorithm that are simpler, and beneficial for long clusters in heavily irradiated pixel sensors (right-most columns in slides 23 onwards). The proposed changes to the algorithm are gated behind a process modifier.

PR validation:

PR passes the basic battery of tests. In the cms-bot wf tests, we expect many small differences also osberved in the main PR. They are understood to come from uninitialized variables (that have been in CMSSW for some time) in the class touched by this PR, causing some numerical instabilities. The uninitialized variables will be fixed in a separate PR.

[cmsbuild]

A new Pull Request was created by @mroguljic for CMSSW_15_0_X.

It involves the following packages:

• CondFormats/SiPixelTransient (reconstruction, db)
• Configuration/ProcessModifiers (operations)
• Configuration/PyReleaseValidation (upgrade, pdmv)
• RecoLocalTracker/SiPixelRecHits (reconstruction)

@AdrianoDee, @Moanwar, @antoniovilela, @atpathak, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @francescobrivio, @jfernan2, @mandrenguyen, @miquork, @perrotta, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanChyczynski, @Martin-Grunewald, @PonIlya, @VinInn, @VourMa, @dkotlins, @fabiocos, @felicepantaleo, @ferencek, @gpetruc, @makortel, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @rsreds, @seemasharmafnal, @slomeo, @threus, @tsusa, @tvami, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Adapt template pixel cpe algo to better handle shortened or broken clusters #48356

[cmsbuild]

cms-bot internal usage

[mmusich]

backport of #48356

[mmusich]

test parameters:

• relvals_opt = --what upgrade
• workflows = 17234.186

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad7070/46908/summary.html
COMMIT: 8c368df
CMSSW: CMSSW_15_0_X_2025-06-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48399/46908/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 21 lines from the logs
• Reco comparison results: 3815 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4009814
• DQMHistoTests: Total failures: 16348
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3993446
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jfernan2]

This backport is not identical to its master version, at least in this file: Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
Is there any reason?

[jfernan2]

ping @mroguljic

[mroguljic]

Apologies, I missed the previous comment. The only difference is the removal of "RecoGlobalFakeHLT" step in the related worfkflow. I believe it is not defined in 150X, and runTheMatrix would report an error with that step included, so I removed it.

EDIT: That step is not important for this PR because template reco does not run at HLT

[perrotta]

Apologies, I missed the previous comment. The only difference is the removal of "RecoGlobalFakeHLT" step in the related worfkflow. I believe it is not defined in 150X, and runTheMatrix would report an error with that step included, so I removed it.

EDIT: That step is not important for this PR because template reco does not run at HLT

Indeed, the relevant PR #47401 was only merged for 151X

[perrotta]

+db

[jfernan2]

+1

[mmusich]

EDIT: That step is not important for this PR because template reco does not run at HLT

this comment is anyway irrelevant, because in 15.1.X the step RecoGlobalFakeHLT is running a fake HLT menu without any reconstruction.

[Moanwar]

+Upgrade

[mandrenguyen]

+1

[AdrianoDee]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will be automatically merged.