Increase Nano relval WF counter buffer size#48459
Merged
cmsbuild merged 2 commits intocms-sw:masterfrom Jul 5, 2025
Merged
Conversation
Contributor
|
cms-bot internal usage |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48459/45378
|
Contributor
|
A new Pull Request was created by @ftorrresd for master. It involves the following packages:
@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
Author
|
enable nano |
Contributor
Author
|
please test |
Contributor
|
-1 Failed Tests: RelVals RelValsValueError: Undefined workflows: 2500.301 NANO Comparison SummarySummary:
Nano size comparison Summary:
|
Contributor
Author
|
please test |
cmsbuild
added
tests-started
code-checks-pending
and removed
tests-rejected
code-checks-approved
labels
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48459/45381
|
Contributor
|
Pull request #48459 was updated. @AdrianoDee, @Moanwar, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again. |
Contributor
|
+1 Size: This PR adds an extra 36KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
Contributor
|
assign xpog |
Contributor
|
New categories assigned: xpog @ftorrresd,@hqucms you have been requested to review this Pull request/Issue and eventually sign? Thanks |
Contributor
|
+xpog |
Contributor
|
+pdmv |
Contributor
|
+Upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
Contributor
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
Increase Nano relval WF counter buffer size, in order to avoid situations like: #48163 (comment) .
PR validation:
Tested locally. Expect WF number were generated.