Fix for n_layers Check in CAHitNtupletAlpaka::globalBeginRun

[AdrianoDee]

This PR fixes the issue described in #48473 limiting the writing in layerStarts to the n_layers + 1 elements (and so up to the n_layersth element).

Tested successfully 16834.0 with CMSSW_15_1_ASAN_X_2025-07-02-2300.

[AdrianoDee]

type bug-fix

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48477/45403

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoTracker/PixelSeeding/plugins/alpaka/CAHitNtuplet.cc modified in PR(s): Use TkPixelCPERecord for PixelCPEFastParams* #46852, CA Extension to strips #47090

[cmsbuild]

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

• RecoTracker/PixelSeeding (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[AdrianoDee]

test parameters:

• relval_opts = -w upgrade
• relval = 16834
• release = CMSSW_15_1_ASAN_X_2025-07-02-2300

[AdrianoDee]

please test

[AdrianoDee]

please abort

[AdrianoDee]

test parameters:

• relval_opts = -w upgrade
• relval = 16834

[AdrianoDee]

please test for CMSSW_15_1_ASAN_X_2025-07-02-2300

[AdrianoDee]

test parameters:

• relval_opts = -w upgrade
• relval = 16834
• release = CMSSW_15_1_ASAN_X

[AdrianoDee]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dde292/47070/summary.html
COMMIT: 64ed3f2
CMSSW: CMSSW_15_1_ASAN_X_2025-07-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48477/47070/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 29634.7529634.75_TTbar_14TeV+Run4D110_HLT75e33Timing/step2_TTbar_14TeV+Run4D110_HLT75e33Timing.log
• 29834.99929834.999_TTbar_14TeV+Run4D110PU_PMXS1S2PR/step3_TTbar_14TeV+Run4D110PU_PMXS1S2PR.log
• 24834.91124834.911_TTbar_14TeV+Run4D98_DD4hep/step2_TTbar_14TeV+Run4D98_DD4hep.log

Expand to see more relval errors ...

• 29700.0
• 145.301
• 29696.0
• 29634.911
• 29634.0

[AdrianoDee]

Taking a random example, the 145.408:

• fails in the latest IB tests;
• is successful in the bot tests here.

The failures we see here in the tests were there before #47611.

[AdrianoDee]

test parameters:

• relval_opts = -w upgrade
• relval = 16834

[AdrianoDee]

please test
(with the standard build)

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dde292/47075/summary.html
COMMIT: 64ed3f2
CMSSW: CMSSW_15_1_X_2025-07-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48477/47075/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 4295982
• DQMHistoTests: Total failures: 69
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4295893
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 223 log files, 194 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1