Skip to content

Moving 2024 Data Wfs HLT Key to hltKey2024#48479

Closed
AdrianoDee wants to merge 1 commit intocms-sw:masterfrom
AdrianoDee:hltKey2024_2024wfs
Closed

Moving 2024 Data Wfs HLT Key to hltKey2024#48479
AdrianoDee wants to merge 1 commit intocms-sw:masterfrom
AdrianoDee:hltKey2024_2024wfs

Conversation

@AdrianoDee
Copy link
Copy Markdown
Contributor

This PR proposes to move back the 2024 data wfs to hltKey2024 since now that we have 2025 data wfs to test. In a following PR I'll add the 2025 data wfs to the limited matrix.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jul 4, 2025

cms-bot internal usage

@AdrianoDee
Copy link
Copy Markdown
Contributor Author

@cms-sw/hlt-l2 FYI

@AdrianoDee
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jul 4, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48479/45406

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Jul 4, 2025

in a following PR I'll add the 2025 data wfs to the limited matrix

I'd prefer if it's done in this one.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jul 4, 2025

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Copy Markdown
Contributor Author

I'd prefer if it's done in this one.

Fine by me, I wanted to split it because I don't want to introduce the hardcoded lumis wfs for 2025 and I'd add the fixed number of events ones by pushing also an improvement to make das-up-to-nevents.py queries lighter when running the tests. Anyway I'll open the other PR soon (this afternoon) and eventually I can merge them in a single one.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jul 4, 2025

+1

Size: This PR adds an extra 68KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-809dda/47083/summary.html
COMMIT: e005996
CMSSW: CMSSW_15_1_X_2025-07-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48479/47083/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2123232 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 34 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3825827
  • DQMHistoTests: Total failures: 30180
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3795627
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -541917.7239999999 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 145.014,... ): -41024.718 KiB HLT/JME
  • DQMHistoSizes: changed ( 145.014,... ): -7723.324 KiB HLT/EXO
  • DQMHistoSizes: changed ( 145.014,... ): -6637.487 KiB HLT/BTV
  • DQMHistoSizes: changed ( 145.014,... ): -2518.712 KiB HLT/SUSY
  • DQMHistoSizes: changed ( 145.014,... ): -2253.513 KiB HLT/TOP
  • DQMHistoSizes: changed ( 145.014,... ): -1724.938 KiB HLT/Objects
  • DQMHistoSizes: changed ( 145.014,... ): -1565.013 KiB HLT/HIG
  • DQMHistoSizes: changed ( 145.014,... ): -1543.790 KiB HLT/EGM
  • DQMHistoSizes: changed ( 145.014,... ): -1506.888 KiB HLT/B2G
  • DQMHistoSizes: changed ( 145.014,... ): -1003.781 KiB HLT/SUS
  • DQMHistoSizes: changed ( 145.014 ): ...
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 8 / 48 workflows

@AdrianoDee
Copy link
Copy Markdown
Contributor Author

I've included this change in #48490, that's introducing 2025 wfs for the limited matrix. So I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants