Skip to content

[15_0_X][L1T] Update L1 Tau isolation LUT#48492

Merged
cmsbuild merged 1 commit intocms-sw:CMSSW_15_0_Xfrom
Pmeiring:15_0_X_tauIsoLUT_July2025
Jul 8, 2025
Merged

[15_0_X][L1T] Update L1 Tau isolation LUT#48492
cmsbuild merged 1 commit intocms-sw:CMSSW_15_0_Xfrom
Pmeiring:15_0_X_tauIsoLUT_July2025

Conversation

@Pmeiring
Copy link
Copy Markdown

@Pmeiring Pmeiring commented Jul 7, 2025

PR description:

This backport PR introduces the new CALO-L2 Tau isolation LUT for 2025 post-TS1 pp data-taking. Apart from the pointers to the LUT (tauIsoLUTFile and tauIsoLUTFile2), the caloParams file is identical to caloParams_2025_v0_2.

The LUT is the "baseline" version from this JIRA ticket, which also contains all validation studies:
https://its.cern.ch/jira/browse/CMSLITDPG-1395

This PR depends on:
cms-data/L1Trigger-L1TCalorimeter#29

PR validation:

See backport PR.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport PR to CMSSW_15_0_X. The corresponding original PR is: #48482

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jul 7, 2025

A new Pull Request was created by @Pmeiring for CMSSW_15_0_X.

It involves the following packages:

  • L1Trigger/Configuration (l1)
  • L1Trigger/L1TCalorimeter (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jul 7, 2025

cms-bot internal usage

@BenjaminRS
Copy link
Copy Markdown
Contributor

test parameters:

@BenjaminRS
Copy link
Copy Markdown
Contributor

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jul 7, 2025

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b33001/47117/summary.html
COMMIT: 7940439
CMSSW: CMSSW_15_0_X_2025-07-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48492/47117/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b33001/47117/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b33001/47117/git-merge-result

Comparison Summary

Summary:

  • You potentially added 36 lines to the logs
  • Reco comparison results: 2633 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4006781
  • DQMHistoTests: Total failures: 1815
  • DQMHistoTests: Total nulls: 18
  • DQMHistoTests: Total successes: 4004928
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8685.908 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 145.104,... ): -4.324 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 16834.0,... ): 4358.088 KiB HLT/Tracking
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@BenjaminRS
Copy link
Copy Markdown
Contributor

+l1

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jul 8, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 9d9f3ee into cms-sw:CMSSW_15_0_X Jul 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants