Restore removal of all duplicate pixel hits in Phase-1 pixel raw to cluster by mroguljic · Pull Request #48609 · cms-sw/cmssw

mroguljic · 2025-07-23T07:47:53Z

PR description:

This PR introduces back the removal of all duplicate pixel hits. This was recently changed, and discussed, in PR#48580. Small changes in Phase-1 workflows are expected.

To be backported to 15.0.X, either with the modification of PR#48581 or a new PR.

PR validation:

The standard battery of tests reported

44 29 27 24 7 0 0 0 0 0 0 tests passed, 6 14 1 0 0 0 0 0 0 0 0 failed

I believe all the failed tests are due to eos issues. All the (failed) logs contain messages such as:

Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/18E0AF9F-BA7F-E011-AC1C-001D09F24259.root'

cmsbuild · 2025-07-23T07:48:21Z

cms-bot internal usage

cmsbuild · 2025-07-23T07:53:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48609/45579

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/PixelClustering.h modified in PR(s): Pixelimage morphing #48343

cmsbuild · 2025-07-23T07:53:25Z

A new Pull Request was created by @mroguljic for master.

It involves the following packages:

RecoLocalTracker/SiPixelClusterizer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dkotlins, @felicepantaleo, @ferencek, @gpetruc, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @threus, @tsusa, @tvami this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2025-07-23T07:55:09Z

please test

cmsbuild · 2025-07-23T09:56:29Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3daf41/47351/summary.html
COMMIT: e72ec87
CMSSW: CMSSW_15_1_X_2025-07-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48609/47351/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4076481
DQMHistoTests: Total failures: 10619
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4065842
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: found differences in 2 / 48 workflows

jfernan2 · 2025-07-23T10:12:44Z

+1

cmsbuild · 2025-07-23T10:13:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

fwyzard · 2025-07-23T11:16:33Z

assign heterogeneous

fwyzard · 2025-07-23T11:16:39Z

-heterogeneous

fwyzard · 2025-07-23T11:16:51Z

        if constexpr (not isPhase2) {
          // packed words array used to store the pixelStatus of each pixel
-          auto& image = alpaka::declareSharedVar<uint32_t[pixelStatus::size], __COUNTER__>(acc);
+          auto& status = alpaka::declareSharedVar<uint32_t[pixelStatus::size], __COUNTER__>(acc);


please do not rename the variable

cmsbuild · 2025-07-23T11:16:57Z

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2025-07-24T08:51:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48609/45587

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalTracker/SiPixelClusterizer/plugins/alpaka/PixelClustering.h modified in PR(s): Pixelimage morphing #48343

cmsbuild · 2025-07-24T08:51:36Z

Pull request #48609 was updated. @cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen can you please check and sign again.

fwyzard · 2025-07-24T15:56:40Z

enable gpu

fwyzard · 2025-07-24T15:56:43Z

please test

cmsbuild · 2025-07-24T20:48:50Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3daf41/47378/summary.html
COMMIT: dc7b444
CMSSW: CMSSW_15_1_X_2025-07-24-1100/el8_amd64_gcc12
Additional Tests: CUDA,ROCM
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48609/47378/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 1
DQMHistoTests: Total histograms compared: 0
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 0
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
Checked 0 log files, 0 edm output root files, 1 DQM output files

CUDA Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 71 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 53445
DQMHistoTests: Total failures: 7917
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 45528
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 24 log files, 30 edm output root files, 7 DQM output files
TriggerResults: no differences found

ROCM Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 71 differences found in the comparisons
DQMHistoTests: Total files compared: 7
DQMHistoTests: Total histograms compared: 53445
DQMHistoTests: Total failures: 8990
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 44455
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
Checked 24 log files, 30 edm output root files, 7 DQM output files
TriggerResults: no differences found

fwyzard · 2025-07-24T21:51:46Z

+heterogeneous

jfernan2 · 2025-07-25T16:26:29Z

+1

cmsbuild · 2025-07-25T16:26:47Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-07-26T10:35:55Z

+1

alpaka: remove all duplicate pixel hits

e72ec87

cmsbuild added this to the CMSSW_15_1_X milestone Jul 23, 2025

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending trk labels Jul 23, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 23, 2025

cmsbuild added tests-started and removed tests-pending labels Jul 23, 2025

cmsbuild added tests-approved and removed tests-started labels Jul 23, 2025

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Jul 23, 2025

fwyzard reviewed Jul 23, 2025

View reviewed changes

cmsbuild removed the fully-signed label Jul 23, 2025

cmsbuild added tests-pending code-checks-pending heterogeneous-pending labels Jul 24, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 24, 2025

mroguljic mentioned this pull request Jul 24, 2025

[15.0.X] Restore removal of all duplicate pixel hits in Phase-1 pixel raw to cluster #48625

Closed

cmsbuild added tests-started and removed tests-pending labels Jul 24, 2025

cmsbuild added tests-approved and removed tests-started labels Jul 24, 2025

cmsbuild added heterogeneous-approved and removed heterogeneous-pending labels Jul 24, 2025

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Jul 25, 2025

cmsbuild added orp-approved and removed orp-pending labels Jul 26, 2025

cmsbuild merged commit 7d467a2 into cms-sw:master Jul 26, 2025
16 checks passed

This was referenced Jul 28, 2025

Improve the Phase-1 pixel raw to cluster [15.0.x] #48581

Merged

Improve the Phase 1 pixel raw to cluster (part 2) #48644

Merged

Conversation

mroguljic commented Jul 23, 2025

PR description:

PR validation:

Uh oh!

cmsbuild commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jul 23, 2025

Uh oh!

cmsbuild commented Jul 23, 2025

Uh oh!

jfernan2 commented Jul 23, 2025

Uh oh!

cmsbuild commented Jul 23, 2025

Comparison Summary

Uh oh!

jfernan2 commented Jul 23, 2025

Uh oh!

cmsbuild commented Jul 23, 2025

Uh oh!

fwyzard commented Jul 23, 2025

Uh oh!

fwyzard commented Jul 23, 2025

Uh oh!

fwyzard Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Jul 23, 2025

Uh oh!

cmsbuild commented Jul 24, 2025

Uh oh!

cmsbuild commented Jul 24, 2025

Uh oh!

fwyzard commented Jul 24, 2025

Uh oh!

fwyzard commented Jul 24, 2025

Uh oh!

cmsbuild commented Jul 24, 2025

Comparison Summary

CUDA Comparison Summary

ROCM Comparison Summary

Uh oh!

fwyzard commented Jul 24, 2025

Uh oh!

jfernan2 commented Jul 25, 2025

Uh oh!

cmsbuild commented Jul 25, 2025

Uh oh!

mandrenguyen commented Jul 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cmsbuild commented Jul 23, 2025 •

edited

Loading