Skip to content

Extend cmsTraceFunction test to putenv() and --abort#48778

Merged
cmsbuild merged 3 commits into
cms-sw:masterfrom
makortel:cmsTraceFunctionTest
Sep 20, 2025
Merged

Extend cmsTraceFunction test to putenv() and --abort#48778
cmsbuild merged 3 commits into
cms-sw:masterfrom
makortel:cmsTraceFunctionTest

Conversation

@makortel
Copy link
Copy Markdown
Contributor

@makortel makortel commented Aug 21, 2025

PR description:

This PR complements cms-sw/cms-common#20 by requiring the cmsTraceFunction to exit with non-zero exit code. It also extends the testing to cover putenv() (#46002 (comment), #46002 (comment))

Resolves cms-sw/framework-team#1526

Must be merged after cms-sw/cms-common#20

PR validation:

Unit test runs with the change in cms-sw/cms-common#20

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Aug 21, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • Utilities/ReleaseScripts (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test with cms-sw/cms-common#20

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0deee/47819/summary.html
COMMIT: a743f60
CMSSW: CMSSW_15_1_X_2025-08-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48778/47819/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-cmsTraceFunction-setenv had ERRORS

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4075767
  • DQMHistoTests: Total failures: 32
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4075715
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Copy Markdown
Contributor Author

please test with cms-sw/cms-common#20

Ok, so testing together with cms-sw/cms-common#20 didn't work. I guess we need cms-sw/cms-common#20 merged first (that PR should work with the present test).

@makortel
Copy link
Copy Markdown
Contributor Author

makortel commented Sep 2, 2025

@cmsbuild, please test with cms-sw/cmsdist#10051

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Sep 2, 2025

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0deee/47947/summary.html
COMMIT: a743f60
CMSSW: CMSSW_15_1_X_2025-09-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48778/47947/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0deee/47947/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0deee/47947/git-merge-result

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4115479
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4115453
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Copy Markdown
Contributor

Milestone for this pull request has been moved to CMSSW_16_0_X. Please open a backport if it should also go in to CMSSW_15_1_X.

@cmsbuild cmsbuild removed this from the CMSSW_15_1_X milestone Sep 10, 2025
@makortel makortel force-pushed the cmsTraceFunctionTest branch from 63087a9 to f388711 Compare September 18, 2025 19:05
@makortel
Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@makortel
Copy link
Copy Markdown
Contributor Author

I suggest that we should also test it without --abort option too (just to make sure it keeps on running and call setenv/putenv correctly)

@smuzaffar Thanks for the good suggestion. How about now?

@smuzaffar
Copy link
Copy Markdown
Contributor

@makortel , looks good now

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #48778 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0deee/48222/summary.html
COMMIT: f388711
CMSSW: CMSSW_16_0_X_2025-09-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48778/48222/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3978581
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3978561
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 210 log files, 180 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Copy Markdown
Contributor Author

+core

Per @smuzaffar's comment in #48778 (comment)

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit ae2013e into cms-sw:master Sep 20, 2025
10 checks passed
@makortel makortel deleted the cmsTraceFunctionTest branch September 26, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to cmsTraceFunction to exit with non-zero exit code after hitting a breakpoint

4 participants