Extend cmsTraceFunction test to putenv() and --abort#48778
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48778/45862 |
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test with cms-sw/cms-common#20 |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test test-cmsTraceFunction-setenv had ERRORS Comparison SummarySummary:
|
Ok, so testing together with cms-sw/cms-common#20 didn't work. I guess we need cms-sw/cms-common#20 merged first (that PR should work with the present test). |
|
@cmsbuild, please test with cms-sw/cmsdist#10051 |
|
+1 Size: This PR adds an extra 16KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
Milestone for this pull request has been moved to CMSSW_16_0_X. Please open a backport if it should also go in to CMSSW_15_1_X. |
63087a9 to
f388711
Compare
|
@cmsbuild, please test |
@smuzaffar Thanks for the good suggestion. How about now? |
|
@makortel , looks good now |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48778/46120 |
|
Pull request #48778 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again. |
|
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
|
+core Per @smuzaffar's comment in #48778 (comment) |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR complements cms-sw/cms-common#20 by requiring the
cmsTraceFunctionto exit with non-zero exit code. It also extends the testing to coverputenv()(#46002 (comment), #46002 (comment))Resolves cms-sw/framework-team#1526
Must be merged after cms-sw/cms-common#20
PR validation:
Unit test runs with the change in cms-sw/cms-common#20