[15_0_X] Digi Morphing for HLT#48831
Closed
Chirayu18 wants to merge 3 commits intocms-sw:CMSSW_15_0_Xfrom
Closed
Conversation
Moved functions inside and made static
Contributor
|
A new Pull Request was created by @Chirayu18 for CMSSW_15_0_X. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
cms-bot internal usage |
Contributor
|
Pull request #48831 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again. |
Contributor
|
Can you rebase the code on top of the latest CMSSW_15_0_X release, to get rid of the merge commit ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
Morphing Algorithm for Fake Digi Addition
Backport of #48734 to CMSSW_15_0_X
This PR introduces an alternative alpaka-based algorithm for pixel digi morphing. This implementation is equivalent in principle to the legacy implementation and to the other alpaka-based implementation in PR #48343 but supercedes the latter as it has issues with throughput due to memory usage. Like the other implementations, digi morphing is applied here only to specific detector regions which can be configured as shown below.
Configuration Options
The morphing behavior can be controlled in the EDProducer configuration with the following options:
Regional Morphing
Regions can be specified in the configuration as follows:
Barrel Regions:
Use
LAYER,LADDER,MODULEcoordinates, with support for individual values or ranges (e.g.,1-12for ladders 1 through 12).Endcap Regions:
Use
DISK,BLADE,SIDE,PANELcoordinates, with support for ranges.PR validation:
Validation results can be found here: https://indico.cern.ch/event/1567986/contributions/6647897/attachments/3116797/5527819/HLT_digi_morphing_validation.pdf