Skip to content

[15_0_X] Digi Morphing for HLT#48831

Closed
Chirayu18 wants to merge 3 commits intocms-sw:CMSSW_15_0_Xfrom
CMSTrackerDPG:digimorphing_backport
Closed

[15_0_X] Digi Morphing for HLT#48831
Chirayu18 wants to merge 3 commits intocms-sw:CMSSW_15_0_Xfrom
CMSTrackerDPG:digimorphing_backport

Conversation

@Chirayu18
Copy link
Copy Markdown
Contributor

PR description:

Morphing Algorithm for Fake Digi Addition

Backport of #48734 to CMSSW_15_0_X

This PR introduces an alternative alpaka-based algorithm for pixel digi morphing. This implementation is equivalent in principle to the legacy implementation and to the other alpaka-based implementation in PR #48343 but supercedes the latter as it has issues with throughput due to memory usage. Like the other implementations, digi morphing is applied here only to specific detector regions which can be configured as shown below.

Configuration Options

The morphing behavior can be controlled in the EDProducer configuration with the following options:

  • Enable Morphing:
    DoDigiMorphing = cms.bool(True)  # Default: False
  • Maximum Fakes per Module:
    MaxFakesInModule = cms.uint32(10000)  # Default: maxPixInModule * 2 / 5

Regional Morphing

Regions can be specified in the configuration as follows:

  • Barrel Regions:
    Use LAYER,LADDER,MODULE coordinates, with support for individual values or ranges (e.g., 1-12 for ladders 1 through 12).

    barrelRegions = cms.vstring(
        "1,1-12,1-2",
        "1,1-12,7-8",
        "2,1-28,1",
        "2,1-28,8"
    )  # Default: as shown above
  • Endcap Regions:
    Use DISK,BLADE,SIDE,PANEL coordinates, with support for ranges.

    endcapRegions = cms.vstring(
        # Default: empty (no endcap regions selected)
    )

PR validation:

Validation results can be found here: https://indico.cern.ch/event/1567986/contributions/6647897/attachments/3116797/5527819/HLT_digi_morphing_validation.pdf

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Sep 2, 2025

A new Pull Request was created by @Chirayu18 for CMSSW_15_0_X.

It involves the following packages:

  • RecoLocalTracker/SiPixelClusterizer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dkotlins, @felicepantaleo, @ferencek, @gpetruc, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @threus, @tsusa, @tvami this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Sep 2, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Sep 2, 2025

Pull request #48831 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

@fwyzard
Copy link
Copy Markdown
Contributor

fwyzard commented Sep 2, 2025

Can you rebase the code on top of the latest CMSSW_15_0_X release, to get rid of the merge commit ?

@Chirayu18 Chirayu18 closed this Sep 2, 2025
@Chirayu18 Chirayu18 deleted the digimorphing_backport branch September 2, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants