Skip to content

TICLv5 Adjust Linking step #48851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 5 commits into from
Sep 10, 2025
Merged

TICLv5 Adjust Linking step #48851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a187a56
tighter cuts in CEE region
waredjeb Sep 4, 2025
9a4e5cf
move linking energy regression to TICLCandidateLevel, remove Track on…
waredjeb Sep 4, 2025
c301faa
remove linking between CEE objects
waredjeb Sep 5, 2025
3549178
fix wfs selection in ticl_v5 procModifiers
AuroraPerego Sep 5, 2025
7ea385e
remove duplicate call to mergeTracksters
AuroraPerego Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ def setup_(self, step, stepName, stepDict, k, properties):
stepDict[stepName][k] = merge([self.step4, stepDict[step][k]])
def condition(self, fragment, stepList, key, hasHarvest):
selected_fragments = ["TTbar_14TeV", "CloseByP", "Eta1p7_2p7", "ZEE_14"]
return (fragment in selected_fragments) and 'Run4' in key
return any(sf in fragment for sf in selected_fragments) and 'Run4' in key

upgradeWFs['ticl_v5'] = UpgradeWorkflow_ticl_v5(
steps = [
Expand Down
19 changes: 19 additions & 0 deletions HLTrigger/Configuration/python/HLT_75e33/modules/hltTiclCandidate_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,25 @@
import FWCore.ParameterSet.Config as cms

hltTiclCandidate = cms.EDProducer("TICLCandidateProducer",
inferenceAlgo = cms.string('TracksterInferenceByPFN'),
regressionAndPid = cms.bool(True),
pluginInferenceAlgoTracksterInferenceByPFN = cms.PSet(
algo_verbosity = cms.int32(0),
onnxPIDModelPath = cms.FileInPath('RecoHGCal/TICL/data/ticlv5/onnx_models/PFN/linking/id_v0.onnx'),
onnxEnergyModelPath = cms.FileInPath('RecoHGCal/TICL/data/ticlv5/onnx_models/PFN/linking/energy_v0.onnx'),
inputNames = cms.vstring(
'input',
'input_tr_features'
),
output_en = cms.vstring('enreg_output'),
output_id = cms.vstring('pid_output'),
eid_min_cluster_energy = cms.double(1),
eid_n_layers = cms.int32(50),
eid_n_clusters = cms.int32(10),
doPID = cms.int32(1),
doRegression = cms.int32(1),
type = cms.string('TracksterInferenceByPFN')
),
cutTk = cms.string('1.48 < abs(eta) < 3.0 && pt > 1. && quality("highPurity") && hitPattern().numberOfLostHits("MISSING_OUTER_HITS") < 5'),
detector = cms.string('HGCAL'),
egamma_tracksterlinks_collections = cms.VInputTag("hltTiclTracksterLinks"),
Expand Down
2 changes: 1 addition & 1 deletion HLTrigger/Configuration/python/HLT_75e33/modules/hltTiclTracksterLinksL1Seeded_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
mightGet = cms.optional.untracked.vstring,
original_masks = cms.VInputTag("hltMergeLayerClustersL1Seeded:InitialLayerClustersMask"),
propagator = cms.string('PropagatorWithMaterial'),
regressionAndPid = cms.bool(True),
regressionAndPid = cms.bool(False),
tracksters_collections = cms.VInputTag("hltTiclTrackstersCLUE3DHighL1Seeded", "hltTiclTrackstersRecoveryL1Seeded")
)

Expand Down
2 changes: 1 addition & 1 deletion HLTrigger/Configuration/python/HLT_75e33/modules/hltTiclTracksterLinks_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
mightGet = cms.optional.untracked.vstring,
original_masks = cms.VInputTag("hltMergeLayerClusters:InitialLayerClustersMask"),
propagator = cms.string('PropagatorWithMaterial'),
regressionAndPid = cms.bool(True),
regressionAndPid = cms.bool(False),
tracksters_collections = cms.VInputTag("hltTiclTrackstersCLUE3DHigh", "hltTiclTrackstersRecovery")
)

Expand Down
4 changes: 2 additions & 2 deletions HLTrigger/Configuration/python/HLT_75e33/psets/hltTiclTracksterLinksPSet_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
100
),
upper_distance_projective_sqr = cms.vdouble(
30,
4,
60
),
lower_distance_projective_sqr = cms.vdouble(
30,
4,
60
),
min_distance_z = cms.vdouble(
Expand Down
5 changes: 1 addition & 4 deletions RecoHGCal/TICL/plugins/GeneralInterpretationAlgo.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,18 +375,15 @@ void GeneralInterpretationAlgo::makeCandidates(const Inputs &input,
// in this case mergeTracksters() clears the pid probabilities and the regressed energy is not set
// TODO: fix probabilities when CNN will be splitted
Trackster outTrackster;
float regr_en = 0.f;
bool isHadron = false;
outTrackster.mergeTracksters(input.tracksters, trackstersInTrackIndices[iTrack]);
for (auto const tracksterId : trackstersInTrackIndices[iTrack]) {
//maskTracksters[tracksterId] = 0;
regr_en += input.tracksters[tracksterId].regressed_energy();
outTrackster.mergeTracksters(input.tracksters[tracksterId]);
if (input.tracksters[tracksterId].isHadronic())
isHadron = true;
}
resultCandidate[iTrack] = resultTracksters.size();
resultTracksters.push_back(outTrackster);
resultTracksters.back().setRegressedEnergy(regr_en);
// since a track has been linked it can only be electron or charged hadron
if (isHadron)
resultTracksters.back().setIdProbability(ticl::Trackster::ParticleType::charged_hadron, 1.f);
Expand Down
46 changes: 38 additions & 8 deletions RecoHGCal/TICL/plugins/TICLCandidateProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Author: Felice Pantaleo, Wahid Redjeb, Aurora Perego (CERN) - felice.pantaleo@cern.ch, wahid.redjeb@cern.ch, aurora.perego@cern.ch
// Date: 12/2023
// Author: Felice Pantaleo, Wahid Redjeb, Aurora Perego (CERN) - felice.pantaleo@cern.ch, wahid.redjeb@cern.ch, aurora.perego@cern.ch Date: 12/2023
#include <memory> // unique_ptr
#include "DataFormats/HGCalReco/interface/MultiVectorManager.h"
#include "FWCore/Framework/interface/stream/EDProducer.h"
Expand Down Expand Up @@ -47,22 +46,28 @@
#include "MagneticField/Engine/interface/MagneticField.h"
#include "MagneticField/Records/interface/IdealMagneticFieldRecord.h"

#include "PhysicsTools/ONNXRuntime/interface/ONNXRuntime.h"

#include "Geometry/HGCalCommonData/interface/HGCalDDDConstants.h"
#include "Geometry/Records/interface/IdealGeometryRecord.h"
#include "Geometry/CommonDetUnit/interface/GeomDet.h"
#include "RecoHGCal/TICL/interface/TracksterInferenceAlgoFactory.h"

#include "TrackstersPCA.h"

using namespace ticl;
using cms::Ort::ONNXRuntime;

class TICLCandidateProducer : public edm::stream::EDProducer<> {
class TICLCandidateProducer : public edm::stream::EDProducer<edm::GlobalCache<ONNXRuntime>> {
public:
explicit TICLCandidateProducer(const edm::ParameterSet &ps);
explicit TICLCandidateProducer(const edm::ParameterSet &ps, const ONNXRuntime *);
~TICLCandidateProducer() override {}
void produce(edm::Event &, const edm::EventSetup &) override;
static void fillDescriptions(edm::ConfigurationDescriptions &descriptions);

void beginRun(edm::Run const &iEvent, edm::EventSetup const &es) override;
static std::unique_ptr<ONNXRuntime> initializeGlobalCache(const edm::ParameterSet &iConfig);
static void globalEndJob(const ONNXRuntime *);

private:
void dumpCandidate(const TICLCandidate &) const;
Expand All @@ -82,6 +87,8 @@ class TICLCandidateProducer : public edm::stream::EDProducer<> {

const edm::EDGetTokenT<std::vector<reco::CaloCluster>> clusters_token_;
const edm::EDGetTokenT<edm::ValueMap<std::pair<float, float>>> clustersTime_token_;
const bool regressionAndPid_;
std::unique_ptr<TracksterInferenceAlgoBase> inferenceAlgo_;

std::vector<edm::EDGetTokenT<std::vector<float>>> original_masks_tokens_;

Expand Down Expand Up @@ -113,10 +120,11 @@ class TICLCandidateProducer : public edm::stream::EDProducer<> {
static constexpr float timeRes = 0.02f;
};

TICLCandidateProducer::TICLCandidateProducer(const edm::ParameterSet &ps)
TICLCandidateProducer::TICLCandidateProducer(const edm::ParameterSet &ps, const ONNXRuntime *)
: clusters_token_(consumes<std::vector<reco::CaloCluster>>(ps.getParameter<edm::InputTag>("layer_clusters"))),
clustersTime_token_(
consumes<edm::ValueMap<std::pair<float, float>>>(ps.getParameter<edm::InputTag>("layer_clustersTime"))),
regressionAndPid_(ps.getParameter<bool>("regressionAndPid")),
tracks_token_(consumes<std::vector<reco::Track>>(ps.getParameter<edm::InputTag>("tracks"))),
muons_token_(consumes<std::vector<reco::Muon>>(ps.getParameter<edm::InputTag>("muons"))),
useMTDTiming_(ps.getParameter<bool>("useMTDTiming")),
Expand Down Expand Up @@ -168,6 +176,11 @@ TICLCandidateProducer::TICLCandidateProducer(const edm::ParameterSet &ps)
if (useMTDTiming_) {
inputTimingToken_ = consumes<MtdHostCollection>(ps.getParameter<edm::InputTag>("timingSoA"));
}
// Initialize inference algorithm using the factory
std::string inferencePlugin = ps.getParameter<std::string>("inferenceAlgo");
edm::ParameterSet inferencePSet = ps.getParameter<edm::ParameterSet>("pluginInferenceAlgo" + inferencePlugin);
inferenceAlgo_ = std::unique_ptr<TracksterInferenceAlgoBase>(
TracksterInferenceAlgoFactory::get()->create(inferencePlugin, inferencePSet));

produces<std::vector<TICLCandidate>>();

Expand All @@ -180,6 +193,12 @@ TICLCandidateProducer::TICLCandidateProducer(const edm::ParameterSet &ps)
TICLGeneralInterpretationPluginFactory::get()->create(algoType, interpretationPSet, consumesCollector());
}

std::unique_ptr<ONNXRuntime> TICLCandidateProducer::initializeGlobalCache(const edm::ParameterSet &iConfig) {
return std::unique_ptr<ONNXRuntime>(nullptr);
}

void TICLCandidateProducer::globalEndJob(const ONNXRuntime *) {}

void TICLCandidateProducer::beginRun(edm::Run const &iEvent, edm::EventSetup const &es) {
edm::ESHandle<HGCalDDDConstants> hdc = es.getHandle(hdc_token_);
hgcons_ = hdc.product();
Expand Down Expand Up @@ -311,6 +330,12 @@ void TICLCandidateProducer::produce(edm::Event &evt, const edm::EventSetup &es)
rhtools_.getPositionLayer(rhtools_.lastLayerEE()).z(),
rhtools_,
true);
if (regressionAndPid_) {
// Run inference algorithm
inferenceAlgo_->inputData(layerClusters, *resultTracksters);
inferenceAlgo_->runInference(
*resultTracksters); //option to use "Linking" instead of "CLU3D"/"energyAndPid" instead of "PID"
}

std::vector<bool> maskTracksters(resultTracksters->size(), true);
edm::OrphanHandle<std::vector<Trackster>> resultTracksters_h = evt.put(std::move(resultTracksters));
Expand All @@ -326,16 +351,16 @@ void TICLCandidateProducer::produce(edm::Event &evt, const edm::EventSetup &es)
maskTracksters[tracksterId] = false;
} else {
//charged candidates track only
edm::Ptr<Trackster> tracksterPtr;
TICLCandidate chargedCandidate(trackPtr, tracksterPtr);
auto trackRef = edm::Ref<reco::TrackCollection>(tracks_h, iTrack);
const int muId = PFMuonAlgo::muAssocToTrack(trackRef, *muons_h);
const reco::MuonRef muonRef = reco::MuonRef(muons_h, muId);
if (muonRef.isNonnull() and muonRef->isGlobalMuon()) {
// create muon candidate
edm::Ptr<Trackster> tracksterPtr;
TICLCandidate chargedCandidate(trackPtr, tracksterPtr);
Copy link
Copy Markdown
Contributor

@Moanwar Moanwar Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just to check, this is where you discarded the alone track, right?

Copy link
Copy Markdown
Contributor Author

@waredjeb waredjeb Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, here we just produce muons, but the other tracks are discarded, at least for now

chargedCandidate.setPdgId(13 * trackPtr.get()->charge());
resultCandidates->push_back(chargedCandidate);
}
resultCandidates->push_back(chargedCandidate);
}
}
}
Expand Down Expand Up @@ -478,6 +503,9 @@ void TICLCandidateProducer::fillDescriptions(edm::ConfigurationDescriptions &des
edm::ParameterSetDescription desc;
edm::ParameterSetDescription interpretationDesc;
interpretationDesc.addNode(edm::PluginDescription<TICLGeneralInterpretationPluginFactory>("type", "General", true));
edm::ParameterSetDescription inferenceDesc;
inferenceDesc.addNode(edm::PluginDescription<TracksterInferenceAlgoFactory>("type", "TracksterInferenceByPFN", true));
desc.add<edm::ParameterSetDescription>("pluginInferenceAlgoTracksterInferenceByPFN", inferenceDesc);
desc.add<edm::ParameterSetDescription>("interpretationDescPSet", interpretationDesc);
desc.add<std::vector<edm::InputTag>>("egamma_tracksters_collections", {edm::InputTag("ticlTracksterLinks")});
desc.add<std::vector<edm::InputTag>>("egamma_tracksterlinks_collections", {edm::InputTag("ticlTracksterLinks")});
Expand All @@ -498,6 +526,8 @@ void TICLCandidateProducer::fillDescriptions(edm::ConfigurationDescriptions &des
desc.add<std::string>("cutTk",
"1.48 < abs(eta) < 3.0 && pt > 1. && quality(\"highPurity\") && "
"hitPattern().numberOfLostHits(\"MISSING_OUTER_HITS\") < 5");
desc.add<bool>("regressionAndPid", true);
desc.add<std::string>("inferenceAlgo", "TracksterInferenceByPFN");
descriptions.add("ticlCandidateProducer", desc);
}

Expand Down
58 changes: 34 additions & 24 deletions RecoHGCal/TICL/plugins/TracksterLinkingbySkeletons.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ bool TracksterLinkingbySkeletons::areCompatible(const ticl::Trackster &myTrackst
const ticl::Trackster &otherTrackster,
const std::array<ticl::Vector, 3> &mySkeleton,
const std::array<ticl::Vector, 3> &otherSkeleton) {
float zVal_interface = rhtools_.getPositionLayer(rhtools_.lastLayerEE()).z();
float zVal_interface = std::abs(rhtools_.getPositionLayer(rhtools_.lastLayerEE()).z());

if (!isGoodTrackster(myTrackster, mySkeleton, min_num_lcs_, min_trackster_energy_, pca_quality_th_)) {
LogDebug("TracksterLinkingbySkeletons") << "Inner Trackster with energy " << myTrackster.raw_energy() << " Num LCs "
Expand All @@ -286,12 +286,25 @@ bool TracksterLinkingbySkeletons::areCompatible(const ticl::Trackster &myTrackst
<< myTrackster.vertices().size() << " IS GOOD " << std::endl;

float proj_distance = projective_distance(mySkeleton[1], otherSkeleton[1]);
auto isEE = mySkeleton[1].z() <= zVal_interface ? 0 : 1;
bool isInEE = std::abs(mySkeleton[1].z()) <= zVal_interface;
bool isOutEE = std::abs(otherSkeleton[1].z()) <= zVal_interface;
bool bothEE = (isInEE && isOutEE); // only check if they are aligned

// inEE --> !outEE --> True
// inEE --> outEE --> False
// !inEE --> outEE --> False
// !inEE --> !outEE --> True
bool isLoose = (!isOutEE);

if (bothEE) { //just don't try to link if two objects are in the CEE part (too much occupancy)
return false;
}

auto const max_distance_proj_sqr = computeParameter(myTrackster.raw_energy(),
lower_boundary_[isEE],
lower_distance_projective_sqr_[isEE],
upper_boundary_[isEE],
upper_distance_projective_sqr_[isEE]);
lower_boundary_[isLoose],
lower_distance_projective_sqr_[isLoose],
upper_boundary_[isLoose],
upper_distance_projective_sqr_[isLoose]);
bool areAlignedInProjectiveSpace = proj_distance < max_distance_proj_sqr;

LogDebug("TracksterLinkingbySkeletons")
Expand All @@ -310,13 +323,10 @@ bool TracksterLinkingbySkeletons::areCompatible(const ticl::Trackster &myTrackst
LogDebug("TracksterLinkingbySkeletons") << "\t\t Linked! Splitted components!" << std::endl;
return true;
}
//if is EE do not try to link more, PU occupancy is too high in this region
if (isEE) {
return false;
}

//if instead we are in the CE-H part of the detector, we can try to link more
// we measure the distance between the two closest nodes in the two skeletons
return checkClosestPoints(myTrackster, otherTrackster, mySkeleton, otherSkeleton, isEE);
return checkClosestPoints(myTrackster, otherTrackster, mySkeleton, otherSkeleton, isLoose);
}
} else {
if (otherTrackster.vertices().size() >= 3) {
Expand All @@ -327,22 +337,22 @@ bool TracksterLinkingbySkeletons::areCompatible(const ticl::Trackster &myTrackst
LogDebug("TracksterLinkingbySkeletons")
<< "\t Not aligned in projective space, check distance between closest points in the two skeletons "
<< std::endl;
if (checkClosestPoints(myTrackster, otherTrackster, mySkeleton, otherSkeleton, isEE)) {
if (checkClosestPoints(myTrackster, otherTrackster, mySkeleton, otherSkeleton, isLoose)) {
return true;
} else {
return checkCylinderAlignment(mySkeleton, otherSkeleton, isEE);
return checkCylinderAlignment(mySkeleton, otherSkeleton, isLoose);
}
}
} else {
return checkCylinderAlignment(mySkeleton, otherSkeleton, isEE);
return checkCylinderAlignment(mySkeleton, otherSkeleton, isLoose);
}
}
}

bool TracksterLinkingbySkeletons::checkCylinderAlignment(const std::array<ticl::Vector, 3> &mySkeleton,
const std::array<ticl::Vector, 3> &otherSkeleton,
int isEE) {
bool isInCyl = isInCylinder(mySkeleton, otherSkeleton, cylinder_radius_sqr_[isEE]);
int isLoose) {
bool isInCyl = isInCylinder(mySkeleton, otherSkeleton, cylinder_radius_sqr_[isLoose]);
if (isInCyl) {
LogDebug("TracksterLinkingbySkeletons") << "Two Points are in Cylinder " << isInCyl << " Linked! " << std::endl;
}
Expand All @@ -369,7 +379,7 @@ bool TracksterLinkingbySkeletons::checkClosestPoints(const ticl::Trackster &myTr
const ticl::Trackster &otherTrackster,
const std::array<ticl::Vector, 3> &mySkeleton,
const std::array<ticl::Vector, 3> &otherSkeleton,
int isEE) {
int isLoose) {
int myClosestPoint = -1;
int otherClosestPoint = -1;
float minDistance_z = std::numeric_limits<float>::max();
Expand All @@ -387,24 +397,24 @@ bool TracksterLinkingbySkeletons::checkClosestPoints(const ticl::Trackster &myTr

float d = projective_distance(mySkeleton[myClosestPoint], otherSkeleton[otherClosestPoint]);
auto const max_distance_proj_sqr_closest = computeParameter(myTrackster.raw_energy(),
lower_boundary_[isEE],
lower_distance_projective_sqr_closest_points_[isEE],
upper_boundary_[isEE],
upper_distance_projective_sqr_closest_points_[isEE]);
lower_boundary_[isLoose],
lower_distance_projective_sqr_closest_points_[isLoose],
upper_boundary_[isLoose],
upper_distance_projective_sqr_closest_points_[isLoose]);

LogDebug("TracksterLinkingbySkeletons")
<< "\t\t Distance between closest points " << d << " TH " << 10.f << " Z Distance " << minDistance_z << " TH "
<< max_distance_proj_sqr_closest << std::endl;

if (d < max_distance_proj_sqr_closest && minDistance_z < max_z_distance_closest_points_[isEE]) {
if (d < max_distance_proj_sqr_closest && minDistance_z < max_z_distance_closest_points_[isLoose]) {
LogDebug("TracksterLinkingbySkeletons") << "\t\t\t Linked! " << d << std::endl;
return true;
}

LogDebug("TracksterLinkingbySkeletons") << "Distance between closest point " << d << " Distance in z "
<< max_z_distance_closest_points_[isEE] << std::endl;
<< max_z_distance_closest_points_[isLoose] << std::endl;

return checkCylinderAlignment(mySkeleton, otherSkeleton, isEE);
return checkCylinderAlignment(mySkeleton, otherSkeleton, isLoose);
}

void TracksterLinkingbySkeletons::linkTracksters(
Expand Down
Loading