Skip to content

align HepMC3 plugin with HepMC2 plugin and add test configs#48999

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
mkirsano:alignplugin1
Oct 2, 2025
Merged

align HepMC3 plugin with HepMC2 plugin and add test configs#48999
cmsbuild merged 1 commit intocms-sw:masterfrom
mkirsano:alignplugin1

Conversation

@mkirsano
Copy link
Copy Markdown
Contributor

PR description:

The HeavyIon option was added to HepMC2 plugin, do the same for HepMC3 plugin
The added test configurations can be used in the standard validation of codes dealing with HepMC3

PR validation:

Checked compilation and run by test configurations in /test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Sep 26, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mkirsano for master.

It involves the following packages:

  • GeneratorInterface/Pythia8Interface (generators)

@cmsbuild, @lviliani, @mkirsano, @ssen, @theofil can you please review it and eventually sign? Thanks.
@alberto-sanchez this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mkirsano
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ede55f/48291/summary.html
COMMIT: 5c56e00
CMSSW: CMSSW_16_0_X_2025-09-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48999/48291/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 2024.0030001DAS Error

@mkirsano
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ede55f/48313/summary.html
COMMIT: 5c56e00
CMSSW: CMSSW_16_0_X_2025-09-28-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48999/48313/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 2024.0070001DAS Error
  • 2024.0060001DAS Error

@mkirsano
Copy link
Copy Markdown
Contributor Author

Tests are to be repared

@AdrianoDee
Copy link
Copy Markdown
Contributor

please test with #49020

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Oct 2, 2025

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ede55f/48415/summary.html
COMMIT: 5c56e00
CMSSW: CMSSW_16_0_X_2025-10-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48999/48415/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 2025.0010001, 2025.0000001, 2024.0070001, 2024.0050001, 2024.0040001, 2024.0030001, 2024.0020001, 2024.0010001, 2024.0000001, 2023.0020001 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • You potentially added 1574 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 28123 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3504568
  • DQMHistoTests: Total failures: 40302
  • DQMHistoTests: Total nulls: 114
  • DQMHistoTests: Total successes: 3464132
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 77.366 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 2024.0020001 ): 2.363 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2024.0020001 ): 2.320 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2024.0020001 ): 0.059 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 2024.0020001 ): 0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0030001,... ): 27.582 KiB PixelPhase1/Tracks
  • DQMHistoSizes: changed ( 2024.0030001 ): 6.617 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2024.0030001 ): 1.564 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2024.0030001 ): 0.164 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 2024.0030001 ): -0.090 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0050001 ): 7.090 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2024.0050001 ): ...
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mkirsano
Copy link
Copy Markdown
Contributor Author

mkirsano commented Oct 2, 2025

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Oct 2, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #49020

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 558050e into cms-sw:master Oct 2, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants