Skip to content

Gather more timing information about Framework startup#49001

Merged
cmsbuild merged 3 commits intocms-sw:masterfrom
Dr15Jones:additionalStartupSignals
Sep 28, 2025
Merged

Gather more timing information about Framework startup#49001
cmsbuild merged 3 commits intocms-sw:masterfrom
Dr15Jones:additionalStartupSignals

Conversation

@Dr15Jones
Copy link
Copy Markdown
Contributor

@Dr15Jones Dr15Jones commented Sep 26, 2025

PR description:

  • Capture additional timing information before Services have started
  • Added additional signals around major framework startup activities

PR validation:

Code compiles and framework unit tests pass.

resolves #48974

These are additional framework activities which begin before Services have started.
Provide signals around more of the framework startup work.
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Sep 26, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • FWCore/AbstractServices (core)
  • FWCore/Framework (core)
  • FWCore/ServiceRegistry (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@fwyzard, @makortel, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

please test

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

Dr15Jones commented Sep 26, 2025

I envision connecting these signals to the Tracer service as a separate pull request.

@makortel
Copy link
Copy Markdown
Contributor

AFAICT the {pre,post}ModulesInitializationFinalizedSignal_ are not called (yet?). I think we envisioned to enclose this function call

finishModulesInitialization(*moduleRegistry_, iRegistry, iESIndices, processBlockHelperBase, iProcessName);

to that signal region.

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49001/46196

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #49001 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

Please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 80KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a0199/48300/summary.html
COMMIT: 7229f7f
CMSSW: CMSSW_16_0_X_2025-09-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49001/48300/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3911484
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3911461
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Copy Markdown
Contributor

+core

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit d5f25f5 into cms-sw:master Sep 28, 2025
10 checks passed
@Dr15Jones Dr15Jones deleted the additionalStartupSignals branch October 6, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More signals to ActivityRegistry

4 participants