Skip to content

[15.0.X] add HLT vertexing resolution monitoring (by split vertex method)#49028

Merged
cmsbuild merged 2 commits intocms-sw:CMSSW_15_0_Xfrom
mmusich:pvresolution_for_HLT_15_0_X
Oct 1, 2025
Merged

[15.0.X] add HLT vertexing resolution monitoring (by split vertex method)#49028
cmsbuild merged 2 commits intocms-sw:CMSSW_15_0_Xfrom
mmusich:pvresolution_for_HLT_15_0_X

Conversation

@mmusich
Copy link
Copy Markdown
Contributor

@mmusich mmusich commented Sep 29, 2025

backport of #48980
backport of #49014

PR description:

From the original PR #48980

Add HLT vertexing resolution monitoring (using the "split vertex" method) for all the vertex types available at HLT (in both Run 3 and Phase-2).
This leverages the existing module PrimaryVertexResolution (which is lightly adapted to tolerate events in which the input colections are missing) and changes the configuration of both the DQM and Harvesting steps to be run in the @HLTMon sequence.

PR validation:

runTheMatrix.py -l 17034.0,29634.0,161.4 -t 4 -j 8 --ibeos -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #48980 + #49014 to the 2025 pp data-taking release.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Sep 29, 2025

A new Pull Request was created by @mmusich for CMSSW_15_0_X.

It involves the following packages:

  • DQM/TrackingMonitor (dqm)
  • DQMOffline/Configuration (dqm)
  • DQMOffline/Trigger (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @VinInn, @VourMa, @arossi83, @cericeci, @elusian, @fioriNTU, @idebruyn, @jandrea, @jhgoh, @missirol, @mmasciov, @mmusich, @mtosi, @richa2710, @rociovilar, @sroychow, @threus, @trocino this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Sep 29, 2025

cms-bot internal usage

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Sep 29, 2025

test parameters:

  • workflows = 161,161.02,161.03,161.1,161.2,161.3,161.4,162,162.02,162.03,162.1,162.2,162.3,162.4

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Sep 29, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8a020/48345/summary.html
COMMIT: fb5b640
CMSSW: CMSSW_15_0_X_2025-09-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49028/48345/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 162.02, 162.03, 162.0, 162.1, 162.2, 162.3, 162.4

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Sep 29, 2025

test parameters:

  • workflows = 161,161.02,161.03,161.1,161.2,161.3,161.4

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Sep 29, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8a020/48351/summary.html
COMMIT: fb5b640
CMSSW: CMSSW_15_0_X_2025-09-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49028/48351/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 18 lines to the logs
  • Reco comparison results: 26 differences found in the comparisons
  • DQMHistoTests: Total files compared: 57
  • DQMHistoTests: Total histograms compared: 4953751
  • DQMHistoTests: Total failures: 37
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4953694
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 165963.23099999994 KiB( 56 files compared)
  • DQMHistoSizes: changed ( 145.104,... ): 8735.531 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 24834.911,... ): 5821.711 KiB HLT/Vertexing
  • Checked 254 log files, 224 edm output root files, 57 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Copy Markdown
Contributor

@cms-sw/dqm-l2 Please have a look at this backport

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@mandrenguyen
Copy link
Copy Markdown
Contributor

merge
Let's get this in for the next 15_0_X.
Comparisons show only effects for Phase-2 DQM. It's already signed for master, so let's take for granted the sig on the back port.

@cmsbuild cmsbuild merged commit 367e8a0 into cms-sw:CMSSW_15_0_X Oct 1, 2025
9 checks passed
@mmusich mmusich deleted the pvresolution_for_HLT_15_0_X branch October 1, 2025 06:20
@gabrielmscampos
Copy link
Copy Markdown
Member

@mandrenguyen Are there any consequences on the bot if I sign after you? We'd like to get rid of the dqm-pending label.

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Oct 1, 2025

Are there any consequences on the bot if I sign after you? We'd like to get rid of the dqm-pending label.

@gabrielmscampos there are no consequences, you can sign post-facto.

@gabrielmscampos
Copy link
Copy Markdown
Member

+dqm

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Oct 1, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants