Implementing suggestions received in PR 49015

[saswatinandan]

PR description:

This PR is to implement the suggestions received in previous PR 49015.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49040/46251

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/SiStripCluster/interface/SiStripCluster.h modified in PR(s): SiStripClusterizer, an Alpaka port of the CUDA ClustersFromRawProducerGPU #47629
  • File DataFormats/SiStripCluster/src/SiStripCluster.cc modified in PR(s): update on strip approximate cluster #47367
  • File DataFormats/SiStripCluster/src/classes_def.xml modified in PR(s): update on strip approximate cluster #47367

[cmsbuild]

A new Pull Request was created by @saswatinandan for master.

It involves the following packages:

• DataFormats/SiStripCluster (reconstruction)
• RecoLocalTracker/SiStripClusterizer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @alesaggio, @echabert, @elusian, @felicepantaleo, @gbenelli, @gpetruc, @jlidrych, @missirol, @mmasciov, @mmusich, @mtosi, @robervalwalsh, @rovere, @threus, @yduhm this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mandrenguyen]

test parameters:

addpkg = DQM/Integration
workflows = 161,161.02,161.03,161.1,161.2,161.3,161.4,162,162.02,162.03,162.1,162.2,162.3,162.4

[mandrenguyen]

please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbf7fb/48404/summary.html
COMMIT: 69a1b09
CMSSW: CMSSW_16_0_X_2025-10-01-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49040/48404/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 161.02

----- Begin Fatal Exception 01-Oct-2025 19:01:02 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmofflineOnPAT_1_step'
   [2] Prefetching for module SingleTopTChannelLeptonDQM_miniAOD/'singleTopElectronMediumDQM_miniAOD'
   [3] Prefetching for module PATMuonSlimmer/'slimmedMuons'
   [4] Prefetching for module PATMuonSelector/'selectedPatMuons'
   [5] Prefetching for module PATMuonProducer/'patMuons'
   [6] Prefetching for module MuonProducer/'muons'
   [7] Prefetching for module MuonIdProducer/'muons1stStep'
   [8] Prefetching for module DuplicateListMerger/'generalTracks'
   [9] Prefetching for module TrackProducer/'mergedDuplicateTracks'
   [10] Prefetching for module DuplicateTrackMerger/'duplicateTrackCandidates'
   [11] Prefetching for module TrackCollectionMerger/'preDuplicateMergingGeneralTracks'
   [12] Prefetching for module TrackCollectionMerger/'earlyGeneralTracks'
   [13] Prefetching for module TrackProducer/'initialStepTracks'
   [14] Prefetching for module MkFitOutputConverter/'initialStepTrackCandidates'
   [15] Prefetching for module MkFitEventOfHitsProducer/'mkFitEventOfHits'
   [16] Prefetching for module MkFitSiPixelHitConverter/'mkFitSiPixelHits'
   [17] Prefetching for module SiPixelRecHitConverter/'siPixelRecHits'
   [18] Prefetching for module JetCoreClusterSplitter/'siPixelClusters'
   [19] Prefetching for module PrimaryVertexProducer/'firstStepPrimaryVerticesPreSplitting'
   [20] Prefetching for module TrackProducer/'initialStepTracksPreSplitting'
   [21] Prefetching for module MkFitOutputConverter/'initialStepTrackCandidatesPreSplitting'
   [22] Prefetching for module MkFitEventOfHitsProducer/'mkFitEventOfHitsPreSplitting'
   [23] Prefetching for module MkFitSiStripHitConverter/'mkFitSiStripHits'
   [24] Prefetching for module SiStripRecHitConverter/'siStripMatchedRecHits'
   [25] Calling method for module SiStripApprox2Clusters/'siStripClusters'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<TrackerGeometry,TrackerDigiGeometryRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

• 161.03

----- Begin Fatal Exception 01-Oct-2025 18:59:51 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'AODSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'AODSIMoutput'
   [3] Prefetching for module ClusterSummaryProducer/'clusterSummaryProducer'
   [4] Calling method for module SiStripApprox2Clusters/'siStripClusters'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<TrackerGeometry,TrackerDigiGeometryRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

• 162.03

----- Begin Fatal Exception 01-Oct-2025 18:59:46 CEST-----------------------
An exception of category 'InvalidESGetToken' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'AODSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'AODSIMoutput'
   [3] Prefetching for module ClusterSummaryProducer/'clusterSummaryProducer'
   [4] Calling method for module SiStripApprox2Clusters/'siStripClusters'
Exception Message:
Attempted to get data using an invalid token of type ESGetToken<TrackerGeometry,TrackerDigiGeometryRecord>.
Please call consumes to properly initialize the token.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 162.02

RelVals-INPUT

• 142.0142.0_RunHIPhysicsRawPrime2023A/step2_RunHIPhysicsRawPrime2023A.log

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49040/46254

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/SiStripCluster/interface/SiStripCluster.h modified in PR(s): SiStripClusterizer, an Alpaka port of the CUDA ClustersFromRawProducerGPU #47629
  • File DataFormats/SiStripCluster/src/SiStripCluster.cc modified in PR(s): update on strip approximate cluster #47367
  • File DataFormats/SiStripCluster/src/classes_def.xml modified in PR(s): update on strip approximate cluster #47367

[cmsbuild]

Pull request #49040 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

[mandrenguyen]

please test

[cmsbuild]

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbf7fb/48408/summary.html
COMMIT: de7212d
CMSSW: CMSSW_16_0_X_2025-10-01-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49040/48408/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 63
• DQMHistoTests: Total histograms compared: 5532776
• DQMHistoTests: Total failures: 36
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 5532720
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 62 files compared)
• Checked 282 log files, 248 edm output root files, 63 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[ftenchini]

+1

[mandrenguyen]

What is the plan to back port this? Do you want to make a new back port PR? Or combine into the open 15_1_X PR?

[silviodonato]

@mandrenguyen all PRs:

• Modification of existing rawprime version of SiStripApproxCluster #49015
• [15_1_X] Modification of existing rawprime version of SiStripApproxCluster #49036
• Implementing suggestions received in PR 49015 #49040
  are pulling saswatinandan:HI_test_with_v1.
  So the commits included in this PR (Implementing suggestions received in PR 49015 #49040) are automatically included in the backport [15_1_X] Modification of existing rawprime version of SiStripApproxCluster #49036 (see screenshot taken from the backport PR)

[mmusich]

type ngt