Clamp fakePixels to maxFakesInModule [15.1.x]

[fwyzard]

PR description:

After running the Pixel digi morphing algorithm, clamp fakePixels to maxFakesInModule to avoid overflowing the histogram container.

PR validation:

Run on top of the reproducer at #49125 without any crashes.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #49142 to 15.1.x.

[fwyzard]

type bugfix

[fwyzard]

backport #49142

[cmsbuild]

A new Pull Request was created by @fwyzard for CMSSW_15_1_X.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dkotlins, @elusian, @felicepantaleo, @ferencek, @gpetruc, @mmasciov, @mmusich, @mroguljic, @mtosi, @rovere, @threus, @tsusa, @tvami this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Clamp fakePixels to maxFakesInModule #49142

[cmsbuild]

cms-bot internal usage

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f145c/48631/summary.html
COMMIT: b9732d1
CMSSW: CMSSW_15_1_X_2025-10-12-2300/el8_amd64_gcc12
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49143/48631/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4124047
• DQMHistoTests: Total failures: 35
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4123992
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 241 differences found in the comparisons
• DQMHistoTests: Total files compared: 11
• DQMHistoTests: Total histograms compared: 146188
• DQMHistoTests: Total failures: 27562
• DQMHistoTests: Total nulls: 11
• DQMHistoTests: Total successes: 118615
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
• Checked 42 log files, 45 edm output root files, 11 DQM output files
• TriggerResults: no differences found

AMD_W7900 Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 240 differences found in the comparisons
• DQMHistoTests: Total files compared: 11
• DQMHistoTests: Total histograms compared: 146188
• DQMHistoTests: Total failures: 26653
• DQMHistoTests: Total nulls: 11
• DQMHistoTests: Total successes: 119524
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
• Checked 42 log files, 45 edm output root files, 11 DQM output files
• TriggerResults: no differences found

NVIDIA_H100 Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 241 differences found in the comparisons
• DQMHistoTests: Total files compared: 11
• DQMHistoTests: Total histograms compared: 146188
• DQMHistoTests: Total failures: 28891
• DQMHistoTests: Total nulls: 8
• DQMHistoTests: Total successes: 117289
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
• Checked 42 log files, 45 edm output root files, 11 DQM output files
• TriggerResults: no differences found

NVIDIA_L40S Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 191 differences found in the comparisons
• DQMHistoTests: Total files compared: 11
• DQMHistoTests: Total histograms compared: 146188
• DQMHistoTests: Total failures: 31630
• DQMHistoTests: Total nulls: 11
• DQMHistoTests: Total successes: 114547
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
• Checked 42 log files, 45 edm output root files, 11 DQM output files
• TriggerResults: no differences found

NVIDIA_T4 Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 192 differences found in the comparisons
• DQMHistoTests: Total files compared: 11
• DQMHistoTests: Total histograms compared: 146188
• DQMHistoTests: Total failures: 34217
• DQMHistoTests: Total nulls: 12
• DQMHistoTests: Total successes: 111959
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
• Checked 42 log files, 45 edm output root files, 11 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1