Define RefProdVector for HGCRecHitCollection and PFRecHitCollection by Electricks94 · Pull Request #49190 · cms-sw/cmssw

Electricks94 · 2025-10-20T12:04:05Z

This PR adds RefProdVector.h to DataFormats/Common as an alias for std::vector<RefProd<T>>. Then RefProdVectors for PFRecHitCollection and HGCRecHitCollection are introduced as product of the RecHitMapProducer and comsumed by other producers to create a MultiSpan on the fly. This workflow has two advantages

Memory copies are avoided
The order of the Collections is defined in the RefProdVector at one location. Like this later producers can rely on the order (see issue 48526 )

PR validation:

Workflow 29688.0

FYI @felicepantaleo @leobeltra

cmsbuild · 2025-10-20T12:04:35Z

cms-bot internal usage

cmsbuild · 2025-10-20T12:06:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49190/46489

Found files with invalid states:
- CommonTools/RecoAlgos/interface/MultiCollectionManager.h:
  - Added: 0df46f4
  - Modified: 67999a1
  - Deleted: aeb93dd
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoLocalCalo/HGCalRecProducers/plugins/RecHitMapProducer.cc modified in PR(s): Bugfixes to TICL-barrel #48565

cmsbuild · 2025-10-20T12:06:23Z

A new Pull Request was created by @Electricks94 for master.

It involves the following packages:

DataFormats/Common (core)
DataFormats/HGCRecHit (reconstruction)
RecoLocalCalo/Configuration (reconstruction)
RecoLocalCalo/HGCalRecProducers (reconstruction)
Validation/Configuration (dqm, simulation)

@Dr15Jones, @civanch, @cmsbuild, @ctarricone, @gabrielmscampos, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @nothingface0, @rseidita, @smuzaffar can you please review it and eventually sign? Thanks.
@IzaakWN, @ReyerBand, @apsallid, @bsunanda, @cseez, @denizsun, @edjtscott, @felicepantaleo, @hatakeyamak, @lecriste, @lgray, @makortel, @missirol, @mmusich, @pfs, @rovere, @salimcerci, @sameasy, @sethzenz, @thomreis, @vandreev11, @wang0jin, @wddgit, @youyingli this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

felicepantaleo · 2025-10-20T12:15:20Z

@cmsbuild please test

cmsbuild · 2025-10-20T12:24:13Z

-1

Failed Tests: Build ClangBuild
Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2382bf/48727/summary.html
COMMIT: 3bf019b
CMSSW: CMSSW_16_0_X_2025-10-19-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49190/48727/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_16_0_X_2025-10-19-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_16_0_X_2025-10-19-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-19-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/pcre/8.43-6d98fda3bfd074ebb583e2d6a2c75d25/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/boost/1.80.0-f5051ff020fe9f6f1a74162002ac1ea0/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/bz2lib/1.0.6-d113e1c6278c07eeaff5f84db9548446/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/cppunit/1.15.x-d4385f8b2638355b326bc1769bca68f4/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/libuuid/2.34-5ba7a8abfc0c5fecdc448cca360c25ff/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/lcg/root/6.32.13-2ba92f62034c9fcccda180513e8d0814/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/tbb/v2022.0.0-ede4a930df4abec602e96e3f3ad15914/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/xz/5.6.4-b9c4ffbc390ed320a5d57fd552e29a05/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/zlib/1.2.13-589f6bb51bbeba38a7adf5a10ea8a093/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/catch2/3.11.0-2e42f64598f571f0c3579816b5de560c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/md5/1.0.0-26057075013e190e56dad37d35219376/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/tinyxml2/6.2.0-67924ead96ecb4e69aad321b767979a5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/DataFormats/Common/test/testDataFormatsCommonCatch2/test_catch2_MultiCollection.cpp.d src/DataFormats/Common/test/test_catch2_MultiCollection.cpp -o tmp/el8_amd64_gcc13/src/DataFormats/Common/test/testDataFormatsCommonCatch2/test_catch2_MultiCollection.cpp.o
>> Compiling  src/DataFormats/Common/test/test_catch2_MultiSpan.cpp
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_16_0_X_2025-10-19-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_16_0_X_2025-10-19-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-19-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/pcre/8.43-6d98fda3bfd074ebb583e2d6a2c75d25/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/boost/1.80.0-f5051ff020fe9f6f1a74162002ac1ea0/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/bz2lib/1.0.6-d113e1c6278c07eeaff5f84db9548446/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/cppunit/1.15.x-d4385f8b2638355b326bc1769bca68f4/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/libuuid/2.34-5ba7a8abfc0c5fecdc448cca360c25ff/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/lcg/root/6.32.13-2ba92f62034c9fcccda180513e8d0814/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/tbb/v2022.0.0-ede4a930df4abec602e96e3f3ad15914/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/xz/5.6.4-b9c4ffbc390ed320a5d57fd552e29a05/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/zlib/1.2.13-589f6bb51bbeba38a7adf5a10ea8a093/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/catch2/3.11.0-2e42f64598f571f0c3579816b5de560c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/md5/1.0.0-26057075013e190e56dad37d35219376/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/tinyxml2/6.2.0-67924ead96ecb4e69aad321b767979a5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/DataFormats/Common/test/testDataFormatsCommonCatch2/test_catch2_MultiSpan.cpp.d src/DataFormats/Common/test/test_catch2_MultiSpan.cpp -o tmp/el8_amd64_gcc13/src/DataFormats/Common/test/testDataFormatsCommonCatch2/test_catch2_MultiSpan.cpp.o
>> Compiling  src/DataFormats/Common/test/test_catch2_OwnVector.cpp
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_16_0_X_2025-10-19-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_16_0_X_2025-10-19-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-19-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/pcre/8.43-6d98fda3bfd074ebb583e2d6a2c75d25/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/boost/1.80.0-f5051ff020fe9f6f1a74162002ac1ea0/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/bz2lib/1.0.6-d113e1c6278c07eeaff5f84db9548446/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/cppunit/1.15.x-d4385f8b2638355b326bc1769bca68f4/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/libuuid/2.34-5ba7a8abfc0c5fecdc448cca360c25ff/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/lcg/root/6.32.13-2ba92f62034c9fcccda180513e8d0814/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/tbb/v2022.0.0-ede4a930df4abec602e96e3f3ad15914/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/xz/5.6.4-b9c4ffbc390ed320a5d57fd552e29a05/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/zlib/1.2.13-589f6bb51bbeba38a7adf5a10ea8a093/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/catch2/3.11.0-2e42f64598f571f0c3579816b5de560c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/md5/1.0.0-26057075013e190e56dad37d35219376/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/tinyxml2/6.2.0-67924ead96ecb4e69aad321b767979a5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/DataFormats/Common/test/testDataFormatsCommonCatch2/test_catch2_OwnVector.cpp.d src/DataFormats/Common/test/test_catch2_OwnVector.cpp -o tmp/el8_amd64_gcc13/src/DataFormats/Common/test/testDataFormatsCommonCatch2/test_catch2_OwnVector.cpp.o
src/DataFormats/Common/test/test_catch2_MultiCollection.cpp:6:10: fatal error: catch.hpp: No such file or directory
    6 | #include 
      |          ^~~~~~~~~~~
compilation terminated.
>> Compiling  src/DataFormats/Common/test/test_catch2_Ref.cpp
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_16_0_X_2025-10-19-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_16_0_X_2025-10-19-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/cms/cmssw/CMSSW_16_0_X_2025-10-19-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/pcre/8.43-6d98fda3bfd074ebb583e2d6a2c75d25/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/boost/1.80.0-f5051ff020fe9f6f1a74162002ac1ea0/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/bz2lib/1.0.6-d113e1c6278c07eeaff5f84db9548446/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/cppunit/1.15.x-d4385f8b2638355b326bc1769bca68f4/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/libuuid/2.34-5ba7a8abfc0c5fecdc448cca360c25ff/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/lcg/root/6.32.13-2ba92f62034c9fcccda180513e8d0814/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/tbb/v2022.0.0-ede4a930df4abec602e96e3f3ad15914/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/xz/5.6.4-b9c4ffbc390ed320a5d57fd552e29a05/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/zlib/1.2.13-589f6bb51bbeba38a7adf5a10ea8a093/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/catch2/3.11.0-2e42f64598f571f0c3579816b5de560c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/md5/1.0.0-26057075013e190e56dad37d35219376/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02912/el8_amd64_gcc13/external/tinyxml2/6.2.0-67924ead96ecb4e69aad321b767979a5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/DataFormats/Common/test/testDataFormatsCommonCatch2/test_catch2_Ref.cpp.d src/DataFormats/Common/test/test_catch2_Ref.cpp -o tmp/el8_amd64_gcc13/src/DataFormats/Common/test/testDataFormatsCommonCatch2/test_catch2_Ref.cpp.o

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

>> Creating project symlinks
>> Entering Package DataFormats/Common
>> Entering Package DataFormats/HGCRecHit
>> Entering Package RecoLocalCalo/HGCalRecProducers
>> Compile sequence completed for CMSSW CMSSW_16_0_X_2025-10-19-2300
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
Command exited with non-zero status 1
	Command being timed: "scram build -k -j 32 COMPILER=llvm compile BUILD_LOG=yes"
	User time (seconds): 437.95
	System time (seconds): 58.06
	Percent of CPU this job got: 811%

Dr15Jones · 2025-10-20T12:26:21Z

@Electricks94 the simplest fix is to change to catch2/catch_all.hpp and compile using a very recent IB.

cmsbuild · 2025-10-29T21:37:13Z

Pull request #49190 was updated.

fwyzard · 2025-10-29T23:17:51Z


 from Configuration.ProcessModifiers.ticl_barrel_cff import ticl_barrel
-ticl_barrel.toModify(recHitMapProducer, hits = hits, hgcalOnly = False) 
+ticl_barrel.toModify(recHitMapProducer, hits = hits, hgcalOnly = False) 


missing EOL

cmsbuild · 2025-10-30T07:52:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49190/46608

There are other open Pull requests which might conflict with changes you have proposed:
- File SimCalorimetry/HGCalAssociatorProducers/plugins/AllHitToTracksterAssociatorsProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/AllTracksterToSimTracksterAssociatorsByHitsProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/HitToSimClusterCaloParticleAssociatorProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/HitToSimClusterCaloParticleAssociatorProducer.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319

cmsbuild · 2025-10-30T07:52:33Z

Pull request #49190 was updated.

Electricks94 · 2025-10-30T07:55:55Z

type ngt

felicepantaleo · 2025-10-30T08:10:22Z

hi @Electricks94 , I would prefer that you define the MultiCollection<T> as
std::vector<edm::RefProd<T>>, rather than using overly specialized names for each kind of collection.

cmsbuild · 2025-10-30T09:36:05Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49190/46614

There are other open Pull requests which might conflict with changes you have proposed:
- File SimCalorimetry/HGCalAssociatorProducers/plugins/AllHitToTracksterAssociatorsProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/AllTracksterToSimTracksterAssociatorsByHitsProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/HitToSimClusterCaloParticleAssociatorProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/HitToSimClusterCaloParticleAssociatorProducer.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49190/46614/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49190/46614/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2025-10-30T09:47:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49190/46615

There are other open Pull requests which might conflict with changes you have proposed:
- File SimCalorimetry/HGCalAssociatorProducers/plugins/AllHitToTracksterAssociatorsProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/AllTracksterToSimTracksterAssociatorsByHitsProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/HitToSimClusterCaloParticleAssociatorProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/HitToSimClusterCaloParticleAssociatorProducer.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319

cmsbuild · 2025-10-30T09:47:27Z

Pull request #49190 was updated.

Electricks94 · 2025-10-30T11:45:57Z

+  const auto hits = iEvent.get(hitsToken_);
+  for (std::size_t index = 0; const auto& hgcRecHitCollection : hits) {
+    if (hgcRecHitCollection->empty()) {
+      edm::LogWarning("AllHitToTracksterAssociatorsProducer") << "HGCRecHitCollections #" << index << " is not valid.";


The producers, that have been adapted in the PR contain a few debug evaluations. They have not beed guarded by NDEBUG so far, should this be done?

Guarding with NDEBUG won't have much effect in practice because by default CMSSW is built with NDEBUG defined.

makortel · 2025-10-30T21:35:43Z

+
+namespace edm {
+  template <typename T>
+  using MultiCollection = std::vector<edm::RefProd<T>>;


Repeating #49190 (comment) I still find the MultiCollection not to be a very descriptive name. How about e.g. RefProdVector?

makortel · 2025-10-30T21:37:33Z

I'd still ask a test for a case where (at least) one of the RefProd elements in the MultiCollection is Null or not Available when passed to MultiSpan constructor.

cmsbuild · 2025-10-31T09:32:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49190/46629

Found files with invalid states:
- DataFormats/Common/interface/MultiCollection.h:
  - Added: e52d9b6
  - Modified: 3b7f5fe
  - Deleted: dbe55da
There are other open Pull requests which might conflict with changes you have proposed:
- File SimCalorimetry/HGCalAssociatorProducers/plugins/AllHitToTracksterAssociatorsProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/AllTracksterToSimTracksterAssociatorsByHitsProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/HitToSimClusterCaloParticleAssociatorProducer.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File SimCalorimetry/HGCalAssociatorProducers/plugins/HitToSimClusterCaloParticleAssociatorProducer.h modified in PR(s): Add directories for TICL-EGM code development #48319
- File Validation/HGCalValidation/interface/HGCalValidator.h modified in PR(s): Add directories for TICL-EGM code development #48319

cmsbuild · 2025-10-31T09:33:18Z

Pull request #49190 was updated.

Electricks94 · 2025-10-31T09:37:59Z

I'd still ask a test for a case where (at least) one of the RefProd elements in the MultiCollection is Null or not Available when passed to MultiSpan constructor.

Sorry about that, I forgot to add the comment after the bigger changes to the former MultiCollection. I added a nullptr to the test_catch2_MultiSpan and check for isNonnull when constructing the MultiSpan. Similarly to the add function I just skip the RefProds that are nullptr. Would it be reasonable to add a warning here?

makortel · 2025-10-31T20:17:21Z

Thanks!

Similarly to the add function I just skip the RefProds that are nullptr.

I guess a Null, i.e. default-constructed, RefProd makes sense to be ignored in the same way as empty span.

Ideally a test for non-Available would be nice, but mocking that case would be a bit complicated, and should throw an exception, so maybe we can live without.

Would it be reasonable to add a warning here?

I don't think a warning would be useful because nobody looks at them (except possibly during local development). Or in other words, behavior should be such that it makes sense without having look at logs.

makortel · 2025-10-31T20:17:28Z

@cmsbuild, please test

cmsbuild · 2025-10-31T22:08:04Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2382bf/49127/summary.html
COMMIT: dbe55da
CMSSW: CMSSW_16_0_X_2025-10-31-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49190/49127/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 160 lines to the logs
Reco comparison results: 15 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3939953
DQMHistoTests: Total failures: 58
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3939875
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

gabrielmscampos · 2025-11-10T08:15:17Z

+dqm

jfernan2 · 2025-11-10T08:36:23Z

+1

makortel · 2025-11-10T20:20:01Z

+core

(I read the non-core code only superficially)

civanch · 2025-11-12T10:17:00Z

+1

cmsbuild · 2025-11-12T10:17:25Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-11-12T16:34:01Z

+1

cmsbuild added this to the CMSSW_16_0_X milestone Oct 20, 2025

cmsbuild added reconstruction-pending simulation-pending dqm-pending core-pending pending-signatures tests-pending orp-pending code-checks-pending changes-dataformats labels Oct 20, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 20, 2025

cmsbuild added tests-started and removed tests-pending labels Oct 20, 2025

cmsbuild added tests-rejected and removed tests-started labels Oct 20, 2025

cmsbuild added l1-pending hlt-pending alca-pending fastsim-pending db-pending generators-pending and removed tests-rejected code-checks-approved labels Oct 20, 2025

fwyzard reviewed Oct 29, 2025

View reviewed changes

Define MultiCollections in RecHitMapProducer

ac427f6

Introduce MultiCollection as alias for vector<RefProd<T>>

e52d9b6

Added better debug messages

3b7f5fe

Electricks94 commented Oct 30, 2025

View reviewed changes

makortel reviewed Oct 30, 2025

View reviewed changes

Changed MultiCollection to RefProfVector

dbe55da

cmsbuild mentioned this pull request Nov 12, 2025

Updating fillDescriptions in RecoBTag area #49379

Merged

Electricks94 mentioned this pull request Nov 13, 2025

avoid relying on the collections order and maintain flexibility in RecHitMapProducer.cc #48526

Closed

Conversation

Electricks94 commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 20, 2025

Uh oh!

cmsbuild commented Oct 20, 2025

Uh oh!

felicepantaleo commented Oct 20, 2025

Uh oh!

cmsbuild commented Oct 20, 2025

Build

Clang Build

Uh oh!

Dr15Jones commented Oct 20, 2025

Uh oh!

cmsbuild commented Oct 29, 2025

Uh oh!

fwyzard Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Oct 30, 2025

Uh oh!

cmsbuild commented Oct 30, 2025

Uh oh!

Electricks94 commented Oct 30, 2025

Uh oh!

felicepantaleo commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 30, 2025

Uh oh!

cmsbuild commented Oct 30, 2025

Uh oh!

cmsbuild commented Oct 30, 2025

Uh oh!

Electricks94 Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

makortel Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

makortel Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

makortel commented Oct 30, 2025

Uh oh!

cmsbuild commented Oct 31, 2025

Uh oh!

cmsbuild commented Oct 31, 2025

Uh oh!

Electricks94 commented Oct 31, 2025

Uh oh!

makortel commented Oct 31, 2025

Uh oh!

makortel commented Oct 31, 2025

Uh oh!

cmsbuild commented Oct 31, 2025

Comparison Summary

Uh oh!

gabrielmscampos commented Nov 10, 2025

Uh oh!

jfernan2 commented Nov 10, 2025

Uh oh!

makortel commented Nov 10, 2025

Uh oh!

civanch commented Nov 12, 2025

Uh oh!

cmsbuild commented Nov 12, 2025

Uh oh!

mandrenguyen commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Electricks94 commented Oct 20, 2025 •

edited

Loading

cmsbuild commented Oct 20, 2025 •

edited

Loading

felicepantaleo commented Oct 30, 2025 •

edited

Loading