Run Scouting DQM in RelVals (+ change in JME scouting DQM sequence)#49350
Run Scouting DQM in RelVals (+ change in JME scouting DQM sequence)#49350silviodonato wants to merge 0 commit intocms-sw:masterfrom
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49350/46733
|
|
A new Pull Request was created by @silviodonato for master. It involves the following packages:
@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
FYI @patinkaew @etzovara @cms-sw/hlt-l2 with the fix in the JME DQM scouting sequence we might not need anymore of the customization function #49084 . Using Task, the crashing module does not run in events without scouting objects |
|
-1 Failed Tests: RelVals-INPUT Failed RelVals-INPUT |
cmsbuild
added
tests-rejected
tests-pending
code-checks-pending
and removed
tests-started
tests-rejected
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49350/46737
|
|
Pull request #49350 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again. |
| DQMOfflineTriggerWithScouting = cms.Sequence( triggerOfflineDQMSource + hltScoutingDqmOffline ) | ||
| from Configuration.Eras.Modifier_run3_common_cff import run3_common | ||
| ## replace DQMOfflineTrigger with DQMOfflineTriggerWithScouting since Run-3 | ||
| run3_common.toReplaceWith( DQMOfflineTrigger, DQMOfflineTriggerWithScouting ) |
There was a problem hiding this comment.
does this bring in the change also for phase2?
There was a problem hiding this comment.
yes, phase2 include run3_common (Run3_noMkFit):
https://github.com/cms-sw/cmssw/blob/master/Configuration/Eras/python/Era_Phase2_cff.py
https://github.com/cms-sw/cmssw/blob/master/Configuration/Eras/python/Era_Run3_noMkFit_cff.py
https://github.com/cms-sw/cmssw/blob/master/Configuration/Eras/python/Era_Run3_cff.py
There was a problem hiding this comment.
OK, so please let's not do it :)
| jetDQMAnalyzerSequenceScouting) | ||
| # We must keep correctors in Task to skip their execution when in events without scouting objects | ||
| jetMETDQMOfflineSourceScouting = cms.Sequence(jetDQMAnalyzerSequenceScouting, | ||
| jetPreDQMTaskScouting, |
There was a problem hiding this comment.
can you please indent it here better?
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49350/46747
|
|
Pull request #49350 was updated. @Martin-Grunewald, @cmsbuild, @ctarricone, @gabrielmscampos, @mmusich, @nothingface0, @rseidita can you please check and sign again. |
silviodonato
force-pushed
the
ScoutingDQMRelVals2
branch
from
1d68aa2 to
9bfeb16
Compare
|
Moved to #49358 |
3 participants
PR description:
DQM Offline for Scouting was added by #47235.
It was activated in PromptReco at T0 only for
ScoutingPFMonitordataset by dmwm/T0#5053, specifically by adding@hltScoutingtodqm_sequencesin ProdOfflineConfiguration.py.As discussed at the trigger review, it would be useful to have these DQM plots also in RelVals -- and also in AlCaVal -- to monitor the performance of HLT/Scouting objects.
Note: Currently Scouting DQM requires scouting object to run (otherwise it will crash). This PR changes the JME scouting DQM (
jetMETDQMOfflineSourceScouting) to use Task. In this way the crashing module (ak4PFScoutingL1FastjetCorrector) will run only when requested by the JME scouting module (jetDQMAnalyzerSequenceScouting), ie. when scouting objects exists.This PR simply adds scouting DQM to the trigger DQM sequence.
PR validation:
I'm having some problems with the validation (#49331). I would like to check that all corner cases are covered (in particular I suspect that a re-reco of a non-scouting dataset might have problems)
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be defined