[RECONSTRUCTION] [LLVM21] Apply clang-tidy changes

[smuzaffar]

This PR suggests to apply the clang-tidy changes proposed by LLVM21 ( from CLANG_X IB).

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49496/46979

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/JetReco/src/CaloJet.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File DataFormats/JetReco/src/GenJet.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File DataFormats/JetReco/src/PFJet.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File DataFormats/JetReco/src/TrackJet.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File DataFormats/ParticleFlowCandidate/src/PFCandidate.cc modified in PR(s): PFCandidate no longer inherits from CompositeCandidate #38999, [Do not merge] LLVM21 clang-tidy changes #49297
  • File DataFormats/TauReco/src/PFTauDecayMode.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File EventFilter/CSCRawToDigi/src/CSCCFEBData.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File JetMETCorrections/Modules/plugins/JetResolutionDemo.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File MagneticField/GeomBuilder/src/bLayer.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoBTag/SecondaryVertex/plugins/TemplatedSecondaryVertexProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372, [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoEcal/EgammaClusterAlgos/src/HybridClusterAlgo.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoEcal/EgammaClusterProducers/src/EcalBasicClusterLocalContCorrection.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoEcal/EgammaClusterProducers/src/EcalDigiSelector.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoEcal/EgammaClusterProducers/src/UncleanSCRecoveryProducer.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoEcal/EgammaClusterProducers/src/UnifiedSCCollectionProducer.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoEcal/EgammaCoreTools/plugins/EcalClusterCrackCorrection.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoEgamma/EgammaElectronProducers/plugins/LowPtGsfElectronSeedValueMapsProducer.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoEgamma/EgammaIsolationAlgos/src/ElectronTkIsolation.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoEgamma/EgammaPhotonAlgos/src/ConversionVertexFinder.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoEgamma/EgammaPhotonProducers/src/ConversionTrackMerger.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoEgamma/EgammaTools/src/EcalClusterLocal.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoHGCal/TICL/plugins/TICLDumper.cc modified in PR(s): Add directories for TICL-EGM code development #48319, [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoHGCal/TICL/plugins/TracksterLinkingbySkeletons.cc modified in PR(s): Add directories for TICL-EGM code development #48319, [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoHI/HiJetAlgos/plugins/HiPuRhoProducer.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoJets/JetAlgorithms/src/CATopJetAlgorithm.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoJets/JetAlgorithms/src/CATopJetHelper.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoJets/JetProducers/src/JetMatchingTools.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoJets/JetProducers/src/PileupJPTJetIdAlgo.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoLocalCalo/CaloTowersCreator/src/CaloTowersCreationAlgo.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoLocalCalo/EcalRecProducers/plugins/EcalUncalibRecHitWorkerMultiFit.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoLocalCalo/HcalLaserReco/src/HcalLaserUnpacker.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoLocalMuon/CSCEfficiency/src/CSCEfficiency.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoLocalMuon/DTSegment/src/DTCombinatorialPatternReco4D.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoLuminosity/LumiProducer/plugins/CMSRunSummary2DB.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoMET/METPUSubtraction/src/PFMETAlgorithmMVA.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoMuon/MuonIdentification/plugins/MuonIdProducer.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372, [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoMuon/MuonSeedGenerator/src/RPCSeedGenerator.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoMuon/TrackingTools/src/MuonTrajectoryUpdator.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoPPS/Local/plugins/CTPPSPixelLocalTrackProducer.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoPPS/Local/src/RPixPlaneCombinatoryTracking.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoParticleFlow/PFClusterProducer/plugins/Basic2DGenericPFlowPositionCalc.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoParticleFlow/PFClusterProducer/plugins/LocalMaximumSeedFinder.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoParticleFlow/PFProducer/src/MLPFModel.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoParticleFlow/PFProducer/src/PFEGammaAlgo.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoParticleFlow/PFProducer/src/PFMuonAlgo.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoParticleFlow/PFTracking/plugins/PFElecTkProducer.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoParticleFlow/PFTracking/src/ConvBremPFTrackFinder.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoParticleFlow/PFTracking/src/PFDisplacedVertexFinder.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoParticleFlow/PFTracking/src/PFDisplacedVertexHelper.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoParticleFlow/PFTracking/src/PFTrackTransformer.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoTauTag/RecoTau/plugins/RecoTauPiZeroStripPlugin2.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoTauTag/RecoTau/plugins/RecoTauPiZeroStripPlugin3.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoTracker/DeDx/src/DeDxTools.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoTracker/FinalTrackSelectors/plugins/TrackerTrackHitFilter.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoTracker/PixelTrackFitting/src/PixelTrackBuilder.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoTracker/SingleTrackPattern/src/CRackTrajectoryBuilder.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoTracker/SpecialSeedGenerators/src/SeedFromGenericPairOrTriplet.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoTracker/TkDetLayers/src/PixelBarrelLayerBuilder.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoTracker/TkSeedGenerator/plugins/DeepCoreSeedGenerator.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoTracker/TrackProducer/src/DAFTrackProducerAlgorithm.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoVertex/KinematicFit/plugins/KineExample.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoVertex/LinearizationPointFinders/src/CrossingPtBasedLinearizationPointFinder.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoVertex/PrimaryVertexProducer/src/AdaptiveChisquarePrimaryVertexFitter.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File RecoVertex/PrimaryVertexProducer/src/DAClusterizerInZ_vect.cc modified in PR(s): Parallelized offline vertexing reconstruction #46663, [Do not merge] LLVM21 clang-tidy changes #49297
  • File TrackingTools/TrackRefitter/src/TrackTransformerForGlobalCosmicMuons.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
  • File TrackingTools/TrajectoryState/src/PerigeeConversions.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• DataFormats/JetReco (reconstruction)
• DataFormats/ParticleFlowCandidate (reconstruction)
• DataFormats/TauReco (reconstruction)
• EventFilter/CSCRawToDigi (reconstruction)
• JetMETCorrections/Modules (reconstruction)
• MagneticField/GeomBuilder (reconstruction)
• RecoBTag/SecondaryVertex (reconstruction)
• RecoEcal/EgammaClusterAlgos (reconstruction)
• RecoEcal/EgammaClusterProducers (reconstruction)
• RecoEcal/EgammaCoreTools (reconstruction)
• RecoEgamma/EgammaElectronProducers (reconstruction)
• RecoEgamma/EgammaIsolationAlgos (reconstruction)
• RecoEgamma/EgammaPhotonAlgos (reconstruction)
• RecoEgamma/EgammaPhotonProducers (reconstruction)
• RecoEgamma/EgammaTools (reconstruction)
• RecoHGCal/TICL (reconstruction)
• RecoHI/HiJetAlgos (reconstruction)
• RecoJets/JetAlgorithms (reconstruction)
• RecoJets/JetProducers (reconstruction)
• RecoLocalCalo/CaloTowersCreator (reconstruction)
• RecoLocalCalo/EcalRecProducers (reconstruction)
• RecoLocalCalo/HcalLaserReco (reconstruction)
• RecoLocalMuon/CSCEfficiency (reconstruction)
• RecoLocalMuon/DTSegment (reconstruction)
• RecoLuminosity/LumiProducer (reconstruction)
• RecoMET/METPUSubtraction (reconstruction)
• RecoMuon/MuonIdentification (reconstruction)
• RecoMuon/MuonSeedGenerator (reconstruction)
• RecoMuon/TrackingTools (reconstruction)
• RecoPPS/Local (reconstruction)
• RecoParticleFlow/PFClusterProducer (reconstruction)
• RecoParticleFlow/PFProducer (reconstruction)
• RecoParticleFlow/PFTracking (reconstruction)
• RecoTauTag/RecoTau (reconstruction)
• RecoTracker/DeDx (reconstruction)
• RecoTracker/FinalTrackSelectors (reconstruction)
• RecoTracker/PixelTrackFitting (reconstruction)
• RecoTracker/SingleTrackPattern (reconstruction)
• RecoTracker/SpecialSeedGenerators (reconstruction)
• RecoTracker/TkDetLayers (reconstruction)
• RecoTracker/TkSeedGenerator (reconstruction)
• RecoTracker/TrackProducer (reconstruction)
• RecoVertex/KinematicFit (reconstruction)
• RecoVertex/LinearizationPointFinders (reconstruction)
• RecoVertex/PrimaryVertexProducer (reconstruction)
• TrackingTools/TrackRefitter (reconstruction)
• TrackingTools/TrajectoryState (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@24LopezR, @AlexDeMoor, @CeliaFernandez, @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @Ming-Yan, @Prasant1993, @ReyerBand, @Sam-Harper, @Senphy, @VinInn, @VourMa, @a-kapoor, @abbiendi, @abdoulline, @afiqaize, @ahinzmann, @andrzejnovak, @apsallid, @argiro, @azotz, @barvic, @battibass, @bellan, @bsunanda, @castaned, @cericeci, @clelange, @denizsun, @dgulhan, @elusian, @fabiocos, @felicepantaleo, @forthommel, @fsimone91, @gkasieczka, @gouskos, @gpetruc, @grzanka, @hatakeyamak, @jainshilpi, @jazzitup, @jdamgov, @jdolen, @jhgoh, @kurtejung, @lecriste, @lgray, @llunerti, @mandrenguyen, @mariadalfonso, @martinamalberti, @mbluj, @missirol, @mmarionncern, @mmasciov, @mmusich, @mtosi, @namapane, @nhanvtran, @pavlo-kashko, @philippgadow, @ptcox, @ram1123, @rappoccio, @rchatter, @rociovilar, @rovere, @salimcerci, @sameasy, @schoef, @seemasharmafnal, @sobhatta, @thomreis, @trocino, @valsdav, @varuns23, @wang0jin, @yenjie, @yetkinyilmaz, @youyingli, @yslai this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-044cee/49727/summary.html
COMMIT: 7863ba0
CMSSW: CMSSW_16_0_X_2025-11-27-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49496/49727/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 8 differences found in the comparisons
• Reco comparison had 4 failed jobs
• DQMHistoTests: Total files compared: 55
• DQMHistoTests: Total histograms compared: 4502606
• DQMHistoTests: Total failures: 66
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4502520
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
• Checked 235 log files, 208 edm output root files, 55 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1