Improve out-of-bounds error message

[fwyzard]

PR description:

Improve out-of-bounds error message for SoA [] operator.
For example

Out of range index in ConstViewTemplateFreeParams HcalPhase1DigiSoALayout::operator[]: index 3692 out of range 2971

PR validation:

Code runs, and prints a more expressive error in case of out-of-bounds access.

[fwyzard]

+heterogeneous

[fwyzard]

please test

[fwyzard]

type ngt

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49553/47070

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DataFormats/SoATemplate/interface/SoALayout.h modified in PR(s): Various fixes for heterogeneous utilities #47605, Added AoSWrapper and transposition function #49072, [Draft] Allow users to set a valid data range for the SoA View #49204

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• DataFormats/SoATemplate (heterogeneous)

can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eba27c/49810/summary.html
COMMIT: 86ea408
CMSSW: CMSSW_16_0_X_2025-12-04-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49553/49810/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Dr15Jones Add RNTupleTempSource and RNTupleTempOutputModule #49532
• @Dr15Jones Use RNTuple streamer storage for deque and list #49531
• @bsunanda Phase2-hgx364X Correct the testing code for checking IDs of HGCal #49536
• @mkirsano Fix residualDecay code and 3 test configurations in /test #49537
• @bsunanda Phase2-gex195 Modify several test scripts in the Simulation packages in view of changing Phase2 scenario default to D121 instead of D110 #49479
• @jroloff PF Offline DQM MiniAOD compatibility and jet calibration addition #49474
• @bfonta Fix ControlledByREta in CloseByParticleGun #49375

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eba27c/49810/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eba27c/49810/git-merge-result

Failed Unit Tests

I found 2 errors in the following unit tests:

---> test TestRNTupleTempEventHistory had ERRORS
---> test TestIOPoolInputSchemaEvolution had ERRORS

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 1315 differences found in the comparisons
• Reco comparison had 4 failed jobs
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4273241
• DQMHistoTests: Total failures: 1630
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4271591
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 227 log files, 198 edm output root files, 53 DQM output files
• TriggerResults: found differences in 3 / 51 workflows

[fwyzard]

ignore tests-rejected with manual-override

[mandrenguyen]

+1