Skip to content

Removing JENKINS_PREFIX Check from das-up-to-nevents.py#49636

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
AdrianoDee:no_testing_das_nevents
Dec 17, 2025
Merged

Removing JENKINS_PREFIX Check from das-up-to-nevents.py#49636
cmsbuild merged 1 commit intocms-sw:masterfrom
AdrianoDee:no_testing_das_nevents

Conversation

@AdrianoDee
Copy link
Copy Markdown
Contributor

PR description:

Triggered by the discussion in #49627. As is das-up-to-nevents.py , checks if we are running within Jenkins. This was done at the time since, to simplify das-up-to-nevents when running PR tests, just to avoid crashes. In #49020 and #49045 the crashes were understood to be coming from accessing the certification web page too many times. Now the bot access the JSONs from cvmfs.

This PR proposes to just remove the testing limitation for the bot, allowing PR tests to use certified lumisections.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 16, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv)

@AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @miquork can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3595a2/49992/summary.html
COMMIT: 9f10f6b
CMSSW: CMSSW_16_0_X_2025-12-15-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49636/49992/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 2025.0010001, 2025.0000001, 2024.0070001, 2024.0060001, 2024.0050001, 2024.0040001, 2024.0030001, 2024.0020001, 2024.0010001, 2024.0000001, 2023.0020001, 2022.0030001 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • You potentially removed 892 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 45252 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4036186
  • DQMHistoTests: Total failures: 204209
  • DQMHistoTests: Total nulls: 267
  • DQMHistoTests: Total successes: 3831690
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 497.9940000000001 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 2022.0030001 ): 19.594 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2022.0030001 ): 0.516 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 2022.0030001 ): 0.191 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2022.0030001 ): -0.066 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2023.0020001 ): 60.117 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2023.0020001,... ): 27.582 KiB PixelPhase1/Tracks
  • DQMHistoSizes: changed ( 2023.0020001 ): 2.961 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2023.0020001 ): 1.582 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 2023.0020001 ): -0.094 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0000001 ): 120.055 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2024.0000001 ): ...
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Max Memory Comparisons exceeding threshold

@cms-sw/core-l2 , I found 12 workflow step(s) with memory usage exceeding the error threshold:

  • Error
  • Error
  • Error
  • Error
  • Error
  • Error
  • Error
  • Error
  • Error
  • Error
  • Error
  • Error

@AdrianoDee
Copy link
Copy Markdown
Contributor Author

@AdrianoDee
Copy link
Copy Markdown
Contributor Author

+pdmv

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Dec 16, 2025

@AdrianoDee AdrianoDee changed the title Removing JENKINS Check from das-up-to-nevents.py Removing JENKINS_PREFIX Check from das-up-to-nevents.py Dec 16, 2025
@AdrianoDee
Copy link
Copy Markdown
Contributor Author

This is ... strange. Indeed, it's not there, but it has run, and I don't see anything strange in the bot logs ...?

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 5b4bd47 into cms-sw:master Dec 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants