Skip to content

use automatic upgrade Detector number redirection introduced in #49437 in the GPU matrix#49647

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
mmusich:mm_gpu_matrix_update
Dec 22, 2025
Merged

use automatic upgrade Detector number redirection introduced in #49437 in the GPU matrix#49647
cmsbuild merged 1 commit into
cms-sw:masterfrom
mmusich:mm_gpu_matrix_update

Conversation

@mmusich
Copy link
Copy Markdown
Contributor

@mmusich mmusich commented Dec 16, 2025

PR description:

Title says it all, I noticed that the GPU matrix uses a different detector geometry (D110) in lieu of the one used for the rest of the workflows (D121, introduced in #49437).
I propose to use the same mechanism also in the GPU matrix.

PR validation:

None, to be done in this PR.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Dec 16, 2025

cms-bot internal usage

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Dec 16, 2025

test parameters:

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Dec 16, 2025

enable gpu

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv)

@AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @miquork can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Dec 16, 2025

@cmsbuild, please test

@AdrianoDee
Copy link
Copy Markdown
Contributor

AdrianoDee commented Dec 16, 2025

I suspect you'd need to keep the 29834.402,29834.403,29834.404,29834.704,29834.751 wfs used by the bot and hardcoded for this to work a first time, and then change those there and here again (at least this was the workaround I had found) .

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Dec 16, 2025

I suspect you'd need to keep the 29834.402,29834.403,29834.404,29834.704,29834.751 wfs used by the bot and hardcoded for this to work a first time, and then change those there and here again (at least this was the workaround I had found) .

isn't this what is proposed at cms-sw/cms-bot#2636 ?

@AdrianoDee
Copy link
Copy Markdown
Contributor

Oh, right, I had missed it, my bad!

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb350a/50005/summary.html
COMMIT: a259344
CMSSW: CMSSW_16_0_X_2025-12-16-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49647/50005/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4280229
  • DQMHistoTests: Total failures: 44
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4280165
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 1 DQM output files

AMD_W7900 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 1 DQM output files

NVIDIA_H100 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 1 DQM output files

NVIDIA_L40S Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 1 DQM output files

NVIDIA_T4 Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 63 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 55076
  • DQMHistoTests: Total failures: 9061
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 46015
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Dec 18, 2025

isn't this what is proposed at cms-sw/cms-bot#2636 ?

by looking here this seems to have worked!

@AdrianoDee
Copy link
Copy Markdown
Contributor

+pdmv

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cms-bot#2636

@cmsbuild
Copy link
Copy Markdown
Contributor

Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_16_0_X, CMSSW_16_1_X Dec 18, 2025
@ftenchini
Copy link
Copy Markdown

+1

@cmsbuild cmsbuild merged commit ebeaa76 into cms-sw:master Dec 22, 2025
26 checks passed
@mmusich mmusich deleted the mm_gpu_matrix_update branch December 22, 2025 13:33
@makortel
Copy link
Copy Markdown
Contributor

Just to note that merging this PR without cms-sw/cms-bot#2636 is causing GPU-enabled PR tests to fail, see #49700.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants