Skip to content

Phase 2 geometry deprecation#49725

Merged
cmsbuild merged 3 commits intocms-sw:masterfrom
kpedro88:Phase2-WF84
Jan 9, 2026
Merged

Phase 2 geometry deprecation#49725
cmsbuild merged 3 commits intocms-sw:masterfrom
kpedro88:Phase2-WF84

Conversation

@kpedro88
Copy link
Copy Markdown
Contributor

@kpedro88 kpedro88 commented Jan 6, 2026

PR description:

Addresses #49563. The final set of removals is:

  • Detectors: D95, D96, D98, D99, D100, D101, D102, D103, D105, D106, D107, D108, D109, D116, D117, D118, D119
  • Tracker: T31, T32, T33, T34
    • remove from README: T15, T21, T24, T25, T26, T30
  • Calorimeter: C17, C21, C23, C24
    • remove from README: C9, C10, C11, C13, C14, C15, C16
  • Muon system: M13
    • remove from README: M4, M6, M7, M8, M9, M10, M11, M12
  • MTD: I16, I19
    • remove from README: I10, I11, I12, I13, I14, I15
  • Common:
    • remove from README: O4, O5, O6, O7, O8
  • Forward:
    • remove from README: F2, F3, F4, F5, F6, F7

PR validation:

Geometry unit tests pass. runTheMatrix.py has the correct workflow numbers for the trained geometries.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not intended to be backported.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 6, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 6, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49725/47307

@kpedro88 kpedro88 marked this pull request as ready for review January 7, 2026 10:28
@kpedro88
Copy link
Copy Markdown
Contributor Author

kpedro88 commented Jan 7, 2026

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 7, 2026

A new Pull Request was created by @kpedro88 for master.

It involves the following packages:

  • Configuration/Geometry (geometry)
  • Configuration/PyReleaseValidation (pdmv)
  • Configuration/StandardSequences (operations)

@AdrianoDee, @DickyChant, @Dr15Jones, @antoniovagnerini, @bsunanda, @civanch, @davidlange6, @fabiocos, @ftenchini, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @miquork can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @elusian, @fabiocos, @felicepantaleo, @makortel, @mmasciov, @mmusich, @mtosi, @rovere, @sameasy, @slomeo, @vargasa this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Copy Markdown
Contributor Author

kpedro88 commented Jan 8, 2026

@smuzaffar the bot or tests seem to be stuck?

@smuzaffar
Copy link
Copy Markdown
Contributor

@kpedro88 , the dqm comparison job landed on a buggy node and failed without any notifications. I have restarted the comparison job. results should be available in an hour

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 8, 2026

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b1c44/50459/summary.html
COMMIT: b3a46fd
CMSSW: CMSSW_16_1_X_2026-01-06-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49725/50459/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4280553
  • DQMHistoTests: Total failures: 137
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4280396
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Copy Markdown
Contributor

bsunanda commented Jan 8, 2026

+geometry

@AdrianoDee
Copy link
Copy Markdown
Contributor

+pdmv

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 9, 2026

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link
Copy Markdown

+1

@cmsbuild cmsbuild merged commit 46041a5 into cms-sw:master Jan 9, 2026
10 checks passed
mmusich added a commit to mmusich/cmssw that referenced this pull request Jan 12, 2026
@makortel
Copy link
Copy Markdown
Contributor

Looks like this PR caused some knock-on failures in IBs #49772

mmusich added a commit to mmusich/cmssw that referenced this pull request Jan 12, 2026
cmsbuild added a commit that referenced this pull request Jan 12, 2026
…Migrate

update unit test Miscellanea post integration of #49725
mmusich added a commit to mmusich/cmssw that referenced this pull request Jan 13, 2026
mmusich added a commit to mmusich/cmssw that referenced this pull request Jan 13, 2026
cmsbuild added a commit that referenced this pull request Jan 13, 2026
…test

fix unit test `createTestDBObjects` after integration of #49725
mmusich added a commit to mmusich/cmssw that referenced this pull request Jan 14, 2026
mmusich added a commit to mmusich/cmssw that referenced this pull request Jan 14, 2026
chrishanw pushed a commit to chrishanw/cmssw that referenced this pull request Jan 14, 2026
chrishanw pushed a commit to chrishanw/cmssw that referenced this pull request Jan 14, 2026
mmusich added a commit to mmusich/cmssw that referenced this pull request Jan 14, 2026
mmusich added a commit to mmusich/cmssw that referenced this pull request Jan 16, 2026
akritkbehera pushed a commit to akritkbehera/cmssw that referenced this pull request Feb 3, 2026
akritkbehera pushed a commit to akritkbehera/cmssw that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants