Skip to content

Move AtomicPtrCache dictionary to proper packages#49757

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
Dr15Jones:dictToProperPackage
Jan 12, 2026
Merged

Move AtomicPtrCache dictionary to proper packages#49757
cmsbuild merged 1 commit intocms-sw:masterfrom
Dr15Jones:dictToProperPackage

Conversation

@Dr15Jones
Copy link
Copy Markdown
Contributor

@Dr15Jones Dr15Jones commented Jan 9, 2026

PR description:

The type needs to be declared in the same package that holds the type in the template argument.

PR validation:

Code compiles.

resolves #49741
resolves cms-sw/framework-team#1779

The type needs to be declared in the same package that holds the type in the template argument.
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 9, 2026

cms-bot internal usage

@Dr15Jones
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 9, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49757/47342

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 9, 2026

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • DataFormats/EgammaReco (reconstruction)
  • DataFormats/ParticleFlowCandidate (reconstruction)
  • DataFormats/PatCandidates (reconstruction, xpog)
  • DataFormats/TrackReco (reconstruction)

@Moanwar, @battibass, @ftorrresd, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@Prasant1993, @Sam-Harper, @VinInn, @VourMa, @a-kapoor, @afiqaize, @elusian, @gouskos, @gpetruc, @hatakeyamak, @jainshilpi, @lgray, @missirol, @mmasciov, @mmusich, @mtosi, @rovere, @sameasy, @sobhatta, @varuns23 this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 9, 2026

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2fa6a/50494/summary.html
COMMIT: 7ec69ae
CMSSW: CMSSW_16_1_X_2026-01-09-1300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49757/50494/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 4532332
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4532306
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
  • Checked 235 log files, 208 edm output root files, 55 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Copy Markdown
Contributor

+1

@ftorrresd
Copy link
Copy Markdown
Contributor

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit c828765 into cms-sw:master Jan 12, 2026
10 checks passed
@Dr15Jones Dr15Jones deleted the dictToProperPackage branch January 15, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment