Skip to content

Remove legacy CUDA pixel track and vertex reconstruction#49794

Merged
cmsbuild merged 5 commits intocms-sw:masterfrom
fwyzard:remove_cuda_pixel_tracking
Jan 16, 2026
Merged

Remove legacy CUDA pixel track and vertex reconstruction#49794
cmsbuild merged 5 commits intocms-sw:masterfrom
fwyzard:remove_cuda_pixel_tracking

Conversation

@fwyzard
Copy link
Copy Markdown
Contributor

@fwyzard fwyzard commented Jan 13, 2026 •
edited
Loading

PR description:

Remove legacy CUDA pixel track and vertex reconstruction:

  • remove legacy CUDA pixel track modules and data formats;
  • remove legacy CUDA pixel vertex modules and data formats;
  • remove legacy CUDA SoA-based L2TauTagNNProducer.

PR validation:

All unit and matrix tests pass.

@cmsbuild cmsbuild added this to the CMSSW_16_1_X milestone Jan 13, 2026
@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Jan 13, 2026

enable gpu

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Jan 13, 2026

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 13, 2026 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 13, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49794/47432

@fwyzard fwyzard mentioned this pull request Jan 13, 2026
Open
56 tasks
@fwyzard fwyzard force-pushed the remove_cuda_pixel_tracking branch from e822348 to 52126d0 Compare January 13, 2026 11:33
@fwyzard fwyzard marked this pull request as ready for review January 13, 2026 11:33
@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Jan 13, 2026

enable gpu

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Jan 13, 2026

please test

@civanch
Copy link
Copy Markdown
Contributor

civanch commented Jan 15, 2026

+1

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Jan 15, 2026

unhold

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Jan 15, 2026

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 15, 2026

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 15, 2026

-1

Failed Tests: RelVals-AMD_W7900
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8fe4e5/50661/summary.html
COMMIT: 795c47b
CMSSW: CMSSW_16_1_X_2026-01-15-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49794/50661/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals-AMD_W7900

  • 34634.40334634.403_TTbar_14TeV+Run4D121PU_Patatrack_PixelOnlyAlpaka_Validation/step2_TTbar_14TeV+Run4D121PU_Patatrack_PixelOnlyAlpaka_Validation.log
  • 34634.40234634.402_TTbar_14TeV+Run4D121PU_Patatrack_PixelOnlyAlpaka/step2_TTbar_14TeV+Run4D121PU_Patatrack_PixelOnlyAlpaka.log
  • 34634.75134634.751_TTbar_14TeV+Run4D121PU_HLT75e33TimingAlpaka/step2_TTbar_14TeV+Run4D121PU_HLT75e33TimingAlpaka.log
Expand to see more relval errors ...

Comparison Summary

The workflows 2024.0030001 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • You potentially removed 10 lines from the logs
  • Reco comparison results: 4054 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4258941
  • DQMHistoTests: Total failures: 5372
  • DQMHistoTests: Total nulls: 24
  • DQMHistoTests: Total successes: 4253525
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -16.591 KiB( 53 files compared)
  • DQMHistoSizes: changed ( 2024.0030001 ): -16.070 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2024.0030001 ): -0.398 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 2024.0030001 ): -0.063 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2024.0030001 ): -0.059 KiB JetMET/SUSYDQM
  • Checked 230 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Jan 16, 2026

ignore tests-rejected with ib-failure

@mandrenguyen
Copy link
Copy Markdown
Contributor

mandrenguyen commented Jan 16, 2026

+1

@cmsbuild cmsbuild merged commit fecf725 into cms-sw:master Jan 16, 2026
15 of 20 checks passed
@pietroGru
Copy link
Copy Markdown
Contributor

pietroGru commented Jan 17, 2026

The merged commit is tagged CMSSW_16_1_X_2026-01-17-1100. From the build log of #49829 I notice the two lines

containing references to cuda. Is it expected?

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Jan 19, 2026

@pietroGru thanks for the report.
I'm not sure what parts of the build log you refer to, but I'll have a look at the code.

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Jan 19, 2026

Some more cleanup is done in #49859 .

@mmusich mmusich mentioned this pull request Jan 19, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

code-checks-approved fully-signed heterogeneous-approved hlt-approved orp-approved reconstruction-approved tests-approved tests-ib-failure tracking

Projects

None yet

Milestone

CMSSW_16_1_X

Development

Successfully merging this pull request may close these issues.

8 participants

@fwyzard @cmsbuild @mmusich @jfernan2 @perrotta @civanch @mandrenguyen @pietroGru