Skip to content

[L1T] Update recommended geometry tag in Phase2 L1TNanoAOD producer README to D121 (Phase2)#49870

Open
RobertJWard wants to merge 2 commits intocms-sw:masterfrom
RobertJWard:phase2l1nano-readme
Open

[L1T] Update recommended geometry tag in Phase2 L1TNanoAOD producer README to D121 (Phase2)#49870
RobertJWard wants to merge 2 commits intocms-sw:masterfrom
RobertJWard:phase2l1nano-readme

Conversation

@RobertJWard
Copy link
Copy Markdown
Contributor

PR description:

Updates the recipe in the README for the Phase 2 L1TNanoAOD producer tool to the latest phase 2 recommended geometry of D121 (previously D110).

PR validation:

None required - simple text change to a markdown file, with no impact on the code itself.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 19, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @RobertJWard for master.

It involves the following packages:

  • DPGAnalysis/Phase2L1TNanoAOD (l1, xpog)

@BenjaminRS, @battibass, @cmsbuild, @ftorrresd, @quinnanm can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@quinnanm
Copy link
Copy Markdown
Contributor

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a6b10/50745/summary.html
COMMIT: af3fd59
CMSSW: CMSSW_16_1_X_2026-01-19-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49870/50745/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4025536
  • DQMHistoTests: Total failures: 43
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4025473
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 222 log files, 193 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49870/47575

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #49870 was updated. @BenjaminRS, @battibass, @cmsbuild, @ftorrresd, @quinnanm can you please check and sign again.

@battibass
Copy link
Copy Markdown

@RobertJWard, can you please collapse your commits into a single one (as described here) before we approve the PR?

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #49870 was updated. @BenjaminRS, @battibass, @cmsbuild, @ftorrresd, @quinnanm can you please check and sign again.

@RobertJWard
Copy link
Copy Markdown
Contributor Author

Hi @battibass I've now squashed the commits (though an extra merge commit was added as the conditions update T33 -> T35 was also made in parallel in #49790, resulting in a conflict)

@battibass
Copy link
Copy Markdown

please test

@battibass
Copy link
Copy Markdown

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a6b10/50813/summary.html
COMMIT: 9c25c2d
CMSSW: CMSSW_16_1_X_2026-01-22-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49870/50813/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4025536
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4025513
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 222 log files, 193 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 4, 2026

Milestone for this pull request has been moved to CMSSW_17_0_X. Please open a backport if it should also go in to CMSSW_16_1_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_16_1_X, CMSSW_17_0_X Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants