Skip to content

add a customization function for modules renamed in #49936, still used in the 2025 frozen HLT menu#49962

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
cms-tsg-storm:add_customize_for49936
Jan 28, 2026
Merged

add a customization function for modules renamed in #49936, still used in the 2025 frozen HLT menu#49962
cmsbuild merged 1 commit intocms-sw:masterfrom
cms-tsg-storm:add_customize_for49936

Conversation

@mmusich
Copy link
Copy Markdown
Contributor

@mmusich mmusich commented Jan 28, 2026

PR description:

PR #49936 changed the names of a few modules that used to be included in the 2025 frozen menu.
In PRs

we changed the default HLT menu run in 2025 relvals to be the Fake one, thus the problem is not caught in IB relvals.
Also the IB TSG tests are not running the frozen menu, but only the development tables:

else if ( ($2 == ib) || ($2 == IB) ) then
set tables = ( GRun HIon PIon PRef Special)

thus also not seen in IB TSG tests.

@Martin-Grunewald noticed in private tests that this breaks the running of the full batter of TSG tests.

PR validation:

With the updated branch, I run ./runAll.csh frozen
Obtaining:

2026-01-28 Wed 14:38:26
Starting ./runOne.csh MC frozen

14:38:26 cmsRun RelVal_DigiL1Raw_2025v13_MC.py >& RelVal_DigiL1Raw_2025v13_MC.log
141.766u 5.752s 3:04.97 79.7%	0+0k 1664+278376io 3473pf+0w
14:41:31 exit status: 0

14:41:31 cmsRun OnLine_HLT_2025v13.py realData=False globalTag=@ inputFiles=@ >& OnLine_HLT_2025v13_MC.log
92.176u 18.553s 1:43.90 106.5%	0+0k 57200+1699984io 671pf+0w
14:43:15 exit status: 0

14:43:15 cmsRun RelVal_HLT_2025v13_MC.py >& RelVal_HLT_2025v13_MC.log
79.815u 14.079s 1:18.01 120.3%	0+0k 176360+779832io 0pf+0w
14:44:33 exit status: 0

14:44:33 cmsRun RelVal_HLT2_2025v13_MC.py >& RelVal_HLT2_2025v13_MC.log
65.159u 13.013s 1:02.14 125.7%	0+0k 16+93272io 0pf+0w
14:45:35 exit status: 0

14:45:35 cmsRun RelVal_HLT_Reco_2025v13_MC.py >& RelVal_HLT_Reco_2025v13_MC.log
73.305u 13.287s 1:24.19 102.8%	0+0k 59080+89808io 8pf+0w
14:46:59 exit status: 0

14:46:59 cmsRun RelVal_DigiL1RawHLT_2025v13_MC.py >& RelVal_DigiL1RawHLT_2025v13_MC.log
186.994u 15.847s 3:50.23 88.0%	0+0k 4120+908256io 1682pf+0w
14:50:49 exit status: 0

14:50:50 cmsRun RelVal_RECO_2025v13_MC.py >& RelVal_RECO_2025v13_MC.log
248.826u 22.660s 3:06.58 145.5%	0+0k 444560+301544io 1815pf+0w
14:53:56 exit status: 0

Finished ./runOne.csh MC frozen
2026-01-28 Wed 14:53:56
888.638u 103.979s 16:08.02 102.5%	0+0k 743312+4151072io 7652pf+0w

2026-01-28 Wed 14:38:25
Starting ./runOne.csh DATA frozen

14:38:25 cmsRun RelVal_L1RePack_2025v13_DATA.py >& RelVal_L1RePack_2025v13_DATA.log
60.657u 5.375s 0:52.85 124.9%	0+0k 88+356112io 4355pf+0w
14:39:18 exit status: 0

14:39:18 cmsRun OnLine_HLT_2025v13.py realData=True globalTag=@ inputFiles=@ >& OnLine_HLT_2025v13_DATA.log
209.690u 28.237s 2:40.91 147.8%	0+0k 193832+10505624io 1347pf+0w
14:41:59 exit status: 0

14:41:59 cmsRun RelVal_HLT_2025v13_DATA.py >& RelVal_HLT_2025v13_DATA.log
139.021u 16.734s 1:36.33 161.6%	0+0k 331408+1840160io 50pf+0w
14:43:36 exit status: 0

14:43:36 cmsRun RelVal_HLT2_2025v13_DATA.py >& RelVal_HLT2_2025v13_DATA.log
147.872u 17.510s 1:26.75 190.6%	0+0k 16+413496io 0pf+0w
14:45:03 exit status: 0

14:45:03 cmsRun RelVal_HLT_Reco_2025v13_DATA.py >& RelVal_HLT_Reco_2025v13_DATA.log
168.733u 18.006s 1:43.03 181.2%	0+0k 201064+408432io 303pf+0w
14:46:46 exit status: 0

14:46:46 cmsRun RelVal_RECO_2025v13_DATA.py >& RelVal_RECO_2025v13_DATA.log
902.930u 44.743s 6:20.64 248.9%	0+0k 638656+766672io 1198pf+0w
14:53:06 exit status: 0

Finished ./runOne.csh DATA frozen
2026-01-28 Wed 14:53:06

Resulting log files:
-rw-r--r--. 1 musich zh 25599363 Jan 28 14:41 OnLine_HLT_2025v13_DATA.log
-rw-r--r--. 1 musich zh 25630477 Jan 28 14:43 OnLine_HLT_2025v13_MC.log
-rw-r--r--. 1 musich zh 23207793 Jan 28 14:50 RelVal_DigiL1RawHLT_2025v13_MC.log
-rw-r--r--. 1 musich zh    77814 Jan 28 14:41 RelVal_DigiL1Raw_2025v13_MC.log
-rw-r--r--. 1 musich zh 23168564 Jan 28 14:45 RelVal_HLT2_2025v13_DATA.log
-rw-r--r--. 1 musich zh 23194915 Jan 28 14:45 RelVal_HLT2_2025v13_MC.log
-rw-r--r--. 1 musich zh 23168613 Jan 28 14:43 RelVal_HLT_2025v13_DATA.log
-rw-r--r--. 1 musich zh 23192630 Jan 28 14:44 RelVal_HLT_2025v13_MC.log
-rw-r--r--. 1 musich zh 23174509 Jan 28 14:46 RelVal_HLT_Reco_2025v13_DATA.log
-rw-r--r--. 1 musich zh 23199246 Jan 28 14:46 RelVal_HLT_Reco_2025v13_MC.log
-rw-r--r--. 1 musich zh    71873 Jan 28 14:39 RelVal_L1RePack_2025v13_DATA.log
-rw-r--r--. 1 musich zh   569833 Jan 28 14:53 RelVal_RECO_2025v13_DATA.log
-rw-r--r--. 1 musich zh   657939 Jan 28 14:53 RelVal_RECO_2025v13_MC.log

2026-01-28 Wed 14:53:56

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 28, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Jan 28, 2026

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Jan 28, 2026

type bug-fix

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01e8df/50962/summary.html
COMMIT: 720e33b
CMSSW: CMSSW_16_1_X_2026-01-27-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49962/50962/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4025536
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4025513
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 222 log files, 193 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Jan 28, 2026

+hlt

  • fixes the problem at hand, no changes expected, none seen.

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mmusich mmusich changed the title add a customization function to take care of the modules renamed in #49936, but still used in the 2025 frozen menu add a customization function for modules renamed in #49936, still used in the 2025 frozen HLT menu Jan 28, 2026
@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 814a094 into cms-sw:master Jan 28, 2026
10 checks passed
@mmusich mmusich deleted the add_customize_for49936 branch January 28, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants