Update tracker alignment algs to new Millepede+GBL versions by goblirsc · Pull Request #49963 · cms-sw/cmssw

goblirsc · 2026-01-28T14:57:17Z

PR description:

This PR updates the CMSSW client code for interacting with Millepede2 and GBL to accomodate the latest updates to said packages.

new external package dependency for providing the Mille binary file interface.
removal of CMS-internal copy of Mille class.
removal of no-longer-needed gbl::MilleRecord instance in MillepedeAlignmentAlgorithm simultaneously talking to the same file as Mille instance (fragile).
py3-migrate a useful script found along the way.

Dependencies / expected changes / documentation:

this PR depends on an externals PR, cmsdist:#10310. Both should be tested together.
no changes to the output are expected. The alignment binaries written by the new Mille version are 1:1 compatible to the existing format.
Documentation of changes / new features: slides Alignment weekly 26.01.26).

PR validation:

unit tests (scram b runtests use-ibeos): passing
runTheMatrix.py -l limited -i all --ibeo: all tests passing except for few failures unrelated to the PR (missing datasets for e/gamma 136.X, DAS errors for 2022.00X-2025.00X)
alignment campaign with a local build of the modified CMSSW + externals: successful and identical output to existing codebase.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport needed

Before submitting your pull requests, make sure you followed this checklist:
✔️ verify that the PR is really intended for the chosen branch
✔️ verify that changes follow CMS Naming, Coding, And Style Rules
✔️ verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2026-01-28T14:57:42Z

cms-bot internal usage

cmsbuild · 2026-01-28T14:59:02Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49963/47743

ERROR: Build errors found during clang-tidy run.

src/Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeAlignmentAlgorithm.cc:24:10: error: 'Mille/MilleFactory.h' file not found [clang-diagnostic-error]
   24 | #include "Mille/MilleFactory.h"                                     // external Mille library
      |          ^~~~~~~~~~~~~~~~~~~~~~
Suppressed 1082 warnings (1082 in non-user code).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

smuzaffar · 2026-01-29T10:23:21Z

code-checks with cms.week0.PR_6e7d7ce1/100.0-e18971569e0e45b7e8c26c8607cf3bf8

cmsbuild · 2026-01-29T10:30:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49963/47759

cmsbuild · 2026-01-29T10:30:28Z

A new Pull Request was created by @goblirsc for master.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm (alca)
Alignment/ReferenceTrajectories (alca)
PhysicsTools/PythonAnalysis (analysis)

@Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @perrotta, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2026-01-29T15:53:27Z

test parameters:

pull_request = Add new "Mille" package to externals, update Millepede-II and GBL cmsdist#10310

perrotta · 2026-01-29T15:53:55Z

please test

tvami · 2026-01-29T17:14:40Z

@@ -1581,17 +1595,11 @@ void MillePedeAlignmentAlgorithm::addLasBeam(const EventInfo &eventInfo,
    const float residual = hit.localPosition().x() - tsoses[iHit].localPosition().x();
    // error from file or assume 0.003
    const float error = 0.003;  // hit.localPositionError().xx(); sqrt???


This is beyond this PR, but I do wonder: is this really meant to be hardcoded at 0.003?

as this pertains to MillePedeAlignmentAlgorithm::addLasBeam (LAS system decomissioned in 2014) I hardly can see how this could be relevant.

I didnt realize this was for LAS. So this function could be fully removed too then?

probably 🤷‍♂️

cmsbuild · 2026-01-29T19:17:00Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-974a61/50994/summary.html
COMMIT: 5826615
CMSSW: CMSSW_16_1_X_2026-01-29-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49963/50994/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-974a61/50994/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-974a61/50994/git-merge-result

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 52
DQMHistoTests: Total histograms compared: 4028546
DQMHistoTests: Total failures: 47
DQMHistoTests: Total nulls: 697
DQMHistoTests: Total successes: 4027782
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.792 KiB( 51 files compared)
DQMHistoSizes: changed ( 34434.0,... ): 0.448 KiB TrackerPhase2OTL1TrackV/trackParticles
Checked 222 log files, 193 edm output root files, 52 DQM output files
TriggerResults: no differences found

cmsbuild · 2026-02-03T11:17:50Z

Pull request #49963 was updated. @Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @perrotta, @tvami can you please check and sign again.

perrotta · 2026-02-03T12:39:11Z

@goblirsc probably before launching the tests it could be worthwhile to squash all commits into one.
Then the PR can be tested, and approved (at least for what I am concerned)

cmsbuild · 2026-02-03T13:03:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49963/47839

cmsbuild · 2026-02-03T13:03:50Z

Pull request #49963 was updated. @Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @perrotta, @tvami can you please check and sign again.

perrotta · 2026-02-03T13:15:23Z

please test

cmsbuild · 2026-02-03T19:25:10Z

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-974a61/51068/summary.html
COMMIT: 2dca55b
CMSSW: CMSSW_16_1_X_2026-02-03-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49963/51068/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-974a61/51068/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-974a61/51068/git-merge-result

Comparison Summary

Summary:

You potentially added 17 lines to the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 58
DQMHistoTests: Total histograms compared: 4157306
DQMHistoTests: Total failures: 49
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4157237
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 57 files compared)
Checked 251 log files, 198 edm output root files, 58 DQM output files
TriggerResults: no differences found

perrotta · 2026-02-04T09:58:13Z

+alca

Millepede moved to its library version, with no regression observed in the relevant workflow outputs, as expected

tvami · 2026-02-04T15:48:12Z

+1

cmsbuild · 2026-02-04T15:48:44Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#10310

cmsbuild · 2026-02-04T19:35:26Z

REMINDER @mandrenguyen, @sextonkennedy, @ftenchini: This PR was tested with cms-sw/cmsdist#10310, please check if they should be merged together

mandrenguyen · 2026-02-05T07:43:13Z

+1

jhakala · 2026-02-23T21:01:35Z

Very nice to see the improvements to PhysicsTools/PythonAnalysis/scripts/edmMakePhDThesis! 😉

cmsbuild added this to the CMSSW_16_1_X milestone Jan 28, 2026

cmsbuild added analysis-pending alca-pending pending-signatures tests-pending orp-pending code-checks-pending trk labels Jan 28, 2026

goblirsc mentioned this pull request Jan 28, 2026

Add new "Mille" package to externals, update Millepede-II and GBL cms-sw/cmsdist#10310

Merged

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 28, 2026

goblirsc marked this pull request as ready for review January 28, 2026 16:18

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 29, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 29, 2026

cmsbuild added the requires-external label Jan 29, 2026

cmsbuild added tests-started and removed tests-pending labels Jan 29, 2026

tvami reviewed Jan 29, 2026

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Jan 29, 2026

cmsbuild added the code-checks-approved label Feb 3, 2026

update usage of Mille - replace local copy by external

2dca55b

goblirsc force-pushed the MG_MillePedeUpdates branch from adb73be to 2dca55b Compare February 3, 2026 12:56

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 3, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 3, 2026

cmsbuild added tests-started and removed tests-pending labels Feb 3, 2026

cmsbuild added tests-approved and removed tests-started labels Feb 3, 2026

cmsbuild added alca-approved and removed alca-pending labels Feb 4, 2026

cmsbuild removed the analysis-pending label Feb 4, 2026

This was referenced Feb 5, 2026

Update LLVM version 21 for 16.1.X cms-sw/cmsdist#10322

Merged

Drop meschach from cms software stack cms-sw/cmsdist#10323

Merged

[CLANG] Update LLVM version from 21.1.4 to 21.1.8 cms-sw/cmsdist#10324

Merged

goblirsc mentioned this pull request Mar 17, 2026

Fix: Add missing buffer flush for PCL to MillePedeAlignmentAlgorithm #50447

Merged

Conversation

goblirsc commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 28, 2026

Uh oh!

smuzaffar commented Jan 29, 2026

Uh oh!

cmsbuild commented Jan 29, 2026

Uh oh!

cmsbuild commented Jan 29, 2026

Uh oh!

perrotta commented Jan 29, 2026

Uh oh!

perrotta commented Jan 29, 2026

Uh oh!

tvami Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

mmusich Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

tvami Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

mmusich Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Jan 29, 2026

Comparison Summary

Uh oh!

cmsbuild commented Feb 3, 2026

Uh oh!

perrotta commented Feb 3, 2026

Uh oh!

cmsbuild commented Feb 3, 2026

Uh oh!

cmsbuild commented Feb 3, 2026

Uh oh!

perrotta commented Feb 3, 2026

Uh oh!

cmsbuild commented Feb 3, 2026

Comparison Summary

Uh oh!

perrotta commented Feb 4, 2026

Uh oh!

tvami commented Feb 4, 2026

Uh oh!

cmsbuild commented Feb 4, 2026

Uh oh!

cmsbuild commented Feb 4, 2026

Uh oh!

mandrenguyen commented Feb 5, 2026

Uh oh!

jhakala commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

goblirsc commented Jan 28, 2026 •

edited

Loading

cmsbuild commented Jan 28, 2026 •

edited

Loading