[16.0.X] Modernization of TrackToTrackComparisonHists

[mmusich]

backport of #49913

PR description:

Technical no regressions expected:

• merge header with implementation (as expected for a plugin)
• use range-based loop when possible
• reduced cost of fillMap by using deltaR2 vs deltaR
• simplified logic of event data retrieval

PR validation:

runTheMatrix.py -l 18634.0 -t 4 -j 8 -i all --ibeos runs.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

#49913

[cmsbuild]

A new Pull Request was created by @mmusich for CMSSW_16_0_X.

It involves the following packages:

• DQM/TrackingMonitorSource (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@VinInn, @VourMa, @arossi83, @elusian, @fioriNTU, @idebruyn, @jandrea, @mmasciov, @mmusich, @mtosi, @richa2710, @sroychow, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Modernization of TrackToTrackComparisonHists #49913

[cmsbuild]

cms-bot internal usage

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebd3db/50999/summary.html
COMMIT: 659a63d
CMSSW: CMSSW_16_0_X_2026-01-29-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49980/50999/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 55
• DQMHistoTests: Total histograms compared: 4382508
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4382482
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
• Checked 235 log files, 208 edm output root files, 55 DQM output files
• TriggerResults: no differences found

[nothingface0]

+dqm

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_16_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1