Skip to content

[16.0.X] add reconstructable sim vertices validation for HLT full vertices#49981

Merged
cmsbuild merged 1 commit intocms-sw:CMSSW_16_0_Xfrom
cms-ngt-hlt:mm_reconstructableSimFullVertices_16_0_X
Jan 30, 2026
Merged

[16.0.X] add reconstructable sim vertices validation for HLT full vertices#49981
cmsbuild merged 1 commit intocms-sw:CMSSW_16_0_Xfrom
cms-ngt-hlt:mm_reconstructableSimFullVertices_16_0_X

Conversation

@mmusich
Copy link
Copy Markdown
Contributor

@mmusich mmusich commented Jan 29, 2026

backport of #49900

PR description:

Title say it all, this is a follow-up to #49609.
In that PR we introduced the concept of "reconstructable" sim-vertex, allowing the validation module to optionally focus only on sim vertices that meet reconstruction criteria (≥3 associated tracks).
We extend that validation flavor also to the "full" (offline-like, i.e. DA-driven) vertices.

PR validation:

Run the following script:

#!/bin/bash -ex

cmsDriver.py step2 --step L1P2GT,HLT:NGTScouting,VALIDATION:@hltValidation \
 --procModifier phase2LegacyPixelTracks \
 --conditions auto:phase2_realistic_T33 --processName HLTX \
 --datatier DQMIO --eventcontent DQMIO \
 --geometry ExtendedRun4D110 --customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000 --era Phase2C17I13M9 \
 --inputCommands='keep *, drop *_hlt*_*_HLT, drop triggerTriggerFilterObjectWithRefs_l1t*_*_HLT' \
 --filein file:/eos/cms/store/relval/CMSSW_16_0_0_pre4/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/PU_150X_mcRun4_realistic_v1_STD_Run4D110_PU-v2/2580000/037118f1-472e-4647-88fc-b0211e52df6f.root \
 --fileout file:step2.root -n -1 --nThreads 0

cmsDriver.py step3 -s HARVESTING:@hltValidation --filetype DQM \
 --conditions auto:phase2_realistic_T33 --geometry ExtendedRun4D110 \
 --scenario pp --mc --era Phase2C17I13M9 \
 -n -1 --filein file:step2.root

and checked that the output DQM file is sensible.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

#49900

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Jan 29, 2026

type ngt

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 29, 2026

A new Pull Request was created by @mmusich for CMSSW_16_0_X.

It involves the following packages:

  • Validation/RecoVertex (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @elusian, @felicepantaleo, @missirol, @mmasciov, @mmusich, @mtosi, @rovere, @venturia this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 29, 2026

cms-bot internal usage

@mmusich
Copy link
Copy Markdown
Contributor Author

mmusich commented Jan 29, 2026

@cmsbuild, please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1283a/51000/summary.html
COMMIT: 74919f3
CMSSW: CMSSW_16_0_X_2026-01-29-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49981/51000/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 4382508
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 4382477
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 25429.774 KiB( 54 files compared)
  • DQMHistoSizes: changed ( 18434.0,... ): 2794.853 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 18434.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 18434.0,... ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 34434.0,... ): 3306.669 KiB HLT/Vertexing
  • Checked 235 log files, 208 edm output root files, 55 DQM output files
  • TriggerResults: found differences in 8 / 53 workflows

@nothingface0
Copy link
Copy Markdown
Contributor

+dqm

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_16_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 61aa1d4 into cms-sw:CMSSW_16_0_X Jan 30, 2026
8 checks passed
@mmusich mmusich deleted the mm_reconstructableSimFullVertices_16_0_X branch January 30, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants