Skip to content

Updates to the offline CPU vs. GPU workflows for LST#49984

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
SegmentLinking:improveOfflineLSTWfs
Feb 9, 2026
Merged

Updates to the offline CPU vs. GPU workflows for LST#49984
cmsbuild merged 1 commit intocms-sw:masterfrom
SegmentLinking:improveOfflineLSTWfs

Conversation

@VourMa
Copy link
Copy Markdown
Contributor

@VourMa VourMa commented Jan 29, 2026

This PR applies the additional CPU reconstruction (SerialSync) and CPU vs. GPU comparison plots for the LST implementation in the Phase 2 offline reconstruction through a new procModifier, alpakaValidationLST. The new modifier is also included in the alpakaValidation modifier chain.

With the introduction of the alpakaValidationLST modifier, the offline workflow testing LST on CPU vs. LST on GPU can be made explicit. The code is changed so that the heterogeneous workflow 0.712 (previously 0.704) runs the offline reconstruction without any additional CPU reconstruction, while a new workflow, 0.713, runs the comparison. Workflow 0.703 has also been renamed to 0.711. The workflow numbering changes are made so that the offline LST workflows follow the numbering conventions for Alpaka workflows, following #49832 (comment).

The PR has been validated by running workflows 0.711, 0.712 and 0.713 locally. They finished successfully, with the anticipated content in the DQM file.

This PR includes the offline part of #49832 and it supersedes it. It requires and is required by cms-sw/cms-bot#2663.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Jan 29, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49984/47771

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @VourMa for master.

It involves the following packages:

  • Configuration/ProcessModifiers (operations)
  • Configuration/PyReleaseValidation (pdmv)
  • DQM/TrackingMonitorClient (dqm)
  • DQM/TrackingMonitorSource (dqm)
  • RecoTracker/IterativeTracking (reconstruction)
  • RecoTracker/LSTCore (reconstruction)

@AdrianoDee, @DickyChant, @Moanwar, @antoniovagnerini, @cmsbuild, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @jfernan2, @mandrenguyen, @miquork, @nothingface0, @rseidita, @srimanob can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @arossi83, @dgulhan, @elusian, @fabiocos, @felicepantaleo, @fioriNTU, @gpetruc, @idebruyn, @jandrea, @makortel, @mmasciov, @mmusich, @mtosi, @richa2710, @rovere, @slomeo, @sroychow, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@nothingface0
Copy link
Copy Markdown
Contributor

@cmsbuild please test

@VourMa
Copy link
Copy Markdown
Contributor Author

VourMa commented Jan 30, 2026

@nothingface0 I think we would need something the below to properly test this (I don't have bot permissions but maybe you can make it work):

@nothingface0
Copy link
Copy Markdown
Contributor

@cmsbuild abort

@nothingface0
Copy link
Copy Markdown
Contributor

nothingface0 commented Jan 30, 2026

test parameters:

@nothingface0
Copy link
Copy Markdown
Contributor

enable gpu

@nothingface0
Copy link
Copy Markdown
Contributor

@cmsbuild please test

@VourMa sorry, I got ahead of myself 😅

@AdrianoDee
Copy link
Copy Markdown
Contributor

+pdmv

@AdrianoDee
Copy link
Copy Markdown
Contributor

test parameters:

@AdrianoDee
Copy link
Copy Markdown
Contributor

AdrianoDee commented Feb 5, 2026

please test
(sorry to use this as a guinea pig, but I think it's worth testing if the bug fix works properly here)

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 5, 2026

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43406e/51117/summary.html
COMMIT: fefacea
CMSSW: CMSSW_16_1_X_2026-02-04-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49984/51117/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6760 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4263089
  • DQMHistoTests: Total failures: 18427
  • DQMHistoTests: Total nulls: 28
  • DQMHistoTests: Total successes: 4244614
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 230 log files, 203 edm output root files, 54 DQM output files
  • TriggerResults: found differences in 3 / 52 workflows

AMD_MI300X Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 1 DQM output files

AMD_W7900 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 1 DQM output files

NVIDIA_H100 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 1 DQM output files

NVIDIA_L40S Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 0 log files, 0 edm output root files, 1 DQM output files

@gabrielmscampos
Copy link
Copy Markdown
Member

+dqm

@Moanwar
Copy link
Copy Markdown
Contributor

Moanwar commented Feb 5, 2026

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 5, 2026

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cms-bot#2663, #50039

@ftenchini
Copy link
Copy Markdown

+1

@cmsbuild cmsbuild merged commit ea41fb2 into cms-sw:master Feb 9, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants